-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pushing large files over SCP #661
Conversation
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
|
Looks like (https://github.com/ansible/pylibssh/actions/runs/12434120667/job/34717468112?pr=661#step:17:68) |
This should be fixed by #658 I hope. |
Let's rebase this. |
Fixes: ansible#654 Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
Sure. I guess I will rework the test similarly as we did in the sftp case with parametrization once I will touch it. |
Signed-off-by: Jakub Jelen <[email protected]>
Similarly as the sftp tests do now. Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
This comment was marked as spam.
This comment was marked as spam.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (95.53%) is below the target coverage (100.00%). You can increase the head coverage or adjust the target coverage. 🚀 New features to boost your workflow:
|
SUMMARY
The SCP is trying to read the whole file into memory and send it as a whole to the server. This is very prone to hit some memory limits of the machine with larger files.
This changes the implements similar approach to the
get()
operation as done in #621, including very similar test.Fixes: #654
ISSUE TYPE