-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try grabbing query files from artifacts directory #15750
Conversation
#15754 should be ready to create a hook for further testing in a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've become concerned with this approach, and will file a followup issue. The planned schema will have an unbounded list of modules, which I expect to get extremely long and repetitive.
We've gotten burned in the past by storing large JSON content inside of job templates and jobs, because this affects query performance and list view loading performance. I think this applies to this case.
The best place to put this would be into a new model, say an internal CollectionVersion
model which is unique to the FQCN and version. This would then be addressable from the installed_collections
field already on the model.
@AlanCoding I can see the The new table could look like this:
FQCN and collection_version would form the primary key. Does that look good to you? We would also need to parse the query file once we receive it. And we can skip updating the table if there is already a query for a given collection version. |
Presumably because of ansible/ansible-runner#1273 My stance is that we should send back the collection data by the same mechanism as the event_query data. But I think we should store them in different locations, because IMO the event_query data will likely be too much to put on the job record. |
Quality Gate passedIssues Measures |
SUMMARY
Store queries discovered during job execution.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION