Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to fix offline build #15732

Closed
wants to merge 2 commits into from

Conversation

simaishi
Copy link
Contributor

@simaishi simaishi commented Jan 8, 2025

SUMMARY

Follow-up for #15705 to fix offline build

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API
ADDITIONAL INFORMATION
  • Updated VENV_BOOTSTRAP to match updates made in General upgrade of dependencies #15705
  • Downgraded setuptools to meet ansible-runner's build requirement
  • Updated msgpack as cython is updated to >=3 and the existing version requires <3

@github-actions github-actions bot added dependencies Pull requests that update a dependency file community labels Jan 8, 2025
@@ -70,7 +70,7 @@ RECEPTOR_IMAGE ?= quay.io/ansible/receptor:devel
SRC_ONLY_PKGS ?= cffi,pycparser,psycopg,twilio
# These should be upgraded in the AWX and Ansible venv before attempting
# to install the actual requirements
VENV_BOOTSTRAP ?= pip==21.2.4 setuptools==69.0.2 setuptools_scm[toml]==8.0.4 wheel==0.42.0 cython==0.29.37
VENV_BOOTSTRAP ?= pip==21.2.4 setuptools==72.1.0 setuptools_scm[toml]==8.1.0 wheel==0.45.1 cython==3.0.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cross-referencing, this makes the values match what's in requirements.txt, which is really our goof here. It would be good for us to add some form of check for this.

Copy link
Member

@AlanCoding AlanCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, last merge left things in an inconsistent state, and this fixes that

@AlanCoding
Copy link
Member

Created #15733 to address many of the loopholes that helped to create this situation.

Copy link

sonarqubecloud bot commented Jan 8, 2025

@AlanCoding
Copy link
Member

I put up simaishi#1 but I am struggling to test it.

@simaishi
Copy link
Contributor Author

Closing in favor of #15740

@simaishi simaishi closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants