Add descriptions for plugins #56
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djyasin
force-pushed
the
update_cloud_providers_and_cloud_constants_28722
branch
from
9f9b356
to
d86e798
Compare
webknjaz
reviewed
Nov 15, 2024
src/awx_plugins/inventory/plugins.py
Outdated
| @@ -1,5 +1,5 @@ | |||
| # FIXME: the following violations must be addressed gradually and unignored | |||
| # mypy: disable-error-code="assignment, no-untyped-call, no-untyped-def, var-annotated" | |||
| # mypy: disable-error-code='assignment, no-untyped-call, no-untyped-def, var-annotated' | |||
There was a problem hiding this comment.
I'm assuming a misconfigured code editor made a bunch of invasive changes, eh?
There was a problem hiding this comment.
I ran black on this before I committed and it reformatted everything- I am going to pull out those changes today!
There was a problem hiding this comment.
Why didn't you run the automation that is integrated into the repo instead?
…ed descriptions and related functionality.
djyasin
force-pushed
the
update_cloud_providers_and_cloud_constants_28722
branch
from
7af9475
to
ae262fa
Compare
for more information, see https://pre-commit.ci
webknjaz
approved these changes
Nov 15, 2024
Comment on lines
+21
to
+22
| plugin_description = None | ||
| # this field is for the description of the injector |
There was a problem hiding this comment.
In general, comments should be on the same line if possible:
Suggested change
| plugin_description = None | |
| # this field is for the description of the injector | |
| plugin_description = None # this field holds the injector description |
This is because over time, the comment line and the code line may drift away from each other by accident. And the comments will end up being in weird places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add descriptions for plugins