Hide GET params that contain senstive data from error output #47
Conversation
|
just to note as well @webknjaz it looks like one of the linters that formats code added in a |
There was a problem hiding this comment.
just to note as well @webknjaz it looks like one of the linters that formats code added in a
\for a line break that then causes wemake-services/flake8-broken-line#error-codes to be thrown. Not sure which one but we might want to update it so we don't have one linter causing another one to error.
@thedoubl3j it's an inevitable consequence of the formatter (I'm assuming autopep8 made the change) being separate from the linters. It's also because the formatter uses one of the variants that are compliant with PEP 8 but that the rule disallows that specific variant. Trailing backslashes are dangerous, it's good to disallow them. If you use different compliant formatting, autopep8 won't change it. Perhaps, I'll check out Ruff at some point to see if it could be as non-invasive as autopep8, but I'm not sure.
Additionally, such cases cannot be fully avoided for as long as there's more than one linting/formatting tool integrated and must be addressed by a human.
Another side of this is whenever linting issues arise, they often alert you about the possibility to refactor. In the case you hit, for example, the line was complex. A formatter would make it formatted, but formatted and good are not equal things. These situations always require a human to think about whatever's the underlying issue that tripped the alert.
On another note, find some concrete suggestions below.
|
pre-commit.ci run |
thedoubl3j
force-pushed
the
aim_url_fix
branch
from
498baa5
to
00190be
Compare
thedoubl3j
force-pushed
the
aim_url_fix
branch
from
82764d1
to
da6f1fb
Compare
|
pre-commit.ci run |
thedoubl3j
force-pushed
the
aim_url_fix
branch
3 times, most recently
from
b23e4de
to
abe40cb
Compare
thedoubl3j
force-pushed
the
aim_url_fix
branch
2 times, most recently
from
dfd5a22
to
01f58c8
Compare
thedoubl3j
force-pushed
the
aim_url_fix
branch
from
01f58c8
to
117a1e4
Compare
Currently, the AIM plugin is showing AppID, Object_Query and reason in the constructed URL when an error is throw and streamed back to stdout. This PR will hide those GET params from being displayed.