ansible-examples should adhere to the standards of the ansible-linter

jboss-standalone/demo-aws-launch.yml

@@ -2,32 +2,32 @@
 - name: Provision instances
   hosts: localhost
   connection: local
-  gather_facts: False
+  gather_facts: false
 
   # load AWS variables from this group vars file
   vars_files:
-  - group_vars/all
+    - group_vars/all
 
   tasks:
-  - name: Launch instances
-    ec2:
-      access_key: "{{ ec2_access_key }}"
-      secret_key: "{{ ec2_secret_key }}"
-      keypair: "{{ ec2_keypair }}"
-      group: "{{ ec2_security_group }}"
-      type: "{{ ec2_instance_type }}"
-      image: "{{ ec2_image }}"
-      region: "{{ ec2_region }}"
-      instance_tags: "{'ansible_group':'jboss', 'type':'{{ ec2_instance_type }}', 'group':'{{ ec2_security_group }}', 'Name':'demo_''{{ tower_user_name }}'}"
-      count: "{{ ec2_instance_count }}"
-      wait: true
-    register: ec2
+    - name: Launch instances
+      amazon.aws.ec2_instance:
+        access_key: "{{ ec2_access_key }}"
+        secret_key: "{{ ec2_secret_key }}"
+        keypair: "{{ ec2_keypair }}"
+        group: "{{ ec2_security_group }}"
+        type: "{{ ec2_instance_type }}"
+        image: "{{ ec2_image }}"
+        region: "{{ ec2_region }}"
+        instance_tags: "{'ansible_group':'jboss', 'type':'{{ ec2_instance_type }}', 'group':'{{ ec2_security_group }}', 'Name':'demo_''{{ tower_user_name }}'}"
+        count: "{{ ec2_instance_count }}"
+        wait: true
+      register: ec2
 
-  - name: Wait for SSH to come up
-    wait_for:
-      host: "{{ item.public_dns_name }}"
-      port: 22
-      delay: 60
-      timeout: 320
-      state: started
-    with_items: "{{ ec2.instances }}"
+    - name: Wait for SSH to come up
+      ansible.builtin.wait_for:
+        host: "{{ item.public_dns_name }}"
+        port: 22
+        delay: 60
+        timeout: 320
+        state: started
+      with_items: "{{ ec2.instances }}"

jboss-standalone/deploy-application.yml

@@ -4,6 +4,6 @@
 - hosts: all
 
   roles:
-# Optionally, (re)deploy JBoss here.
-#    - jboss-standalone
+    # Optionally, (re)deploy JBoss here.
+    #    - jboss-standalone
     - java-app

jboss-standalone/roles/java-app/tasks/main.yml

@@ -1,23 +1,23 @@
 ---
 - name: Copy application WAR file to host
-  copy:
+  ansible.builtin.copy:
     src: jboss-helloworld.war
     dest: /tmp
 
 - name: Deploy HelloWorld to JBoss
-  jboss:
+  community.general.web_infrastructure.jboss:
     deploy_path: /usr/share/jboss-as/standalone/deployments/
     src: /tmp/jboss-helloworld.war
     deployment: helloworld.war
     state: present
 
 - name: Copy application WAR file to host
-  copy:
+  ansible.builtin.copy:
     src: ticket-monster.war
     dest: /tmp
 
 - name: Deploy Ticket Monster to JBoss
-  jboss:
+  community.general.web_infrastructure.jboss:
     deploy_path: /usr/share/jboss-as/standalone/deployments/
     src: /tmp/ticket-monster.war
     deployment: ticket-monster.war

jboss-standalone/roles/jboss-standalone/handlers/main.yml

@@ -1,10 +1,12 @@
 ---
-- name: restart jboss
-  service:
+- name: Restart jboss
+  ansible.builtin.service:
     name: jboss
     state: restarted
+  listen: restart_jboss
 
-- name: restart iptables
-  service:
+- name: Restart iptables
+  ansible.builtin.service:
     name: iptables
     state: restarted
+  listen: restart_iptables

jboss-standalone/roles/jboss-standalone/tasks/main.yml

@@ -1,100 +1,102 @@
 ---
 - name: Install Java 1.7 and some basic dependencies
-  yum:
+  ansible.builtin.yum:
     name: "{{ item }}"
     state: present
   with_items:
-   - unzip
-   - java-1.7.0-openjdk
-   - libselinux-python
-   - libsemanage-python
+    - unzip
+    - java-1.7.0-openjdk
+    - libselinux-python
+    - libsemanage-python
 
 - name: Download JBoss from jboss.org
-  get_url:
+  ansible.builtin.get_url:
     url: http://download.jboss.org/jbossas/7.1/jboss-as-7.1.1.Final/jboss-as-7.1.1.Final.zip
     dest: /opt/jboss-as-7.1.1.Final.zip
 
 - name: Extract archive
-  unarchive:
+  ansible.builtin.unarchive:
     dest: /usr/share
     src: /opt/jboss-as-7.1.1.Final.zip
     creates: /usr/share/jboss-as
-    copy: no
+    copy: false
 
-  # Rename the dir to avoid encoding the version in the init script
+# Rename the dir to avoid encoding the version in the init script
 - name: Rename install directory
-  command: /bin/mv jboss-as-7.1.1.Final jboss-as 
+  ansible.builtin.command: /bin/mv jboss-as-7.1.1.Final jboss-as
   args:
-    chdir: /usr/share 
+    chdir: /usr/share
     creates: /usr/share/jboss-as
 
 - name: Copying standalone.xml configuration file
-  template:
+  ansible.builtin.template:
     src: standalone.xml
     dest: /usr/share/jboss-as/standalone/configuration/
-  notify: restart jboss
+  notify: restart_jboss
 
 - name: Add group "jboss"
-  group:
+  ansible.builtin.group:
     name: jboss
 
 - name: Add user "jboss"
-  user:
+  ansible.builtin.user:
     name: jboss
     group: jboss
     home: /usr/share/jboss-as
 
 - name: Change ownership of JBoss installation
-  file:
+  ansible.builtin.file:
     path: /usr/share/jboss-as/
     owner: jboss
     group: jboss
     state: directory
-    recurse: yes
+    recurse: true
 
 - name: Copy the init script
-  copy:
+  ansible.builtin.copy:
     src: jboss-as-standalone.sh
     dest: /etc/init.d/jboss
-    mode: 0755
+    mode: "0755"
 
 - name: Workaround for systemd bug
-  shell: service jboss start && chkconfig jboss on
-  ignore_errors: yes
+  ansible.builtin.shell: service jboss start && chkconfig jboss on
+  ignore_errors: true
 
 - name: Enable JBoss to be started at boot
-  service:
+  ansible.builtin.service:
     name: jboss
-    enabled: yes
+    enabled: true
     state: started
 
-- name: deploy iptables rules
-  template:
+- name: Deploy iptables rules
+  ansible.builtin.template:
     src: iptables-save
     dest: /etc/sysconfig/iptables
+    owner: root
+    group: root
+    mode: u=rw,g=,o=
   when: ansible_distribution_major_version != "7"
-  notify: restart iptables
+  notify: restart_iptables
 
 - name: Ensure that firewalld is installed
-  yum:
+  ansible.builtin.yum:
     name: firewalld
     state: present
   when: ansible_distribution_major_version == "7"
 
 - name: Ensure that firewalld is started
-  service:
+  ansible.builtin.service:
     name: firewalld
     state: started
   when: ansible_distribution_major_version == "7"
 
-- name: deploy firewalld rules
-  firewalld:
-    immediate: yes
+- name: Deploy firewalld rules
+  ansible.posix.firewalld:
+    immediate: true
     port: "{{ item }}"
     state: enabled
-    permanent: yes
+    permanent: true
   when: ansible_distribution_major_version == "7"
   with_items:
-  - "{{ http_port }}/tcp"
-  - "{{ https_port }}/tcp"
-
+    - "{{ http_port }}/tcp"
+    - "{{ https_port }}/tcp"

lamp_haproxy/aws/demo-aws-launch.yml

@@ -3,74 +3,74 @@
 - name: Provision instances in AWS
   hosts: localhost
   connection: local
-  gather_facts: False
+  gather_facts: false
 
   # load AWS variables from this group vars file
   vars_files:
-  - group_vars/all
+    - group_vars/all
 
   tasks:
-  - name: Launch webserver instances
-    ec2:
-      access_key: "{{ ec2_access_key }}"
-      secret_key: "{{ ec2_secret_key }}"
-      keypair: "{{ ec2_keypair }}"
-      group: "{{ ec2_security_group }}"
-      type: "{{ ec2_instance_type }}"
-      image: "{{ ec2_image }}"
-      region: "{{ ec2_region }}"
-      instance_tags: "{'ansible_group':'webservers', 'type':'{{ ec2_instance_type }}', 'group':'{{ ec2_security_group }}', 'Name':'demo_''{{ tower_user_name }}'}"
-      count: "{{ ec2_instance_count }}"
-      wait: true
-    register: ec2
+    - name: Launch webserver instances
+      ec2:
+        access_key: "{{ ec2_access_key }}"
+        secret_key: "{{ ec2_secret_key }}"
+        keypair: "{{ ec2_keypair }}"
+        group: "{{ ec2_security_group }}"
+        type: "{{ ec2_instance_type }}"
+        image: "{{ ec2_image }}"
+        region: "{{ ec2_region }}"
+        instance_tags: "{'ansible_group':'webservers', 'type':'{{ ec2_instance_type }}', 'group':'{{ ec2_security_group }}', 'Name':'demo_''{{ tower_user_name }}'}"
+        count: "{{ ec2_instance_count }}"
+        wait: true
+      register: ec2
 
-  - name: Launch database instance
-    ec2:
-      access_key: "{{ ec2_access_key }}"
-      secret_key: "{{ ec2_secret_key }}"
-      keypair: "{{ ec2_keypair }}"
-      group: "{{ ec2_security_group }}"
-      type: "{{ ec2_instance_type }}"
-      image: "{{ ec2_image }}"
-      region: "{{ ec2_region }}"
-      instance_tags: "{'ansible_group':'dbservers', 'type':'{{ ec2_instance_type }}', 'group':'{{ ec2_security_group }}', 'Name':'demo_''{{ tower_user_name }}'}"
-      count: "1"
-      wait: true
-    register: ec2
+    - name: Launch database instance
+      ec2:
+        access_key: "{{ ec2_access_key }}"
+        secret_key: "{{ ec2_secret_key }}"
+        keypair: "{{ ec2_keypair }}"
+        group: "{{ ec2_security_group }}"
+        type: "{{ ec2_instance_type }}"
+        image: "{{ ec2_image }}"
+        region: "{{ ec2_region }}"
+        instance_tags: "{'ansible_group':'dbservers', 'type':'{{ ec2_instance_type }}', 'group':'{{ ec2_security_group }}', 'Name':'demo_''{{ tower_user_name }}'}"
+        count: "1"
+        wait: true
+      register: ec2
 
-  - name: Launch load balancing instance
-    ec2:
-      access_key: "{{ ec2_access_key }}"
-      secret_key: "{{ ec2_secret_key }}"
-      keypair: "{{ ec2_keypair }}"
-      group: "{{ ec2_security_group }}"
-      type: "{{ ec2_instance_type }}"
-      image: "{{ ec2_image }}"
-      region: "{{ ec2_region }}"
-      instance_tags: "{'ansible_group':'lbservers', 'type':'{{ ec2_instance_type }}', 'group':'{{ ec2_security_group }}', 'Name':'demo_''{{ tower_user_name }}'}"
-      count: "1"
-      wait: true
-    register: ec2
+    - name: Launch load balancing instance
+      ec2:
+        access_key: "{{ ec2_access_key }}"
+        secret_key: "{{ ec2_secret_key }}"
+        keypair: "{{ ec2_keypair }}"
+        group: "{{ ec2_security_group }}"
+        type: "{{ ec2_instance_type }}"
+        image: "{{ ec2_image }}"
+        region: "{{ ec2_region }}"
+        instance_tags: "{'ansible_group':'lbservers', 'type':'{{ ec2_instance_type }}', 'group':'{{ ec2_security_group }}', 'Name':'demo_''{{ tower_user_name }}'}"
+        count: "1"
+        wait: true
+      register: ec2
 
-  - name: Launch monitoring instance
-    ec2:
-      access_key: "{{ ec2_access_key }}"
-      secret_key: "{{ ec2_secret_key }}"
-      keypair: "{{ ec2_keypair }}"
-      group: "{{ ec2_security_group }}"
-      type: "{{ ec2_instance_type }}"
-      image: "{{ ec2_image }}"
-      region: "{{ ec2_region }}"
-      instance_tags: "{'ansible_group':'monitoring', 'type':'{{ ec2_instance_type }}', 'group':'{{ ec2_security_group }}', 'Name':'demo_''{{ tower_user_name }}'}"
-      count: "1"
-      wait: true
-    register: ec2
+    - name: Launch monitoring instance
+      ec2:
+        access_key: "{{ ec2_access_key }}"
+        secret_key: "{{ ec2_secret_key }}"
+        keypair: "{{ ec2_keypair }}"
+        group: "{{ ec2_security_group }}"
+        type: "{{ ec2_instance_type }}"
+        image: "{{ ec2_image }}"
+        region: "{{ ec2_region }}"
+        instance_tags: "{'ansible_group':'monitoring', 'type':'{{ ec2_instance_type }}', 'group':'{{ ec2_security_group }}', 'Name':'demo_''{{ tower_user_name }}'}"
+        count: "1"
+        wait: true
+      register: ec2
 
-  - name: Wait for SSH to come up
-    wait_for:
-      host: "{{ item.public_dns_name }}"
-      port: 22
-      delay: 60
-      timeout: 320
-      state: started
-    with_items: "{{ ec2.instances }}"
+    - name: Wait for SSH to come up
+      wait_for:
+        host: "{{ item.public_dns_name }}"
+        port: 22
+        delay: 60
+        timeout: 320
+        state: started
+      with_items: "{{ ec2.instances }}"