-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR to apply for E2E OLS evaluation framework for AAP chatbot #47
Conversation
@justjais I have rebased ansible-chatbot-service to the latest upstream (road-core/service). Would you rebase to the current main branch? Sorry for causing extra work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justjais I think we want to update those evaluation-related files whenever OLS updates their files. For that purpose, would you add following changes?
- Copy all files under
scripts/evaluation
in the OLS repo even if they are not used. I think it is easier for us to have them when we import changes in the OLS repo. - If any additional files are required, give file names that include
aap-
- Create
scripts/evaluation/README-aap.md
to document what was changed/added from/to the OLS code. - Also document how to run the tool for Ansible chatbot in the same
scripts/evaluation/README-aap.md
file.
f26a7a1
to
8d092ac
Compare
Description
PR to apply for E2E OLS evaluation framework for AAP chatbot
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing
make install-deps
, for this user need to cloneansible-chatbot-service
repo.E2E
tests locally, user need to configureolsconfig.yaml
and copy to parent directory, for AAP chatbot scenario sample olsconfig.yaml is under/scripts/evaluation/
folder.aap_doc_qna.parquet
under/scripts/evaluation/eval_data/
folder, or else run over sample QnA defined underscripts/evaluation/eval_data/aap-sample.parquet
file.