Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_vsan_hcl_db: Add initial module #1675

Merged
merged 2 commits into from
Mar 17, 2023
Merged

vmware_vsan_hcl_db: Add initial module #1675

merged 2 commits into from
Mar 17, 2023

Conversation

p-fruck
Copy link
Contributor

@p-fruck p-fruck commented Mar 14, 2023

SUMMARY

This module can be used to upload the HCL DB to an air-gapped vCenter instance.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

vmware_vsan_hcl_db

ADDITIONAL INFORMATION

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/23731be6aba147a78e96b4b59bf8d74e

✔️ ansible-tox-linters SUCCESS in 8m 36s
✔️ build-ansible-collection SUCCESS in 9m 16s
⚠️ ansible-test-sanity-docker-devel CANCELED (non-voting)
⚠️ ansible-test-sanity-docker-milestone CANCELED (non-voting)
❌ ansible-test-sanity-docker-stable-2.13 FAILURE in 9m 29s
⚠️ ansible-test-sanity-docker-stable-2.14 CANCELED in 9m 29s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 7m 37s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 18s

@p-fruck
Copy link
Contributor Author

p-fruck commented Mar 14, 2023

Regarding the failed pipeline: Why is it required to have the interpreter set to /usr/bin/python when /usr/bin/env python3 is preferred nowadays?

@mariolenz
Copy link
Collaborator

Regarding the failed pipeline: Why is it required to have the interpreter set to /usr/bin/python when /usr/bin/env python3 is preferred nowadays?

Good question, but I can't answer it. The CI fails because ansible-test sanity fails, and this is part of and maintained by ansible-core. You should ask them.

BTW, shebang says: This does not apply to Ansible modules, which should not be executable and must always use #!/usr/bin/python.

You could also ask on Matrix (#community:ansible.com) or IRC (#ansible-community) to get an answer if you're really interested (see Communicating with the Ansible community). No matter which one, they're bridged AFAIK.

@p-fruck
vmware_vsan_hcl_db: Add initial module
810febf 
This module can be used to upload the HCL DB to
an airgapped vCenter instance.
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/6959a8c0d46f4dabbbff27d7bd1904eb

✔️ ansible-tox-linters SUCCESS in 8m 31s
✔️ build-ansible-collection SUCCESS in 9m 24s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 56s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 47s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 53s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 20s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 4m 47s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable214 FAILURE in 20m 32s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 53s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/3148e74501b74e01ae1f5d86f46515f7

✔️ ansible-tox-linters SUCCESS in 8m 25s
✔️ build-ansible-collection SUCCESS in 9m 06s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 32s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 19s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 39s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 7m 26s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 55s
❌ ansible-test-cloud-integration-vcenter7_only-stable214 RETRY_LIMIT in 1h 00m 37s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 SUCCESS in 19m 15s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 SUCCESS in 57m 24s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 SUCCESS in 52m 33s
✔️ ansible-galaxy-importer SUCCESS in 3m 52s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0cba5ec682c84feb92ffb71627717aa1

✔️ ansible-tox-linters SUCCESS in 8m 28s
✔️ build-ansible-collection SUCCESS in 9m 16s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 24s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 21s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 14s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 23s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 08s
✔️ ansible-test-cloud-integration-vcenter7_only-stable214 SUCCESS in 18m 36s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 SUCCESS in 19m 19s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 SUCCESS in 48m 27s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 SUCCESS in 54m 31s
✔️ ansible-galaxy-importer SUCCESS in 3m 26s

mariolenz
mariolenz requested changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @p-fruck! There are just a few minor changes you should implement.

plugins/modules/vmware_vsan_hcl_db.py Show resolved Hide resolved
plugins/modules/vmware_vsan_hcl_db.py Outdated Show resolved Hide resolved
plugins/modules/vmware_vsan_hcl_db.py Outdated Show resolved Hide resolved
@p-fruck
Copy link
Contributor Author

p-fruck commented Mar 17, 2023

Thanks for the suggestions @mariolenz , I've added them to the PR and will keep them in mind for future modules ;)

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3f11a926c44d4845b19f6fa29b1623de

✔️ ansible-tox-linters SUCCESS in 8m 21s
✔️ build-ansible-collection SUCCESS in 9m 08s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 17s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 24s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 31s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 07s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 53s
✔️ ansible-test-cloud-integration-vcenter7_only-stable214 SUCCESS in 18m 49s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 SUCCESS in 19m 34s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 SUCCESS in 56m 32s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 SUCCESS in 59m 21s
✔️ ansible-galaxy-importer SUCCESS in 3m 50s

mariolenz
mariolenz approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @p-fruck!

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/22853efb5e29492b8a7714449e232571

✔️ ansible-tox-linters SUCCESS in 8m 31s
✔️ build-ansible-collection SUCCESS in 7m 12s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 14s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 45s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 4m 51s
✔️ ansible-galaxy-importer SUCCESS in 4m 02s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a205c2a into ansible-collections:main Mar 17, 2023
@mariolenz mariolenz mentioned this pull request May 17, 2023
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request May 22, 2023
@p-fruck
add vmware_vsan_release_catalog module (#1702)
60df9ac 
add vmware_vsan_release_catalog module

SUMMARY

This module allows to manually upload the vSAN release catalog to the vCenter which is useful for airgapped environments or other environments where the vCenter cannot directly connect to the VMware cloud service.

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

vmware_vsan_release_catalog
ADDITIONAL INFORMATION
Similar to #1675

Reviewed-by: Mario Lenz <[email protected]>
Reviewed-by: Philipp Fruck <[email protected]>
@mariolenz mariolenz mentioned this pull request Jun 4, 2023
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 5, 2023
@mariolenz
meta/runtime.yml: Add missing modules (#1764)
b01f35d 
meta/runtime.yml: Add missing modules

SUMMARY
Add missing modules to meta/runtime.yml.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
runtime.yml
ADDITIONAL INFORMATION
#1675
#1702
#1704
#1736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariolenz mariolenz mariolenz approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p-fruck @mariolenz