Update _api_data.py #324
Open
Update _api_data.py #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'log': KeyInfo(can_disable=True), | ||
| 'log-prefix': KeyInfo(can_disable=True), | ||
| 'log': KeyInfo(default=False), | ||
| 'log-prefix': KeyInfo(default=''), |
There was a problem hiding this comment.
What's the reason behind this change? Was the behavior always wrong, or did RouterOS's behavior change from one version to another?
There was a problem hiding this comment.
As far as I'm concerned, the behavior was always wrong. I have tested on 6.49.10, 6.49.13, 7.14.1. If you use the --diff parameter in ansible with check mode, you will see that each time ansible tries to remove these fields.
There was a problem hiding this comment.
I can second that. It was always bugging me but I didn't have the time to investigate.
Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The behavior of the log and log-prefix fields has been changed. Previously, if these fields were not declared in the code, Ansible would attempt to delete them. Now, if the fields are not declared, Ansible will assign them the default value for the router OS
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION