Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default to snmp community api_data #311

Merged
merged 6 commits into from
Sep 10, 2024

Conversation

Tr4sK
Copy link
Contributor

@Tr4sK Tr4sK commented Aug 25, 2024

SUMMARY

Add missing default attribute to api_data

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
  • snmp community

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@felixfontein
Copy link
Collaborator

Can you please remove the @ from the commit messages? With the @ in them I get a notification every single time these commits are pushed somewhere, which is a bit annoying :)

@Tr4sK
Copy link
Contributor Author

Tr4sK commented Aug 25, 2024

Can you please remove the @ from the commit messages? With the @ in them I get a notification every single time these commits are pushed somewhere, which is a bit annoying :)

done. Sorry for that

@felixfontein
Copy link
Collaborator

No worries. There's a second commit with a @ in its message though :)

@Tr4sK
Copy link
Contributor Author

Tr4sK commented Aug 25, 2024

Is there a way to not change api_modify ?
Since, the API can list the default snmp community but do not accept that parameter as a modification.
Any way to mark it as readonly ?

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so that field is read-only and cannot be set? In that case you can use read_only=True:

plugins/module_utils/_api_data.py Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Sep 10, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.routeros/branch/main

@felixfontein felixfontein merged commit 136250a into ansible-collections:main Sep 10, 2024
44 checks passed
@felixfontein
Copy link
Collaborator

@Tr4sK thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants