Fix: synchronize directories contains spaces in their paths

[m-emelchenkov]

SUMMARY

It's a hotfix for problem that Ansible cannot synchronize files if directories contains whitespaces in their paths. This bug there for years (at least since 2015), I thought I submitted the fix. Anyway, please review it and make my code to be more optimal for Python or Ansible code guidelines.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

Synchronize

[m-emelchenkov]

It seems, my fix do not pass CI tests. My environment is: source machine is macOS 12.2.1 and dest machine is Linux Ubuntu 20.04.

[saito-hideki]

@m-emelchenkov thanks for the PR :)
Currently, there is an issue(504 timeout) with galaxy.ansible.com, so we probably need to wait to fix it.

[softwarefactory-project-zuul]

Build failed.

• ansible-changelog-fragment : FAILURE in 2m 09s
• ansible-test-sanity-docker-devel : SUCCESS in 8m 21s (non-voting)
• ansible-test-sanity-docker-milestone : SUCCESS in 9m 43s
• ansible-test-sanity-docker-stable-2.9 : SUCCESS in 16m 07s
• ansible-test-sanity-docker-stable-2.10 : SUCCESS in 9m 48s
• ansible-test-sanity-docker-stable-2.11 : SUCCESS in 8m 37s
• ansible-test-sanity-docker-stable-2.12 : SUCCESS in 14m 25s
• ansible-test-units-posix : SUCCESS in 7m 26s
• ansible-ee-tests-latest : RETRY_LIMIT in 7m 49s
• ansible-ee-tests-stable-2.9 : RETRY_LIMIT in 5m 21s
• ansible-ee-tests-stable-2.11 : RETRY_LIMIT in 1m 04s
• ansible-ee-tests-stable-2.12 : RETRY_LIMIT in 7m 27s
• ansible-galaxy-importer : SUCCESS in 3m 13s
• build-ansible-collection : SUCCESS in 5m 09s

[maxamillion]

/retest

[cwerner1]

/retest

[cwerner1]

is this still stuck in the review pipeline?

[maxamillion]

@cwerner1 my apologies, it seems this got forgotten ... closing and reopening to kick CI and I'll review.

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/8900bd9768c740c0b96638a973493c6f

✔️ ansible-galaxy-importer SUCCESS in 3m 19s
✔️ build-ansible-collection SUCCESS in 7m 56s

[m-emelchenkov]

Hi! Thanks for re-opening. I just patched my local sources and pinned the package and use it without further upgrading. I did not return to Ansible automation already for more than a year.
I see, many tests are failed. Sorry, I am not sure how to run your tests locally. I.e. if you could send me test environment for Docker/Podman for ARM M1, I may run it and try to debug the code. However, not sure when...