Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resolve CI checks fail - Module at add chdir(#102) #218

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

mandar242
Copy link
Contributor

SUMMARY

Resolves CI checks failing at #102 which fixes #13

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

at

ADDITIONAL INFORMATION


@saito-hideki
Copy link
Collaborator

Hi @mandar242, thank you for the PR!
Looking at the output of CI processes, it seems that you are running into a temporary CI issue.
So I think you can try the following two options (a) or (b) to re-run CI jobs according to the official guide here to avoid this:

(a) adding a comment with /rebuild (full rebuild) or /rebuild_failed (rebuild only failed CI nodes) to the PR
(b) closing and re-opening the PR (full rebuild)

I hope this helps :)

plugins/modules/at.py Outdated Show resolved Hide resolved
plugins/modules/at.py Outdated Show resolved Hide resolved
- at_chdir_invalid is changed
when:
- not (ansible_facts['distribution'] in ('Ubuntu','FreeBSD'))
- not (ansible_distribution == "CentOS" and ansible_distribution_version is version('6', '=='))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why CentOS 6 is disabled?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem here is that despite what the man page says, the version of at that ships with CentOS 6 does not seem to actually support the -r option. I'm not sure what OS X 10.11's problem is with ansible 2.10.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Akasurde @gravesm
I think that the -r option issue on CentOS6 will be fixed on #228

@saito-hideki
Copy link
Collaborator

Closing and reopening for CI trigger

@saito-hideki saito-hideki reopened this Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Add chdir parm to the at module
5 participants