-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libssh connection: stop using PlayContext.verbosity #626
Merged
rohitthakur2590
merged 2 commits into
ansible-collections:main
from
felixfontein:verbosity
Apr 11, 2024
Merged
libssh connection: stop using PlayContext.verbosity #626
rohitthakur2590
merged 2 commits into
ansible-collections:main
from
felixfontein:verbosity
Apr 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Fontein <[email protected]>
This actually also fixes (at least) some errors that let the nightly tests of this collection fail, see for example https://github.com/ansible-collections/ansible.netcommon/actions/runs/8639352911/job/23685500335 |
rohitthakur2590
approved these changes
Apr 11, 2024
rohitthakur2590
merged commit Apr 11, 2024
84c8607
into
ansible-collections:main
54 of 55 checks passed
@rohitthakur2590 thanks for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Right now libssh cannot be used with ansible-core devel (to be 2.18) since the deprecated
PlayContext.verbosity
has been removed. (This currently makes the nightly community.routeros tests fail.)Fixes #541.
Similar to #625.
ISSUE TYPE
COMPONENT NAME
libssh