Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing FQCN cloudwatch_metric_alarm #2380

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix missing FQCN cloudwatch_metric_alarm #2380

merged 2 commits into from
Nov 6, 2024

Conversation

brahmanim
Copy link
Contributor

SUMMARY

Add some missing FQCN on cloudwatch_metric_alarm integration tests,
and fix failure on downstream integration test run.

Refer: https://issues.redhat.com/browse/ACA-1961

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@alinabuzachis alinabuzachis added backport-8 PR should be backported to the stable-8 branch backport-9 labels Nov 6, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7b1173bcae7548fcb493a6a3067c2303

✔️ ansible-galaxy-importer SUCCESS in 8m 27s
✔️ build-ansible-collection SUCCESS in 10m 35s
✔️ ansible-test-splitter SUCCESS in 4m 13s
✔️ integration-amazon.aws-1 SUCCESS in 8m 31s
Skipped 43 jobs

@brahmanim brahmanim added the mergeit Merge the PR (SoftwareFactory) label Nov 6, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/1cb97407ad2c4d87aeaa3c77c585eb7d

✔️ ansible-galaxy-importer SUCCESS in 5m 10s
✔️ build-ansible-collection SUCCESS in 10m 30s
✔️ ansible-test-splitter SUCCESS in 3m 51s
✔️ integration-amazon.aws-1 SUCCESS in 9m 14s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit cbf4d8a into ansible-collections:main Nov 6, 2024
38 checks passed
@patchback Patchback
Copy link

patchback bot commented Nov 6, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/cbf4d8ae1cf0d345e4fb1348ab4ab67d38354fe0/pr-2380

Backported as #2381

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 6, 2024
@brahmanim @patchback
Fix missing FQCN cloudwatch_metric_alarm (#2380)
e5124df 
SUMMARY

Add some missing FQCN on cloudwatch_metric_alarm integration tests,
and fix failure on downstream integration test run.

Refer: https://issues.redhat.com/browse/ACA-1961
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Reviewed-by: Helen Bailey <[email protected]>
(cherry picked from commit cbf4d8a)
@patchback patchback bot mentioned this pull request Nov 6, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Nov 6, 2024 •
edited
Loading

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/cbf4d8ae1cf0d345e4fb1348ab4ab67d38354fe0/pr-2380

Backported as #2382

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 6, 2024
@brahmanim @patchback
Fix missing FQCN cloudwatch_metric_alarm (#2380)
e5e9eaa 
SUMMARY

Add some missing FQCN on cloudwatch_metric_alarm integration tests,
and fix failure on downstream integration test run.

Refer: https://issues.redhat.com/browse/ACA-1961
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Reviewed-by: Helen Bailey <[email protected]>
(cherry picked from commit cbf4d8a)
@patchback patchback bot mentioned this pull request Nov 6, 2024
Merged
@brahmanim brahmanim deleted the fqcn_cloudwatch_metric_alarm branch November 6, 2024 17:13
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Nov 7, 2024
@patchback
Fix missing FQCN cloudwatch_metric_alarm (#2380) (#2382)
842cff0 
This is a backport of PR #2380 as merged into main (cbf4d8a).
SUMMARY

Add some missing FQCN on cloudwatch_metric_alarm integration tests,
and fix failure on downstream integration test run.

Refer: https://issues.redhat.com/browse/ACA-1961
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Nov 7, 2024
@patchback
Fix missing FQCN cloudwatch_metric_alarm (#2380) (#2381)
ff56064 
This is a backport of PR #2380 as merged into main (cbf4d8a).
SUMMARY

Add some missing FQCN on cloudwatch_metric_alarm integration tests,
and fix failure on downstream integration test run.

Refer: https://issues.redhat.com/browse/ACA-1961
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@hakbailey hakbailey hakbailey approved these changes

Assignees
No one assigned
Labels
backport-8 PR should be backported to the stable-8 branch backport-9 mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brahmanim @hakbailey @alinabuzachis