Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ec2 transit gateway empty description #2375

Conversation

gravesm
Copy link
Member

@gravesm gravesm commented Nov 5, 2024

SUMMARY

When one or more TGWs exist with an empty description, the module will fail.

Fixes #2368

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_transit_gateway

ADDITIONAL INFORMATION

Apparently, ansible-collections/community.aws#2086 failed to merge, and the ec2_transit_gateway module has now been migrated to amazon.aws. This PR just cherry-picks the commits on top of this repo.


Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/abc61a6f33624cc0be91ae7de245577b

✔️ ansible-galaxy-importer SUCCESS in 6m 56s
✔️ build-ansible-collection SUCCESS in 10m 40s
✔️ ansible-test-splitter SUCCESS in 3m 56s
✔️ integration-amazon.aws-1 SUCCESS in 10m 34s
Skipped 43 jobs

@gravesm gravesm force-pushed the ec2-transit-gateway-empty-description branch from c96dbc4 to ec21b6d Compare November 11, 2024 13:56
@gravesm gravesm force-pushed the ec2-transit-gateway-empty-description branch from ec21b6d to d921794 Compare November 11, 2024 13:57
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/22d5c0ddf89e47e195b41802b6549081

✔️ ansible-galaxy-importer SUCCESS in 4m 52s
✔️ build-ansible-collection SUCCESS in 10m 21s
✔️ ansible-test-splitter SUCCESS in 3m 54s
✔️ integration-amazon.aws-1 SUCCESS in 10m 44s
Skipped 43 jobs

@gravesm gravesm added the mergeit Merge the PR (SoftwareFactory) label Nov 11, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/844250d66d2941eaa01451b4237654d4

✔️ ansible-galaxy-importer SUCCESS in 4m 13s
✔️ build-ansible-collection SUCCESS in 10m 27s
✔️ ansible-test-splitter SUCCESS in 3m 57s
✔️ integration-amazon.aws-1 SUCCESS in 11m 04s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 69d81d5 into ansible-collections:main Nov 11, 2024
45 checks passed
Copy link

patchback bot commented Nov 11, 2024

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/69d81d54b8cba18eaeeec3189d2baea5c262db27/pr-2375

Backported as #2388

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 11, 2024
SUMMARY

When one or more TGWs exist with an empty description, the module will fail.
Fixes #2368

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ec2_transit_gateway
ADDITIONAL INFORMATION

Apparently, ansible-collections/community.aws#2086 failed to merge, and the ec2_transit_gateway module has now been migrated to amazon.aws. This PR just cherry-picks the commits on top of this repo.

Reviewed-by: Alina Buzachis
Reviewed-by: GomathiselviS <[email protected]>
(cherry picked from commit 69d81d5)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Nov 11, 2024
This is a backport of PR #2375 as merged into main (69d81d5).
SUMMARY

When one or more TGWs exist with an empty description, the module will fail.
Fixes #2368

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ec2_transit_gateway
ADDITIONAL INFORMATION


Apparently, ansible-collections/community.aws#2086 failed to merge, and the ec2_transit_gateway module has now been migrated to amazon.aws. This PR just cherry-picks the commits on top of this repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-9 mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'Description' when deleting transit gateway
4 participants