Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM Migrate elb_classic_lb_info modules and tests #2350

Merged

Commits on Oct 21, 2024

  1. Initial commit

    jillr authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    fffc818 View commit details
    Browse the repository at this point in the history
  2. Rename collection (ansible-collections#12)

    * Rename core collection
    
    Rename references to ansible.amazon to amazon.aws.
    
    * Rename community.amazon to community.aws
    Fix pep8 line lengths for rewritten amazon.aws imports
    
    * Missed a path in shippable.sh
    * Dependency repos moved
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@235c5db
    jillr authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3553260 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    20e54cc View commit details
    Browse the repository at this point in the history
  4. Remove METADATA and cleanup galaxy.yml (ansible-collections#70)

    * Remove ANSIBLE_METADATA entirely, see ansible/ansible/pull/69454.
    Remove `license` field from galaxy.yml, in favor of `license_file`.
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@05672a6
    jillr authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e4654ca View commit details
    Browse the repository at this point in the history
  5. Collections related fixes for CI (ansible-collections#96)

    * Update module deprecations
    
    Switch version to `removed_at_date`
    
    * Don't install amazon.aws from galaxy
    
    We've been using galaxy to install amazon.aws in shippable, but that
    doesn't really work if we aren't publising faster. Get that collection
    from git so it is most up to date.
    
    * We need to declare python test deps now
    
    * missed a python dep
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@7cd211e
    jillr authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    ded2bec View commit details
    Browse the repository at this point in the history
  6. Update Examples with FQCN (ansible-collections#67)

    Updated module examples with FQCN
    
    Signed-off-by: Abhijeet Kasurde <[email protected]>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@98173ae
    Akasurde authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    2346e58 View commit details
    Browse the repository at this point in the history
  7. Update module_utils paths to remove aws subdir (ansible-collections#23)

    Co-authored-by: Ezekiel Hendrickson <[email protected]>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@10853d9
    2 people authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a4f2c2e View commit details
    Browse the repository at this point in the history
  8. Update docs (ansible-collections#99)

    * Update docs
    
    Remove .git from repo url so links in readme will generate correctly
    Add required ansible version
    Run latest version of add_docs.py
    Add version_added string to modules
    
    * galaxy.yml was missing authors
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@96ee268
    jillr authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    0170738 View commit details
    Browse the repository at this point in the history
  9. Docs: sanity fixes (ansible-collections#133)

    Signed-off-by: Abhijeet Kasurde <[email protected]>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@059cf9e
    Akasurde authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3efc03a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1462b6b View commit details
    Browse the repository at this point in the history
  11. AWS ELB: Return empty list when no load balancer name was found (ansi…

    …ble-collections#215)
    
    When trying to describe a LoadBalancer that doesn't exist, the module crash. Instead of that behavior, this commit will return an empty list when no load balancer is found, allowing to deal next tasks by reading the output of the module.
    
    Co-authored-by: Pedro Magalhães <[email protected]>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@3d5ffdc
    2 people authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7cef0a3 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    51da143 View commit details
    Browse the repository at this point in the history
  13. ELB info: return all LB if names is not defined (ansible-collections#693

    )
    
    ELB info: return all LB if names is not defined
    
    SUMMARY
    Documentation says
    options:
      names:
        description:
          - List of ELB names to gather information about. Pass this option to gather information about a set of ELBs, otherwise, all ELBs are returned.
    
    But doing this elb_classic_lb_info returns an empty list.
    ISSUE TYPE
    
    Bugfix Pull Request
    
    COMPONENT NAME
    elb_classic_lb_info
    ADDITIONAL INFORMATION
    - hosts: localhost
      tasks:
      - community.aws.elb_classic_lb_info: {}
        register: elb_info
    
      - debug: var=elb_info
    
    $ ansible-playbook playbook.yaml
    TASK [community.aws.elb_classic_lb_info] ********
    ok: [localhost]
    
    TASK [debug] ********
    ok: [localhost] => {
        "elb_info": {
            "changed": false,
            "elbs": [],  # <-- should return list of all ELB
            "failed": false
        }
    }
    
    Reviewed-by: Mark Chappell <None>
    Reviewed-by: None <None>
    Reviewed-by: None <None>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@bebdd75
    christophemorio authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    d759443 View commit details
    Browse the repository at this point in the history
  14. Remove deprecated "facts" aliases (ansible-collections#814)

    Remove deprecated "facts" aliases
    
    SUMMARY
    Modules named "facts.py" that do not return ansible_facts were renamed to "info.py" in 2.9. Remove these aliases now that the deprecation period is over.
    This PR should be included in 3.0.0 of the collection.
    ISSUE TYPE
    
    Bugfix Pull Request
    
    COMPONENT NAME
    *_facts.py
    
    Reviewed-by: Mark Chappell <None>
    Reviewed-by: Jill R <None>
    Reviewed-by: None <None>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@68aaa70
    jillr authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    0cabef0 View commit details
    Browse the repository at this point in the history
  15. Integration test dependency cleanup (ansible-collections#1086)

    Integration test dependency cleanup
    
    SUMMARY
    
    remove dependencies on setup_remote_tmp_dir where it's not used (often just copy & paste from another test)
    remove setup_ec2 (no main.yml means it's not doing anything)
    remove prepare_tests (empty main.yml means it's not doing anything)
    
    ISSUE TYPE
    
    Feature Pull Request
    
    COMPONENT NAME
    tests/integration/targets
    ADDITIONAL INFORMATION
    By cleaning up what we have we reduce the chance of people copying things about "because that's what test XYZ did".
    
    Reviewed-by: Alina Buzachis <None>
    Reviewed-by: Mark Woolley <[email protected]>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@dd12046
    tremble authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    c99d2a0 View commit details
    Browse the repository at this point in the history
  16. Update extends_documentation_fragment with amazon.aws.boto3 (ansible-…

    …collections#1459)
    
    Update extends_documentation_fragment with amazon.aws.boto3
    
    Depends-On: ansible/ansible-zuul-jobs#1654
    SUMMARY
    
    As per ansible-collections#985 add amazon.aws.boto3.
    
    ISSUE TYPE
    
    Docs Pull Request
    
    COMPONENT NAME
    
    several
    
    Reviewed-by: Jill R <None>
    Reviewed-by: Mark Chappell <None>
    Reviewed-by: Markus Bergholz <[email protected]>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@bd3c03f
    alinabuzachis authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    6aad82a View commit details
    Browse the repository at this point in the history
  17. Fix non-matching defaults in docs (ansible-collections#1576)

    Fix non-matching defaults in docs
    
    Depends-On: ansible-collections#1579
    SUMMARY
    Fix various non-matching default values exposed by ansible/ansible#79267.
    ISSUE TYPE
    
    Docs Pull Request
    
    COMPONENT NAME
    various
    
    Reviewed-by: Markus Bergholz <[email protected]>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@15568f0
    felixfontein authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    067ec70 View commit details
    Browse the repository at this point in the history
  18. Ansible User-Agent identification for community.aws (ansible-collecti…

    …ons#1632)
    
    Ansible User-Agent identification for community.aws
    
    SUMMARY
    
    The value will be similar to this APN/1.0 Ansible/2.14.1 community.aws/6.0.0-dev0
    
    ISSUE TYPE
    
    Feature Pull Request
    
    Reviewed-by: Mark Chappell <None>
    Reviewed-by: Bikouo Aubin <None>
    Reviewed-by: Alina Buzachis <None>
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@a8cbce2
    abikouo authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a8847ab View commit details
    Browse the repository at this point in the history
  19. Cleanup headers and imports (ansible-collections#1738)

    Cleanup headers and imports
    
    SUMMARY
    Mass update of imports, docs fragments and file headers
    
    Many of the amazon.aws module_utils and docs fragments got moved about, update community.aws to reflect this.
    Consistently apply the comment headers as documented at https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_documenting.html#python-shebang-utf-8-coding
    
    ISSUE TYPE
    
    Docs Pull Request
    Feature Pull Request
    
    COMPONENT NAME
    ADDITIONAL INFORMATION
    Header cleanup based upon:
    https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_documenting.html#python-shebang-utf-8-coding
    
    Begin your Ansible module with #!/usr/bin/python - this “shebang” allows ansible_python_interpreter to work. Follow the shebang immediately with # -*- coding: utf-8 -*- to clarify that the file is UTF-8 encoded.
    
    and
    https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_documenting.html#copyright-and-license
    
    After the shebang and UTF-8 coding, add a copyright line with the original copyright holder and a license declaration. The license declaration should be ONLY one line, not the full GPL prefix.
    ...
    Additions to the module (for instance, rewrites) are not permitted to add additional copyright lines other than the default copyright statement if missing:
    
    Reviewed-by: Alina Buzachis
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@a4f20bf
    tremble authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a1610e6 View commit details
    Browse the repository at this point in the history
  20. Big Black PR (ansible-collections#1784)

    * Black prep
    
    * Black
    
    * changelog
    
    * Fix pylint unused-import in tests
    
    * Split SSM connection plugin changes
    
    * disable glue tests - bucket's missing
    
    * Disable s3_logging and s3_sync tests
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@2c4575c
    tremble authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    8f20c89 View commit details
    Browse the repository at this point in the history
  21. Mass update of docs and tests (credentials/session tokens) (ansible-c…

    …ollections#1921)
    
    Mass update of docs and tests (credentials/session tokens)
    
    SUMMARY
    We had a cleanup of credentials/session parameters which included a batch of deprecations and renames.
    Ensure that all of our tests and docs are using the 'canonical' names
    ISSUE TYPE
    
    Docs Pull Request
    
    COMPONENT NAME
    plugins/modules/batch_compute_environment.py
    plugins/modules/cloudformation_exports_info.py
    plugins/modules/ec2_vpc_vpn.py
    plugins/modules/elasticache.py
    plugins/modules/elasticache_parameter_group.py
    plugins/modules/elasticache_snapshot.py
    plugins/modules/ses_rule_set.py
    plugins/modules/sts_assume_role.py
    plugins/modules/sts_session_token.py
    tests/integration
    ADDITIONAL INFORMATION
    See also
    
    ansible-collections#1172
    ansible-collections#1714
    
    Reviewed-by: Alina Buzachis
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@4a5b50e
    tremble authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    06081a2 View commit details
    Browse the repository at this point in the history
  22. Apply isort and flynt (ansible-collections#1962)

    SUMMARY
    
    Apply isort - see also ansible-collections#1771
    Apply flynt - see also ansible-collections#1802
    
    ISSUE TYPE
    
        Feature Pull Request
    
    COMPONENT NAME
    
    ADDITIONAL INFORMATION
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@c0117b5
    tremble authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    fb0bf19 View commit details
    Browse the repository at this point in the history
  23. fix unsafe asserts (ansible-collections#2013)

    fix unsafe asserts
    
    SUMMARY
    Closes ansible-collections#2012
    ISSUE TYPE
    
    Bugfix Pull Request
    
    COMPONENT NAME
    integrationtests
    
    Reviewed-by: Mark Chappell
    Reviewed-by: Alina Buzachis
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@4bdcecd
    markuman authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7872b52 View commit details
    Browse the repository at this point in the history
  24. ansible-lint (documentation) cleanup for plugins/ (ansible-collection…

    …s#2036)
    
    ansible-lint (documentation) cleanup for plugins/
    
    SUMMARY
    Fixes an array of ansible-lint failures in plugins/
    Adds ansible-lint plugins/ to tox -m lint
    ISSUE TYPE
    
    Docs Pull Request
    
    COMPONENT NAME
    plugins/
    ADDITIONAL INFORMATION
    docs changes only (no changelog fragment needed)
    
    Reviewed-by: Alina Buzachis
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@6dd4a00
    tremble authored and mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    232ae1d View commit details
    Browse the repository at this point in the history
  25. elb_classic_lb_info: Refactor elb_classic_lb_info module (ansible-col…

    …lections#2139)
    
    SUMMARY
    
    Added type hints and function descriptions.
    Updated return block of the module.
    
    ISSUE TYPE
    
    Docs Pull Request
    
    COMPONENT NAME
    
    elb_classic_lb_info
    ADDITIONAL INFORMATION
    
    Reviewed-by: Markus Bergholz <[email protected]>
    Reviewed-by: Alina Buzachis
    Reviewed-by: Mandar Kulkarni <[email protected]>
    Reviewed-by: Mark Chappell
    Reviewed-by: GomathiselviS
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@2ad8a8f
    mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7aaedfc View commit details
    Browse the repository at this point in the history
  26. DNM Migrate elb_classic_lb_info* modules and tests (ansible-collectio…

    …ns#2163)
    
    Depends-On: ansible-collections#2315
    Remove elb_classic_lb_info* modules and tests
    These modules have been migrated to amazon.aws
    Update runtime.yml with redirects to that collection
    Update ignore files
    
    Reviewed-by: Bikouo Aubin
    Reviewed-by: Alina Buzachis
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@7f11acb
    mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    8019326 View commit details
    Browse the repository at this point in the history
  27. Revert "DNM Migrate elb_classic_lb_info* modules and tests (ansible-c…

    …ollections#2163)" (ansible-collections#2170)
    
    This reverts commit 7f11acb.
    Reverts ansible-collections#2163
    ansible-collections#2163 changes are being reverted as it has been agreed to hold off on merging the migration PRs until a plan is set to migrate all planned modules at once. We need to disable the squash strategy in github first to retain commit history.
    SUMMARY
    
    Reviewed-by: GomathiselviS
    
    This commit was initially merged in https://github.com/ansible-collections/community.aws
    See: ansible-collections/community.aws@4cf5a6f
    mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7056b42 View commit details
    Browse the repository at this point in the history
  28. Update runtime

    mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3186629 View commit details
    Browse the repository at this point in the history
  29. Update FQDN

    mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    17a8a29 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    d5f6aa6 View commit details
    Browse the repository at this point in the history
  31. Add changelog fragment

    mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    565357f View commit details
    Browse the repository at this point in the history
  32. update module fqcn in tests

    mandar242 committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    5c21687 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. minor fixes

    mandar242 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    9c54ea3 View commit details
    Browse the repository at this point in the history