s3_bucket - fix typing for Python <3.9 #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 39s |
tremble
requested review from
hakbailey,
abikouo and
alinabuzachis
and removed request for
hakbailey
alinabuzachis
approved these changes
Sep 10, 2024
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 03s |
softwarefactory-project-zuul
bot
merged commit 55460c9
into
ansible-collections:main
38 checks passed
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #2290 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Fixes: #2287 SUMMARY Support for type hinting generics in standard collections was first added in Python 3.9. We're currently not running the sanity tests against Python 3.7 (including the compilation/import tests), so we missed this. (We currently test 3.9-3.12) Using quay.io/ansible/default-test-container:8.12.0 locally to run the tests against 3.7 I see: (2.7 and 3.6 are skipped because this collection doesn't support them) Running sanity test "import" on Python 2.7 Running sanity test "import" on Python 3.6 Running sanity test "import" on Python 3.7 ERROR: Found 1 import issue(s) on python 3.7 which need to be resolved: ERROR: plugins/modules/s3_bucket.py:571:0: traceback: TypeError: 'type' object is not subscriptable See documentation for help: https://docs.ansible.com/ansible-core/2.16/dev_guide/testing/sanity/import.html Running sanity test "import" on Python 3.8 ERROR: Found 1 import issue(s) on python 3.8 which need to be resolved: ERROR: plugins/modules/s3_bucket.py:571:0: traceback: TypeError: 'type' object is not subscriptable See documentation for help: https://docs.ansible.com/ansible-core/2.16/dev_guide/testing/sanity/import.html Running sanity test "import" on Python 3.9 Running sanity test "import" on Python 3.10 Running sanity test "import" on Python 3.11 Running sanity test "import" on Python 3.12 ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_bucket ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis (cherry picked from commit 55460c9)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
This is a backport of PR #2288 as merged into main (55460c9). Fixes: #2287 SUMMARY Support for type hinting generics in standard collections was first added in Python 3.9. We're currently not running the sanity tests against Python 3.7 (including the compilation/import tests), so we missed this. (We currently test 3.9-3.12) Using quay.io/ansible/default-test-container:8.12.0 locally to run the tests against 3.7 I see: (2.7 and 3.6 are skipped because this collection doesn't support them) Running sanity test "import" on Python 2.7 Running sanity test "import" on Python 3.6 Running sanity test "import" on Python 3.7 ERROR: Found 1 import issue(s) on python 3.7 which need to be resolved: ERROR: plugins/modules/s3_bucket.py:571:0: traceback: TypeError: 'type' object is not subscriptable See documentation for help: https://docs.ansible.com/ansible-core/2.16/dev_guide/testing/sanity/import.html Running sanity test "import" on Python 3.8 ERROR: Found 1 import issue(s) on python 3.8 which need to be resolved: ERROR: plugins/modules/s3_bucket.py:571:0: traceback: TypeError: 'type' object is not subscriptable See documentation for help: https://docs.ansible.com/ansible-core/2.16/dev_guide/testing/sanity/import.html Running sanity test "import" on Python 3.9 Running sanity test "import" on Python 3.10 Running sanity test "import" on Python 3.11 Running sanity test "import" on Python 3.12 ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_bucket ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2287
SUMMARY
Support for type hinting generics in standard collections was first added in Python 3.9.
We're currently not running the sanity tests against Python 3.7 (including the compilation/import tests), so we missed this. (We currently test 3.9-3.12)
Using
quay.io/ansible/default-test-container:8.12.0locally to run the tests against 3.7 I see:(2.7 and 3.6 are skipped because this collection doesn't support them)
ISSUE TYPE
COMPONENT NAME
s3_bucket
ADDITIONAL INFORMATION