Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manual backport stable-5] ssm_parameter: update examples to use FQCN (#1685) #1693

Conversation

alinabuzachis
Copy link
Collaborator

ssm_parameter: update examples to use FQCN

SUMMARY

This PR update examples to use FQCN.
Fixes #1581
Should get reflected in module documentation on next doc generation.

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

amazon.aws.ssm_parameter
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
(cherry picked from commit 44eec36)

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

ssm_parameter: update examples to use FQCN

SUMMARY

This PR update examples to use FQCN.
Fixes ansible-collections#1581
Should get reflected in module documentation on next doc generation.

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

amazon.aws.ssm_parameter
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
(cherry picked from commit 44eec36)
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review lookup lookup plugin needs_triage new_plugin New plugin plugins plugin (any type) labels Aug 8, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c6d0869b8461463a9e5813a8c91d7c88

✔️ ansible-galaxy-importer SUCCESS in 3m 41s
✔️ build-ansible-collection SUCCESS in 14m 20s
✔️ ansible-test-splitter SUCCESS in 6m 54s
✔️ integration-amazon.aws-1 SUCCESS in 5m 52s
Skipped 43 jobs

@jillr jillr removed the needs_triage label Aug 8, 2023
@jillr jillr added the mergeit Merge the PR (SoftwareFactory) label Aug 8, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/bf69d92c787c4729ba362eabe6c6be17

✔️ ansible-galaxy-importer SUCCESS in 4m 06s
✔️ build-ansible-collection SUCCESS in 15m 57s
✔️ ansible-test-splitter SUCCESS in 4m 51s
✔️ integration-amazon.aws-1 SUCCESS in 5m 56s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit cf72e21 into ansible-collections:stable-5 Aug 8, 2023
95 of 151 checks passed
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
SNS: content-based deduplication

SUMMARY
Original Author: redradrat
Original PR: ansible-collections#1602
Adds the missing option of "content-based deduplication" for fifo topics.
Also fixes looking up fifo topic ARNs, which resulted in changing always be True.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
sns_topic
ADDITIONAL INFORMATION
ansible-collections#1602 is missing tests and has merge conflicts.
Fixes the conflicts and adds integration tests

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
SNS: content-based deduplication

SUMMARY
Original Author: redradrat
Original PR: ansible-collections#1602
Adds the missing option of "content-based deduplication" for fifo topics.
Also fixes looking up fifo topic ARNs, which resulted in changing always be True.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
sns_topic
ADDITIONAL INFORMATION
ansible-collections#1602 is missing tests and has merge conflicts.
Fixes the conflicts and adds integration tests

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
SNS: content-based deduplication

SUMMARY
Original Author: redradrat
Original PR: ansible-collections#1602
Adds the missing option of "content-based deduplication" for fifo topics.
Also fixes looking up fifo topic ARNs, which resulted in changing always be True.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
sns_topic
ADDITIONAL INFORMATION
ansible-collections#1602 is missing tests and has merge conflicts.
Fixes the conflicts and adds integration tests

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review lookup lookup plugin mergeit Merge the PR (SoftwareFactory) new_plugin New plugin plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants