Added started and stopped states for rds cluster #1647
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
taehopark32
changed the title
taehopark32
changed the title
taehopark32
changed the title
taehopark32
changed the title
| "stop_db_cluster", | ||
| "start_db_cluster", |
There was a problem hiding this comment.
Can you please cover these two with units tests? https://github.com/ansible-collections/amazon.aws/blob/main/tests/unit/module_utils/test_rds.py
plugins/modules/rds_cluster.py
Outdated
| @@ -25,9 +25,10 @@ | |||
| # General module options | |||
| state: | |||
| description: Whether the snapshot should exist or not. | |||
There was a problem hiding this comment.
Can you please update the description? From my understanding, started and stopped can only be sued with aurora clusters, am I wrong? Can you also update the description with something like: "C(started) and C(stopped) can only be used with Aurora DB clusters."
plugins/modules/rds_cluster.py
Outdated
| if module.params["state"] == "started": | ||
| changing_params["DBClusterIdentifier"] = db_cluster_id | ||
|
|
||
| if module.params["state"] == "stopped": | ||
| changing_params["DBClusterIdentifier"] = db_cluster_id | ||
|
|
There was a problem hiding this comment.
If started and stopped can only be used with Aurora DB clusters, you should only allow the user to set this parameters when the engine is aurora or aurora-mysql or aurora-postgresql.
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
taehopark32
force-pushed
the
stop_cluster
branch
from
5ee91d9
to
eab01e8
Compare
|
Build failed.
|
|
recheck |
|
Build failed.
|
ansibullbot
added
community_review
feature
|
recheck |
….0 and can only be used for Aurora rds cluster
Signed-off-by: Alina Buzachis <[email protected]>
Co-authored-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
stop_cluster
branch
from
20994e8
to
e1b34f8
Compare
|
recheck |
|
regate |
softwarefactory-project-zuul
bot
merged commit 51eeebb
into
ansible-collections:main
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #1684 🤖 @patchback |
Added started and stopped states for rds cluster SUMMARY Fixes #1616 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/rds_cluster.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit 51eeebb)
Added started and stopped states for rds cluster SUMMARY Fixes #1616 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/rds_cluster.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit 51eeebb) Co-authored-by: Taeho Park <[email protected]>
…#1647) Added started and stopped states for rds cluster SUMMARY Fixes ansible-collections#1616 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/rds_cluster.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]>
SUMMARY
Fixes #1616
ISSUE TYPE
COMPONENT NAME
plugins/modules/rds_cluster.py
ADDITIONAL INFORMATION