Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New modules: iam_instance_profile(_info) #1614

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 16, 2023

SUMMARY

New modules for listing/managing IAM Instance Profiles

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

iam_instance_profile
iam_instance_profile_info

ADDITIONAL INFORMATION

Fixes: ansible-collections/community.aws#1842

@github-actions
Copy link

github-actions bot commented Jun 16, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/29191d51caa04352a394a6a5e65e9001

✔️ ansible-galaxy-importer SUCCESS in 3m 56s
✔️ build-ansible-collection SUCCESS in 12m 50s
✔️ ansible-test-splitter SUCCESS in 4m 58s
✔️ integration-amazon.aws-1 SUCCESS in 14m 02s
integration-amazon.aws-2 FAILURE in 8m 43s
✔️ integration-amazon.aws-3 SUCCESS in 11m 49s
✔️ integration-community.aws-1 SUCCESS in 25m 58s
✔️ integration-community.aws-2 SUCCESS in 9m 16s
Skipped 39 jobs

@alinabuzachis
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/39ae10d3fe0a483e9ec91e57765cabf8

✔️ ansible-galaxy-importer SUCCESS in 4m 49s
✔️ build-ansible-collection SUCCESS in 12m 29s
✔️ ansible-test-splitter SUCCESS in 5m 13s
✔️ integration-amazon.aws-1 SUCCESS in 13m 36s
✔️ integration-amazon.aws-2 SUCCESS in 8m 48s
✔️ integration-amazon.aws-3 SUCCESS in 11m 11s
✔️ integration-community.aws-1 SUCCESS in 23m 37s
✔️ integration-community.aws-2 SUCCESS in 8m 38s
Skipped 39 jobs

- instance_profile_name
type: str
required: True
prefix:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really a nitpick. Just to be consistent with the corresponding info module, shouldn't you use as main option name path_prefix and add as aliases prefix and path? https://github.com/ansible-collections/amazon.aws/pull/1614/files#diff-c1ae1aba1d1844022e1d231d7e575d9c279ea2922b32696d9c0ccded55d33d8eR24

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I based it on the botocore parameter name, I think we need to pick one for all of the IAM objects and update everything.

description: List of IAM instance profiles
returned: always
type: complex
contains:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it also return tags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"sometimes". The AWS APIs were being inconsistent, so the code handles them but we don't guarantee them :)

@tremble tremble added the backport-6 PR should be backported to the stable-6 branch label Jun 27, 2023
@tremble tremble added this to the 6.2.0 milestone Jun 27, 2023
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 27, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/cc1b302cf77648cfbca76b569f7b43fb

✔️ ansible-galaxy-importer SUCCESS in 4m 06s
✔️ build-ansible-collection SUCCESS in 13m 04s
✔️ ansible-test-splitter SUCCESS in 4m 59s
integration-amazon.aws-1 FAILURE in 8m 00s
✔️ integration-amazon.aws-2 SUCCESS in 7m 48s
integration-amazon.aws-3 FAILURE in 9m 17s
✔️ integration-community.aws-1 SUCCESS in 23m 56s
✔️ integration-community.aws-2 SUCCESS in 8m 26s
✔️ integration-community.aws-3 SUCCESS in 8m 55s
Skipped 38 jobs

@tremble
Copy link
Contributor Author

tremble commented Jun 27, 2023

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/86f8f881d6344afda9a4dc7f221a968f

✔️ ansible-galaxy-importer SUCCESS in 4m 18s
✔️ build-ansible-collection SUCCESS in 13m 43s
✔️ ansible-test-splitter SUCCESS in 5m 22s
integration-amazon.aws-1 FAILURE in 9m 05s
✔️ integration-amazon.aws-2 SUCCESS in 10m 12s
integration-amazon.aws-3 RETRY_LIMIT in 1m 32s
✔️ integration-community.aws-1 SUCCESS in 26m 40s
✔️ integration-community.aws-2 SUCCESS in 6m 45s
✔️ integration-community.aws-3 SUCCESS in 9m 44s
✔️ integration-community.aws-4 SUCCESS in 7m 33s
✔️ integration-community.aws-5 SUCCESS in 5m 43s
✔️ integration-community.aws-6 SUCCESS in 6m 13s
✔️ integration-community.aws-7 SUCCESS in 6m 41s
✔️ integration-community.aws-8 SUCCESS in 6m 50s
Skipped 33 jobs

@tremble
Copy link
Contributor Author

tremble commented Jun 27, 2023

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/03c970fdb1014f41912197bb8abdad5f

✔️ ansible-galaxy-importer SUCCESS in 5m 00s
✔️ build-ansible-collection SUCCESS in 12m 54s
✔️ ansible-test-splitter SUCCESS in 5m 02s
integration-amazon.aws-1 FAILURE in 9m 26s
✔️ integration-amazon.aws-2 SUCCESS in 10m 20s
integration-amazon.aws-3 FAILURE in 11m 06s
✔️ integration-community.aws-1 SUCCESS in 27m 13s
✔️ integration-community.aws-2 SUCCESS in 9m 29s
✔️ integration-community.aws-3 SUCCESS in 9m 15s
✔️ integration-community.aws-4 SUCCESS in 10m 20s
✔️ integration-community.aws-5 SUCCESS in 8m 49s
✔️ integration-community.aws-6 SUCCESS in 9m 11s
✔️ integration-community.aws-7 SUCCESS in 8m 52s
✔️ integration-community.aws-8 SUCCESS in 9m 49s
Skipped 33 jobs

@tremble
Copy link
Contributor Author

tremble commented Jun 27, 2023

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/c6fd6208353c49dca783db74a23013b6

✔️ ansible-galaxy-importer SUCCESS in 4m 59s
✔️ build-ansible-collection SUCCESS in 15m 10s
✔️ ansible-test-splitter SUCCESS in 4m 45s
✔️ integration-amazon.aws-1 SUCCESS in 14m 32s
✔️ integration-amazon.aws-2 SUCCESS in 9m 04s
✔️ integration-amazon.aws-3 SUCCESS in 11m 06s
✔️ integration-community.aws-1 SUCCESS in 27m 44s
✔️ integration-community.aws-2 SUCCESS in 8m 04s
✔️ integration-community.aws-3 SUCCESS in 9m 34s
✔️ integration-community.aws-4 SUCCESS in 8m 55s
✔️ integration-community.aws-5 SUCCESS in 5m 42s
✔️ integration-community.aws-6 SUCCESS in 9m 03s
✔️ integration-community.aws-7 SUCCESS in 9m 24s
✔️ integration-community.aws-8 SUCCESS in 10m 37s
Skipped 33 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6a1f875 into ansible-collections:main Jun 27, 2023
@patchback
Copy link

patchback bot commented Jun 27, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/6a1f875ef2009578a15cfe39df4af65f6c078746/pr-1614

Backported as #1630

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 27, 2023
New modules: iam_instance_profile(_info)

SUMMARY
New modules for listing/managing IAM Instance Profiles
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
iam_instance_profile
iam_instance_profile_info
ADDITIONAL INFORMATION
Fixes: ansible-collections/community.aws#1842

Reviewed-by: Alina Buzachis
Reviewed-by: Mark Chappell
(cherry picked from commit 6a1f875)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 30, 2023
[PR #1614/6a1f875e backport][stable-6] New modules: iam_instance_profile(_info)

This is a backport of PR #1614 as merged into main (6a1f875).
SUMMARY
New modules for listing/managing IAM Instance Profiles
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
iam_instance_profile
iam_instance_profile_info
ADDITIONAL INFORMATION
Fixes: ansible-collections/community.aws#1842

Reviewed-by: Alina Buzachis
@tremble tremble deleted the iam_instance_profile/new branch September 27, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-6 PR should be backported to the stable-6 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iam_instance_profile: missing functionality
2 participants