New modules: iam_instance_profile(_info) #1614
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 56s |
|
recheck |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 49s |
| - instance_profile_name | ||
| type: str | ||
| required: True | ||
| prefix: |
There was a problem hiding this comment.
This is really a nitpick. Just to be consistent with the corresponding info module, shouldn't you use as main option name path_prefix and add as aliases prefix and path? https://github.com/ansible-collections/amazon.aws/pull/1614/files#diff-c1ae1aba1d1844022e1d231d7e575d9c279ea2922b32696d9c0ccded55d33d8eR24
There was a problem hiding this comment.
I based it on the botocore parameter name, I think we need to pick one for all of the IAM objects and update everything.
| description: List of IAM instance profiles | ||
| returned: always | ||
| type: complex | ||
| contains: |
There was a problem hiding this comment.
Does it also return tags?
There was a problem hiding this comment.
"sometimes". The AWS APIs were being inconsistent, so the code handles them but we don't guarantee them :)
|
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/cc1b302cf77648cfbca76b569f7b43fb ✔️ ansible-galaxy-importer SUCCESS in 4m 06s |
|
regate |
See also: ansible-collections#1842 New modules for listing/managing IAM Instance Profiles
tremble
force-pushed
the
iam_instance_profile/new
branch
from
c5fab79
to
858a711
Compare
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 18s |
|
regate |
|
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/03c970fdb1014f41912197bb8abdad5f ✔️ ansible-galaxy-importer SUCCESS in 5m 00s |
|
regate |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 59s |
softwarefactory-project-zuul
bot
merged commit 6a1f875
into
ansible-collections:main
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #1630 🤖 @patchback |
New modules: iam_instance_profile(_info) SUMMARY New modules for listing/managing IAM Instance Profiles ISSUE TYPE New Module Pull Request COMPONENT NAME iam_instance_profile iam_instance_profile_info ADDITIONAL INFORMATION Fixes: ansible-collections/community.aws#1842 Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell (cherry picked from commit 6a1f875)
[PR #1614/6a1f875e backport][stable-6] New modules: iam_instance_profile(_info) This is a backport of PR #1614 as merged into main (6a1f875). SUMMARY New modules for listing/managing IAM Instance Profiles ISSUE TYPE New Module Pull Request COMPONENT NAME iam_instance_profile iam_instance_profile_info ADDITIONAL INFORMATION Fixes: ansible-collections/community.aws#1842 Reviewed-by: Alina Buzachis
SUMMARY
New modules for listing/managing IAM Instance Profiles
ISSUE TYPE
COMPONENT NAME
iam_instance_profile
iam_instance_profile_info
ADDITIONAL INFORMATION
Fixes: ansible-collections/community.aws#1842