s3_object - allow recursive copy of all objects in S3 bucket #1608
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 05s |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 48s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 07s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 36s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 5m 26s |
…ions against existing stacksets complete (ansible-collections#1790) cloudformation_stack_set - Add a waiter to ensure that running operations against existing stacksets complete SUMMARY Add a waiter to ensure that running operations against existing stacksets complete. Current code would fail in cases where new instances need to be added since the previous update_stack_set(module, stack_params, cfn) would still be running. Fixes ansible-collections#1608 ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudformation_stack_set ADDITIONAL INFORMATION I initially thought that the module was not idempotent since new instances wouldn't be added to my existing stack sets. Upon closer examination, the issue had to do with the fact that we had prior calls being made before adding new instances to existing stack sets: raise error_class(parsed_response, operation_name)\nbotocore.errorfactory.OperationInProgressException: An error occurred (OperationInProgressException) when calling the UpdateStackInstances operation: Another Operation on StackSet arn:aws:cloudformation:us-east-1:XXXXXX:stackset/aws-config-stackset:2bcb419a-f263-48ca-9fe0-cdef11fb59de is in progress The error got triggered because of a missing waiter after this operation: changed |= update_stack_set(module, stack_params, cfn) This change add a waiter function after the update operation, which, in turn, ensure that the subsequent call to add stack instances to the stack set properly run. Reviewed-by: Mark Chappell
…ions against existing stacksets complete (ansible-collections#1790) cloudformation_stack_set - Add a waiter to ensure that running operations against existing stacksets complete SUMMARY Add a waiter to ensure that running operations against existing stacksets complete. Current code would fail in cases where new instances need to be added since the previous update_stack_set(module, stack_params, cfn) would still be running. Fixes ansible-collections#1608 ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudformation_stack_set ADDITIONAL INFORMATION I initially thought that the module was not idempotent since new instances wouldn't be added to my existing stack sets. Upon closer examination, the issue had to do with the fact that we had prior calls being made before adding new instances to existing stack sets: raise error_class(parsed_response, operation_name)\nbotocore.errorfactory.OperationInProgressException: An error occurred (OperationInProgressException) when calling the UpdateStackInstances operation: Another Operation on StackSet arn:aws:cloudformation:us-east-1:XXXXXX:stackset/aws-config-stackset:2bcb419a-f263-48ca-9fe0-cdef11fb59de is in progress The error got triggered because of a missing waiter after this operation: changed |= update_stack_set(module, stack_params, cfn) This change add a waiter function after the update operation, which, in turn, ensure that the subsequent call to add stack instances to the stack set properly run. Reviewed-by: Mark Chappell
…ions against existing stacksets complete (ansible-collections#1790) cloudformation_stack_set - Add a waiter to ensure that running operations against existing stacksets complete SUMMARY Add a waiter to ensure that running operations against existing stacksets complete. Current code would fail in cases where new instances need to be added since the previous update_stack_set(module, stack_params, cfn) would still be running. Fixes ansible-collections#1608 ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudformation_stack_set ADDITIONAL INFORMATION I initially thought that the module was not idempotent since new instances wouldn't be added to my existing stack sets. Upon closer examination, the issue had to do with the fact that we had prior calls being made before adding new instances to existing stack sets: raise error_class(parsed_response, operation_name)\nbotocore.errorfactory.OperationInProgressException: An error occurred (OperationInProgressException) when calling the UpdateStackInstances operation: Another Operation on StackSet arn:aws:cloudformation:us-east-1:XXXXXX:stackset/aws-config-stackset:2bcb419a-f263-48ca-9fe0-cdef11fb59de is in progress The error got triggered because of a missing waiter after this operation: changed |= update_stack_set(module, stack_params, cfn) This change add a waiter function after the update operation, which, in turn, ensure that the subsequent call to add stack instances to the stack set properly run. Reviewed-by: Mark Chappell
SUMMARY
Add support to copy recursively all objects from one bucket to another one, user can set
prefixto limit the object to copy.closes #1379
ISSUE TYPE
COMPONENT NAME
s3_object