Resolve ambiguous description on Rule0031 (StefanMaron#787)

* Resolve ambiguous description * Update documentation
ans-bar-bm · Oct 13, 2024 · b63487c · b63487c
1 parent 0d54f5a
commit b63487c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/BusinessCentral.LinterCop/LinterCop.ruleset.json b/BusinessCentral.LinterCop/LinterCop.ruleset.json
@@ -155,7 +155,7 @@
     {
       "id": "LC0031",
       "action": "Info",
-      "justification": "Set ReadIsolation property instead of LockTable method."
+      "justification": "Use ReadIsolation instead of LockTable."
     },
     {
       "id": "LC0032",

diff --git a/BusinessCentral.LinterCop/LinterCopAnalyzers.resx b/BusinessCentral.LinterCop/LinterCopAnalyzers.resx
@@ -382,13 +382,13 @@
     <value>Set Access property to Internal for Install/Upgrade codeunits.</value>
   </data>
   <data name="Rule0031RecordInstanceIsolationLevelTitle" xml:space="preserve">
-    <value>Set ReadIsolation property instead of LockTable method.</value>
+    <value>Use ReadIsolation instead of LockTable.</value>
   </data>
   <data name="Rule0031RecordInstanceIsolationLevelFormat" xml:space="preserve">
-    <value>Set ReadIsolation property instead of LockTable method.</value>
+    <value>Use ReadIsolation(IsolationLevel::UpdLock) instead of LockTable().</value>
   </data>
   <data name="Rule0031RecordInstanceIsolationLevelDescription" xml:space="preserve">
-    <value>Set ReadIsolation property instead of LockTable method.</value>
+    <value>Use the ReadIsolation method to control isolation level on database transactions instead of the LockTable method.</value>
   </data>
   <data name="Rule0032ClearCodeunitSingleInstanceTitle" xml:space="preserve">
     <value>Clear(All) does not affect or change values for global variables in '{0}: Codeunit {1}'.</value>

diff --git a/README.md b/README.md
@@ -184,7 +184,7 @@ For an example and the default values see: [LinterCop.ruleset.json](LinterCop.ru
 |[LC0028](https://github.com/StefanMaron/BusinessCentral.LinterCop/wiki/LC0028)|Event subscriber arguments now use identifier syntax instead of string literals.|Info|
 |[LC0029](https://github.com/StefanMaron/BusinessCentral.LinterCop/wiki/LC0029)|Use `CompareDateTime` method in `Type Helper` codeunit for DateTime variable comparisons.|Info|
 |[LC0030](https://github.com/StefanMaron/BusinessCentral.LinterCop/wiki/LC0030)|Set Access property to Internal for Install/Upgrade codeunits.|Info|
-|[LC0031](https://github.com/StefanMaron/BusinessCentral.LinterCop/wiki/LC0031)|Set ReadIsolation property instead of LockTable method.|Info|
+|[LC0031](https://github.com/StefanMaron/BusinessCentral.LinterCop/wiki/LC0031)|Use ReadIsolation instead of LockTable.|Info|
 |[LC0032](https://github.com/StefanMaron/BusinessCentral.LinterCop/wiki/LC0032)|Clear(All) does not affect or change values for global variables in single instance codeunits.|Warning|
 |[LC0033](https://github.com/StefanMaron/BusinessCentral.LinterCop/wiki/LC0033)|The specified runtime version in app.json is falling behind.|Info|
 |[LC0034](https://github.com/StefanMaron/BusinessCentral.LinterCop/wiki/LC0034)|The property `Extensible` should be explicitly set for public objects.|Disabled|