Merge pull request StefanMaron#749 from StefanMaron/NullReferenceExce…

…ptionOnRule0035 Set Nullable reference types to handle NullReferenceExceptions on Rule0035
ans-bar-bm · Aug 29, 2024 · a322e39 · a322e39
2 parents 7d5736a + eddfdb5
commit a322e39
Showing 1 changed file with 24 additions and 11 deletions.
diff --git a/BusinessCentral.LinterCop/Design/Rule0035ExplicitSetAllowInCustomizations.cs b/BusinessCentral.LinterCop/Design/Rule0035ExplicitSetAllowInCustomizations.cs
@@ -1,4 +1,5 @@
 #if Fall2023RV1
+#nullable enable
 using BusinessCentral.LinterCop.AnalysisContextExtension;
 using Microsoft.Dynamics.Nav.CodeAnalysis;
 using Microsoft.Dynamics.Nav.CodeAnalysis.Diagnostics;
@@ -34,7 +35,7 @@ private void AnalyzeAllowInCustomization(SymbolAnalysisContext ctx)
                                                                 .ToList();
             if (!tableFields.Any()) return;
 
-            IEnumerable<IApplicationObjectTypeSymbol> relatedPages = GetRelatedPages(ctx);
+            IEnumerable<IApplicationObjectTypeSymbol>? relatedPages = GetRelatedPages(ctx);
 
             if (!relatedPages.Any())
             {
@@ -50,7 +51,7 @@ private void AnalyzeAllowInCustomization(SymbolAnalysisContext ctx)
             ICollection<IFieldSymbol> pageFields = GetPageFields(relatedPages);
             ICollection<IFieldSymbol> fieldsNotReferencedOnPage = tableFields.Except(pageFields).ToList();
             foreach (IFieldSymbol field in fieldsNotReferencedOnPage)
-                ctx.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.Rule0035ExplicitSetAllowInCustomizations, field.Location));
+                ctx.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.Rule0035ExplicitSetAllowInCustomizations, field.Location!));
         }
 
         private static ICollection<IFieldSymbol> GetTableFields(ISymbol symbol)
@@ -66,21 +67,24 @@ private static ICollection<IFieldSymbol> GetTableFields(ISymbol symbol)
             }
         }
 
-        private static ICollection<IFieldSymbol> GetPageFields(IEnumerable<IApplicationObjectTypeSymbol> relatedPages)
+        private static ICollection<IFieldSymbol> GetPageFields(IEnumerable<IApplicationObjectTypeSymbol>? relatedPages)
         {
+            if (relatedPages == null)
+                return [];
+
             ICollection<IFieldSymbol> pageFields = new Collection<IFieldSymbol>();
             foreach (IApplicationObjectTypeSymbol relatedPageLike in relatedPages)
             {
                 switch (relatedPageLike.GetNavTypeKindSafe())
                 {
                     case NavTypeKind.Page:
                         IEnumerable<IFieldSymbol> fields = ((IPageTypeSymbol)relatedPageLike).FlattenedControls.Where(x => x.ControlKind == ControlKind.Field && x.RelatedFieldSymbol != null)
-                                                            .Select(x => (IFieldSymbol)x.RelatedFieldSymbol.OriginalDefinition);
+                                                            .Select(x => (IFieldSymbol)x.RelatedFieldSymbol!.OriginalDefinition);
                         pageFields = pageFields.Union(fields).Distinct().ToList();
                         break;
                     case NavTypeKind.PageExtension:
                         IEnumerable<IFieldSymbol> extFields = ((IPageExtensionTypeSymbol)relatedPageLike).AddedControlsFlattened.Where(x => x.ControlKind == ControlKind.Field && x.RelatedFieldSymbol != null)
-                                                            .Select(x => (IFieldSymbol)x.RelatedFieldSymbol.OriginalDefinition);
+                                                            .Select(x => (IFieldSymbol)x.RelatedFieldSymbol!.OriginalDefinition);
 
                         pageFields = pageFields.Union(extFields).Distinct().ToList();
                         break;
@@ -89,29 +93,35 @@ private static ICollection<IFieldSymbol> GetPageFields(IEnumerable<IApplicationO
             return pageFields;
         }
 
-        private static IEnumerable<IApplicationObjectTypeSymbol> GetRelatedPages(SymbolAnalysisContext ctx)
+        private static IEnumerable<IApplicationObjectTypeSymbol>? GetRelatedPages(SymbolAnalysisContext ctx)
         {
             // table and tableextension fields can each be referenced on both pages and pageextensions
-            ITableTypeSymbol table = null;
+            ITableTypeSymbol? table = null;
             switch (ctx.Symbol.GetContainingObjectTypeSymbol().GetNavTypeKindSafe())
             {
                 case NavTypeKind.Record:
-                    table = (ITableTypeSymbol)ctx.Symbol;
+                    table = ctx.Symbol as ITableTypeSymbol;
                     break;
                 case NavTypeKind.TableExtension:
-                    table = (ITableTypeSymbol)((IApplicationObjectExtensionTypeSymbol)ctx.Symbol).Target;
+                    if (ctx.Symbol is IApplicationObjectExtensionTypeSymbol typeSymbol)
+                        table = typeSymbol.Target as ITableTypeSymbol;
                     break;
                 default:
                     return null;
             }
+
+            if (table is null)
+                return [];
+
             IEnumerable<IApplicationObjectTypeSymbol> pages = ctx.Compilation.GetDeclaredApplicationObjectSymbols()
                                             .Where(x => x.GetNavTypeKindSafe() == NavTypeKind.Page)
                                             .Where(x => ((IPageTypeSymbol)x.GetTypeSymbol()).PageType != PageTypeKind.API)
                                             .Where(x => ((IPageTypeSymbol)x.GetTypeSymbol()).RelatedTable == table);
 
             IEnumerable<IApplicationObjectTypeSymbol> pageExtensions = ctx.Compilation.GetDeclaredApplicationObjectSymbols()
                                             .Where(x => x.GetNavTypeKindSafe() == NavTypeKind.PageExtension)
-                                            .Where(x => ((IPageTypeSymbol)((IApplicationObjectExtensionTypeSymbol)x).Target.GetTypeSymbol()).RelatedTable == table);
+                                            .Where(x => ((IApplicationObjectExtensionTypeSymbol)x).Target != null)
+                                            .Where(x => ((IPageTypeSymbol)((IApplicationObjectExtensionTypeSymbol)x).Target!.GetTypeSymbol()).RelatedTable == table);
 
             return pages.Union(pageExtensions);
         }
@@ -132,8 +142,11 @@ private static bool IsSupportedType(NavTypeKind navTypeKind)
             }
         }
 
-        private static bool LookupOrDrillDownPageIsSet(ITableTypeSymbol table)
+        private static bool LookupOrDrillDownPageIsSet(ITableTypeSymbol? table)
         {
+            if (table is null)
+                return false;
+
             return table.Properties.Any(e => e.PropertyKind == PropertyKind.DrillDownPageId || e.PropertyKind == PropertyKind.LookupPageId);
         }
     }