fix: do not use empty string memos by default - in transfers (#1386)

anoma · Dec 5, 2024 · e7fa909 · e7fa909 · github-actions · Dec 5, 2024
1 parent 4ac59a8
commit e7fa909
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/apps/namadillo/src/App/Transfer/TransferModule.tsx b/apps/namadillo/src/App/Transfer/TransferModule.tsx
@@ -108,7 +108,7 @@ export const TransferModule = ({
     destination.enableCustomAddress && !destination.availableWallets
   );
 
-  const [memo, setMemo] = useState<undefined | string>("");
+  const [memo, setMemo] = useState<undefined | string>();
 
   const selectedAsset = mapUndefined(
     (address) => source.availableAssets?.[address],

diff --git a/apps/namadillo/src/atoms/transfer/atoms.ts b/apps/namadillo/src/atoms/transfer/atoms.ts
@@ -44,7 +44,7 @@ export const createShieldedTransferAtom = atomWithMutation((get) => {
       params,
       gasConfig,
       account,
-      memo = "",
+      memo,
     }: BuildTxAtomParams<ShieldedTransferMsgValue>) =>
       createShieldedTransferTx(chain.data!, account, params, gasConfig, memo),
   };
@@ -59,7 +59,7 @@ export const createShieldingTransferAtom = atomWithMutation((get) => {
       params,
       gasConfig,
       account,
-      memo = "",
+      memo,
     }: BuildTxAtomParams<ShieldingTransferMsgValue>) =>
       createShieldingTransferTx(chain.data!, account, params, gasConfig, memo),
   };
@@ -74,7 +74,7 @@ export const createUnshieldingTransferAtom = atomWithMutation((get) => {
       params,
       gasConfig,
       account,
-      memo = "",
+      memo,
     }: BuildTxAtomParams<UnshieldingTransferMsgValue>) =>
       createUnshieldingTransferTx(
         chain.data!,

diff --git a/apps/namadillo/src/atoms/transfer/services.ts b/apps/namadillo/src/atoms/transfer/services.ts
@@ -18,7 +18,7 @@ export const createTransparentTransferTx = async (
   account: Account,
   props: TransparentTransferMsgValue[],
   gasConfig: GasConfig,
-  memo = ""
+  memo?: string
 ): Promise<TransactionPair<TransparentTransferProps> | undefined> => {
   const { tx } = await getSdkInstance();
   const transactionPairs = await buildTxPair(
@@ -38,7 +38,7 @@ export const createShieldedTransferTx = async (
   account: Account,
   props: ShieldedTransferMsgValue[],
   gasConfig: GasConfig,
-  memo = ""
+  memo?: string
 ): Promise<TransactionPair<ShieldedTransferProps> | undefined> => {
   const { tx } = await getSdkInstance();
   const transactionPairs = await buildTxPair(
@@ -58,7 +58,7 @@ export const createShieldingTransferTx = async (
   account: Account,
   props: ShieldingTransferMsgValue[],
   gasConfig: GasConfig,
-  memo = ""
+  memo?: string
 ): Promise<TransactionPair<ShieldingTransferProps> | undefined> => {
   const { tx } = await getSdkInstance();
   const transactionPairs = await buildTxPair(
@@ -78,7 +78,7 @@ export const createUnshieldingTransferTx = async (
   account: Account,
   props: UnshieldingTransferMsgValue[],
   gasConfig: GasConfig,
-  memo = ""
+  memo?: string
 ): Promise<TransactionPair<UnshieldingTransferProps> | undefined> => {
   const { tx } = await getSdkInstance();
   const transactionPairs = await buildTxPair(

diff --git a/apps/namadillo/src/lib/transactions.ts b/apps/namadillo/src/lib/transactions.ts
@@ -167,7 +167,7 @@ export const createTransferDataFromNamada = (
     | TransactionPair<ShieldedTransferMsgValue>
     | TransactionPair<ShieldingTransferMsgValue>
     | TransactionPair<UnshieldingTransferMsgValue>,
-  memo = ""
+  memo?: string
 ): TransferTransactionData[] => {
   if (!txResponse?.encodedTxData?.txs?.length) {
     throw "Invalid transaction response";