feat(firefox): separating build in different stages and updating docs

anoma · Dec 17, 2024 · 00b0778 · 00b0778
1 parent 7439ddc
commit 00b0778
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/apps/extension/FIREFOX_README.md b/apps/extension/FIREFOX_README.md
@@ -22,13 +22,13 @@ docker --version
 2. From the **repository root**, build the Docker image:
 
 ```bash
-docker build . -t namada-keychain -f docker/extension/Dockerfile
+docker build . --target firefox -t namada-keychain-firefox -f docker/extension/Dockerfile
 ```
 
 3. Wait for the build to complete, and then copy the files from the container by executing the following command in the **repository root**:
 
 ```bash
-docker run --rm -v ./apps/extension/build:/shared namada-keychain cp -r /app/apps/extension/build/. /shared/
+docker run --rm -v ./apps/extension/build:/shared namada-keychain-firefox cp -r /app/apps/extension/build/. /shared/
 ```
 
 4. The resulting extension is the ZIP file in `apps/extension/build/firefox`.

diff --git a/docker/extension/Dockerfile b/docker/extension/Dockerfile
@@ -26,5 +26,11 @@ RUN yarn wasm:build
 # Building extension dist files
 COPY ./apps/extension .
 RUN yarn
-RUN yarn build
+
+FROM builder AS firefox
+RUN yarn build:firefox
+
+FROM builder AS chrome
+RUN yarn build:chrome
+