-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 1.0.0-maint
into main
#226
base: main
Are you sure you want to change the base?
Conversation
backport: fetch validators out of consensus set
webserver: return semver version
…s-in-batch fix: insert rewards in batch
rewards: fetch rewards in batches
feat: add block proposer to addresses_with_balance_change
enhancement: store blocks while crawling transactions and chain
Ibc events
feat: return blocks by timestamp or height
…-toml-to-1.1.4 chore: update version in cargo toml
let all_balance_changed_addresses = addresses | ||
.iter() | ||
.chain(block_proposer_address.iter()) | ||
.chain(pgf_receipient_addresses.iter()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was probably the trickiest part of the merge -- given the changes on both sides to this, I had to make sure pgf_recipient_addresses
was still accounted for (which it is, as you can see).
@joel-u410 will this one make it into this 1.0.0 release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! I think this is fine. Let's wait for Gian to take a look though just in case! :)
@ValidityOps-CLU The PR that you are pointing to can be merged to main when finished. For now we only tag new versions based on |
Awesome thank you @mateuszjasiuk |
@joel-u410 thanks for the PR! can you take all the latest changes too ? |
This branch merges and resolves conflicts for
1.0.0-maint
intomain
.@Fraccaman @mateuszjasiuk -- I went ahead and opened this because I am running my fork based on
main
but wanted my recent1.0.0-maint
PRs incorporated too 🙂