Fix Async deprecation warnings #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of course v0.17.0 requires OCaml 5.1 https://github.com/janestreet/async_kernel/blob/v0.17.0/async_kernel.opam#L13-L18 so CI should skip supporting any OCaml version that Async doesn't support. |
tmcgilchrist
force-pushed
the
async_fix
branch
from
b6aac0c
to
d4ad63e
Compare
|
I'm hesitant to make this change since it makes how about we just disable warning 3 locally? |
tmcgilchrist
force-pushed
the
async_fix
branch
from
6d3b8b1
to
0280e82
Compare
tmcgilchrist
force-pushed
the
async_fix
branch
from
0280e82
to
11ec1f6
Compare
|
Ignoring the warnings is a better idea, I've update the PR. |
|
Thank you! |
|
ooops I pressed merge too quickly. I disabled the deprecations locally in bdb7dc4 that's a bit more explicit, which I prefer |
anmonteiro
added a commit
to anmonteiro/opam-repository
that referenced
this pull request
Sep 4, 2024
CHANGES: - gluten-async: Silence async deprecation warnings ([anmonteiro/gluten#78)(anmonteiro/gluten#78)) - migrate to tls 1.0.0 without cstruct ([anmonteiro/gluten#80](anmonteiro/gluten#80))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API for fill was changed in v0.17.0. The implementation for
fillcallsfill_exnin v0.17.0 so there is no difference in implementation now https://github.com/janestreet/async_kernel/blob/v0.17.0/src/ivar0.ml#L303-L317 plus the older doc strings for v0.16 is the same as the new one onfill_exn. It isn't clear whether there is just a bug fix or some behaviour change as there is no entry in CHANGES.md.