Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated README.md, Fixed & Optimized fb.py #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dibyasonu
Copy link

  • added phantomjs as dependencies in Readme.md
  • print statement in line14 had creating problems in some system where Unicode character is detected
    as the title actually contains some Unicode characters and not just "facebook"
  • sleep is not required

please tell me if any changes is necessary so that i can rectify it so that i can make the pull request successful.

dibyasonu and others added 5 commits October 22, 2017 06:51
Scraping actual Facebook site is a little problematic as getting its relative xpath is difficult. So we are using (https://mbasic.facebook.com/) which has simple HTML format and loads up quickly. Only thing is that after login the URL changes, so redirecting it again to previous URL is required or else it throws element not found error. 
It's now complete
Error fixes for unicode, updated README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants