Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inappropriate margin on mobile #9

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

ittipatken
Copy link

an

Left: before & Right: after

@dae
Copy link
Member

dae commented Jan 30, 2025

Sorry for the holdup on these tickets. Your contributions are appreciated!

I noticed we're using Tailwind here - do you have much experience with it? I'm not very happy with the CSS in the desktop repo - we include a lot of bootstrap css that we don't use, have a somewhat nebulous distinction between styles we inline in the page and styles we include as part of a separate base scss file, etc. There's plenty of room for improvement if this is something that interests you :-)

@dae dae merged commit af5ae4c into ankitects:main Jan 30, 2025
1 check passed
@ittipatken
Copy link
Author

Thank you for the offer. I never handle such a large project before. I am a bit concerned about being the main contributor to such a massive project. Though, I would be happy to contribute to some parts of the migration process, if someone else takes the lead, as my time is quite limited.

@dae
Copy link
Member

dae commented Jan 30, 2025

No worries - but if you see something that you think could be improved, contributions would of course be welcome :-)

I'll create a ticket in the main repo when I have a chance to document the css issues.

@ittipatken ittipatken deleted the mobile-margin branch January 31, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants