Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the brand icons #15255

Merged
merged 2 commits into from
Jan 21, 2024
Merged

Remove the brand icons #15255

merged 2 commits into from
Jan 21, 2024

Conversation

criticalAY
Copy link
Contributor

@criticalAY criticalAY commented Jan 17, 2024

Purpose / Description

Removing the brand icons due to not being free and replacing them with simple link icon

How Has This Been Tested?

Google emulator
image

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison added Needs Author Reply Waiting for a reply from the original author Needs Review labels Jan 17, 2024
@criticalAY
Copy link
Contributor Author

I have made some changes, now it has nothing to do with the previous icon file

@david-allison
Copy link
Member

david-allison commented Jan 19, 2024

The icons were added in

These were using a "GPL Friendly" license from Pictogrammers

It turns out that the license wasn't GPL-Friendly, specifically regarding brand icons: Templarian/MaterialDesign#5777

and brand icons were removed in V6: Templarian/MaterialDesign#6602

The logical conclusion to me would be to remove the brand icons if they're nonfree


Pending a further discussion on Discord

@david-allison david-allison added Blocked by dependency Currently blocked by some other dependent / related change and removed Needs Author Reply Waiting for a reply from the original author Needs Review labels Jan 19, 2024
@lukstbit
Copy link
Member

The logical conclusion to me would be to remove the brand icons if they're nonfree

I think this is the way to go, icons would be nice but definitely not worth the hassle.

@lukstbit lukstbit mentioned this pull request Jan 20, 2024
5 tasks
@mikehardy
Copy link
Member

Agreed

Remove the brand icons

@mikehardy mikehardy added the Needs Author Reply Waiting for a reply from the original author label Jan 20, 2024
@david-allison
Copy link
Member

@lukstbit would you like to include removal in #15190, or have someone split it out into a separate PR?

@criticalAY criticalAY changed the title Update the Twitter logo Remove the brand icons Jan 20, 2024
@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author Blocked by dependency Currently blocked by some other dependent / related change labels Jan 21, 2024
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however I think it could be better by:

  • swapping the Reddit and Mailing List so all social networks links are together
  • using the link icon for Reddit as well like it was used for the other social networks

@lukstbit lukstbit added the Needs Author Reply Waiting for a reply from the original author label Jan 21, 2024
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

@lukstbit lukstbit removed Needs Author Reply Waiting for a reply from the original author Needs Second Approval Has one approval, one more approval to merge labels Jan 21, 2024
@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) squash-merge The pull request currently requires maintainers to "Squash Merge" labels Jan 21, 2024
@david-allison david-allison merged commit e8f3ed1 into ankidroid:main Jan 21, 2024
7 checks passed
@github-actions github-actions bot added this to the 2.17 release milestone Jan 21, 2024
@github-actions github-actions bot removed Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) squash-merge The pull request currently requires maintainers to "Squash Merge" labels Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove brand icons from Help Menu
4 participants