The custom german spyware that is also a theme #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secozzi
reviewed
Jul 23, 2024
| @@ -84,6 +100,7 @@ object SettingsAppearanceScreen : SearchableSettings { | |||
| ) | |||
| } | |||
| }, | |||
| *customPreferenceItem.toTypedArray(), | |||
There was a problem hiding this comment.
Wouldn't it be better to use PreferenceGroup instead of trying to change a persistent list?
There was a problem hiding this comment.
I didn't want to make another PreferenceGroup just for the custom theme. Or can you merge two PreferenceGroups together?
There was a problem hiding this comment.
Maybe not, but perhaps
Suggested change
| *customPreferenceItem.toTypedArray(), | |
| Preference.PreferenceItem.TextPreference( | |
| title = stringResource(MR.strings.pref_custom_color), | |
| enabled = appTheme == AppTheme.CUSTOM, | |
| subtitle = stringResource(MR.strings.custom_color_description), | |
| onClick = { navigator.push(AppCustomThemeColorPickerScreen()) }, | |
| ), |
would be better
There was a problem hiding this comment.
Hmm, seems like a good idea. Would've used mutableListOf as another solution. Will try it when I get back home. thx seco
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.