feat(app): androidtv support #1592
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hollowshiroyuki
force-pushed
the
feat/androidtv
branch
from
e692e2b
to
edcefd2
Compare
jmir1
reviewed
Jun 2, 2024
Comment on lines
71
to
74
| modifier = Modifier | ||
| .horizontalScroll(rememberScrollState()) | ||
| .padding(horizontal = MaterialTheme.padding.small), | ||
| .padding(horizontal = MaterialTheme.padding.small) | ||
| .then(modifier), |
There was a problem hiding this comment.
You should apply the parent modifier first, so instead of
Modifier
....
.then(modifier)
do
modifier
....
maybe should do like AnimeExtensionDetailsScreen.kt:335 instead?
hollowshiroyuki
force-pushed
the
feat/androidtv
branch
from
edcefd2
to
a2515b6
Compare
|
Good luck making this work for Android TV!. Hope it gets accepted into official apk |
|
Did you quit this project? |
|
nuh uh, i'm just bad and it takes a while, i'll need to revert some stuff because it's not the right way to proceed and breaks stuff, and i found better ways to proceed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hehe :3c
still a wip, taking any advice/recommendation
closes #162