-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(onboarding): add privacy policy to onboarding. #1288
Open
Dark25
wants to merge
19
commits into
aniyomiorg:master
Choose a base branch
from
Dark25:privacy-policy-to-onboarding
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need to update the privacy policy first. The one on the website is outdated, we don't use firebase or crashlytics anymore. |
I have already eliminated firebase and crashlytics in the policies, I will wait for the policy modifications in case I need to make any changes :D |
…to privacy-policy-to-onboarding
Secozzi
pushed a commit
that referenced
this pull request
Oct 31, 2024
….03 (#1288) (cherry picked from commit f7fbc93833c6107791680412cc110336d0e4e717)
Dark25
added a commit
to Dark25/Animetail2
that referenced
this pull request
Nov 6, 2024
* fix(deps): update dependency io.coil-kt.coil3:coil-bom to v3.0.0-alpha09 (#1039) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit ca784cbe3267e94e652e4c54f91b7107cc53c307) * Remove obsolete workaround Co-authored-by: FooIbar <[email protected]> * chore(deps): update softprops/action-gh-release action to v2.0.8 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency androidx.activity:activity-compose to v1.9.1 (#1042) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit e48dbdbf2356c0e6e148313dc6610e865cd8e995) * fix(deps): update dependency androidx.annotation:annotation to v1.8.1 (#1043) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 602b58f364b95b83a3148be34cd4c90d95d7d405) * fix(deps): update lifecycle.version to v2.8.4 (#1045) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit b7849d714698900a25188bdbfd77bf24936f2dd7) * Format Category String on Subtitle Display * Fixes #1029 * Max Line Length Fix * Update SettingsLibraryScreen.kt No idea how this works. Co-authored-by: Foolbar <[email protected]> --------- Co-authored-by: Foolbar <[email protected]> Co-authored-by: Roshan Varughese <[email protected]> * fix(deps): update paging.version to v3.3.1 (#1046) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 41e2dc7ae80250d9166fc637c1170667afdb0a9e) * fix(deps): update dependency dev.chrisbanes.compose:compose-bom to v2024.07.00-alpha02 (#1051) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 04aa5b36a5893ef9991312d61f84f830b83535f7) * Fix disappearance items when fast scrolling * Don't use animateItem's fade-in/fade-out in FastScrollLazyColumn * Move to extension function Avoid using animateItemPlacement name since it's shadowed by compose-bom's deprecated one Co-authored-by: Cuong-Tran <[email protected]> * Adds Option to Copy Panel to Clipboard * Add Copy to Clipboard * Removing Unused Import * Reusing onShare function * Commit Suggestion * Early Return on null Co-authored-by: AntsyLich <[email protected]> --------- Co-authored-by: AntsyLich <[email protected]> Co-authored-by: Roshan Varughese <[email protected]> * Fix library is backed up when disabled and make categories backup/restore independent Co-authored-by: AntsyLich <[email protected]> * Cleanup backup/restore related code Co-authored-by: AntsyLich <[email protected]> * Bump default user agent string (cherry picked from commit 8160b47ff5fbbd9b32caeb462b5be881fabd3449) * Improve error message if restoring from JSON file * Improve error message if restoring from JSON file * Replace Exception with IOException * Use more generic error message if protobuf fails * fix lint Co-authored-by: Vetle Ledaal <[email protected]> * Match extra layout space with scroll distance (#1076) And increase recycler item view cache size. (cherry picked from commit a3dfd2efe6ace7a2a4d79bd09fb1a729989f1094) * chore(deps): update actions/setup-java action to v4.2.2 (#1080) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 3f6bd5f010532d292310c0c0f14bf11832277f2e) * fix: drawScrollbar crash on list with 0 item but only sticky header Co-authored-by: Cuong-Tran <[email protected]> * Don't crash on ill-formed URLs (#1084) (cherry picked from commit 854474f85ffc41eccdc2b3a6cf105fa2805ebc3c) * chore(deps): update kotlin monorepo to v2.0.10 (#1085) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit edb8201f74e516c296b62e04a13802e1bd9e0b6b) * Rename backup restore error log file Co-authored-by: AntsyLich <[email protected]> * Add Backup and Restore of Extension Repos (#1057) * Backup/Restore Extension Repos * Refactor * Moving to Under App Settings * Sort by URL, Check existing by SHA and Error Logging Untested. Currently in a lecture and can't test if the changes really work. * Changes to logic * Don't ask me what's happening here * Renaming Variables * Fixing restoreAmount & changes to logic Co-Authored-By: AntsyLich <[email protected]> --------- Co-authored-by: AntsyLich <[email protected]> Co-authored-by: Roshan Varughese <[email protected]> * ExpandableMangaDescription: Adjust size transform anim spec Co-authored-by: ivan <[email protected]> Co-authored-by: AntsyLich <[email protected]> * fix(deps): update paging.version to v3.3.2 (#1093) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 8e40146f96704c3dc98bbb4f9f89d470ffa32f69) * chore(deps): update gradle/actions action to v4 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency androidx.annotation:annotation to v1.8.2 (#1090) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 36b9caeea8baf15f0d0ed37abc12638d44194c09) * fix(deps): update dependency androidx.work:work-runtime to v2.9.1 (#1091) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit af77083660000e7378587dbc8d44e44bd8b196ec) * fix(deps): update dependency io.coil-kt.coil3:coil-bom to v3.0.0-alpha10 (#1092) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit e8b7c3e24bb677d289554b972ef2496a976c79aa) * fix(deps): update dependency dev.chrisbanes.compose:compose-bom to v2024.08.00-alpha01 (#1094) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit dca9bf105770890e015b8e2f9fbf22f05665e343) * fix(deps): update dependency com.android.tools.build:gradle to v8.5.2 (#1099) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 4828c54245dd6532c0e7a2b6c8cf5d8a703d3376) * Contributing: ktLintFormat -> detekt (#1102) * Contributing: ktLintFormat -> detekt update Contributing info to use detekt instead of ktLintFormat * Update CONTRIBUTING.md --------- Co-authored-by: AntsyLich <[email protected]> (cherry picked from commit 14ae57d78b31f0bb3b58d19c1d8cfcebcc8e2253) * Change Kitsu to kitsu.app domain cf. hummingbird-me/kitsu-server@244fdcc Co-authored-by: MajorTanya <[email protected]> * Fix MAL search results not showing start dates The previous approach would always throw an Exception because `SimpleDateFormat.format()` expects the input to be of type `Date` or `Number`, not `String`. Co-authored-by: MajorTanya <[email protected]> * Translations update from Hosted Weblate (#939) Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/ar/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/ca/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/cs/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/de/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/es/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/fil/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/id/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/ja/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/ml/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/ru/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/sv/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/zh_Hant/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/am/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ar/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/be/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/bg/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/bn/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ca/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ceb/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/cs/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/cv/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/da/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/de/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/el/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/eo/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/es/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/eu/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/fa/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/fi/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/fil/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/fr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/gl/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/he/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/hi/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/hr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/hu/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/id/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/it/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ja/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/jv/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ka/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/kk/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/km/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/kn/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ko/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/lt/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/lv/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ml/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/mr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ms/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/nb_NO/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ne/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/nl/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/nn/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/pl/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/pt/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/pt_BR/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ro/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ru/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sa/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sah/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sc/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sdh/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sk/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sq/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sv/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/te/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/th/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/tr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/uk/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/uz/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/vi/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/zh_Hans/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/zh_Hant/ Translation: Mihon/Mihon Translation: Mihon/Mihon Plurals Co-authored-by: Ahmed seif al-nasr <[email protected]> Co-authored-by: Ajeje Brazorf <[email protected]> Co-authored-by: Akhil Raj <[email protected]> Co-authored-by: Animeboynz <[email protected]> Co-authored-by: David Katrinka <[email protected]> Co-authored-by: Dexroneum <[email protected]> Co-authored-by: Eduard Ereza Martínez <[email protected]> Co-authored-by: Eji-san <[email protected]> Co-authored-by: FateXBlood <[email protected]> Co-authored-by: Giorgio Sanna <[email protected]> Co-authored-by: Iker Lerones <[email protected]> Co-authored-by: Infy's Tagalog Translations <[email protected]> Co-authored-by: Lyfja <[email protected]> Co-authored-by: Matyáš Caras <[email protected]> Co-authored-by: Norsze <[email protected]> Co-authored-by: Pitpe11 <[email protected]> Co-authored-by: TheKingTermux <[email protected]> Co-authored-by: abc0922001 <[email protected]> Co-authored-by: bittin1ddc447d824349b2 <[email protected]> Co-authored-by: gallegonovato <[email protected]> Co-authored-by: gekka <[email protected]> Co-authored-by: sebastians17 <[email protected]> Co-authored-by: vodkapmp <[email protected]> Co-authored-by: ɴᴇᴋᴏ <[email protected]> Co-authored-by: Артём Голуб <[email protected]> (cherry picked from commit b1b15a93eec15a82e2e83650abf97c1b9f0c501c) * Add Copy Tracker URL on icon long press * Add Copy Tracker URL on icon long press Signed-off-by: Catt0s <[email protected]> * Add 'Copy To Clipboard' to tracker item menu Signed-off-by: Catt0s <[email protected]> * Add 'Copy link' to locales. Signed-off-by: Catt0s <[email protected]> * Implement code review suggestions > > Co-authored-by: AntsyLich <[email protected]> Signed-off-by: Catt0s <[email protected]> * Update app/src/main/java/eu/kanade/presentation/track/components/TrackLogoIcon.kt --------- Signed-off-by: Catt0s <[email protected]> Co-authored-by: AntsyLich <[email protected]> * Add a button to select all scanlators Resolves #943 Closes #1109 (cherry picked from commit 84b2164787a795f3fd757c325cbfb6ef660ac3a3) * Fix UI freeze after migration Fixes #938 (cherry picked from commit 3f1d28c3833e6b868152149ed02b3fb8c54eccef) * Add an "open in browser" button to reader menu (#1110) * Add an "open in browser" button to reader menu Signed-off-by: Catting <[email protected]> * fixup! Add an "open in browser" button to reader menu Signed-off-by: Catting <[email protected]> --------- Signed-off-by: Catting <[email protected]> (cherry picked from commit c5994e057b37484fec3a5300491946afe377a90a) * Handle Android SDK 35 API collision Co-authored-by: AntsyLich <[email protected]> * Fix some migrations never running Both `SetupBackupCreateMigration` and `SetupLibraryUpdateMigration` were trying to get the `App` class from Injekt which is never provided via the `AppModule`. Using `Application` instead works since the `workManager` property used by the respective `setupTask` functions is an extension property on `Context`. Co-authored-by: AntsyLich <[email protected]> Co-authored-by: MajorTanya <[email protected]> * Create CHANGELOG.md * Sync compose theme with MDC theme (cherry picked from commit 9a34ace09c66274e6c2b3f9446058a0fa99d4bd0) * Remove WebViewClientCompat (cherry picked from commit f4348df8709529b7b2319485fc8eb54c6e8173c7) * Add comment about RecyclerView cache size (#1119) Note for forks: Increasing cache size may cause OOM on API < 26, better to make it API 26+ only. (cherry picked from commit 1c47a6b9b35c622200c731cdbbc076f5263e8d06) * fix(deps): update dependency org.junit.jupiter:junit-jupiter to v5.11.0 (#1121) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 6f4e3f776f98d7a47dfa33b2cdfe992fc211ec28) * chore(deps): update dependency gradle to v8.10 (#1122) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 3f050a83dd0907e0ffb56a1e1833f9de5b10b329) * fix(deps): update dependency org.conscrypt:conscrypt-android to v2.5.3 (#1135) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit b2f1719c50365279e157a3b9ee015fc6c13a9a92) * Remove detekt (#1130) Annoying. More annoying in this project. (cherry picked from commit 777ae2461e1eb277a3aa0c998ff69e4f100387a1) * Remove more detekt annotations * Generate locales_config.xml in build dir Co-authored-by: AntsyLich <[email protected]> * Add spotless (with ktlint) (#1136) (cherry picked from commit 5ae8095ef1ed2ae9f98486f9148e933c77a28692) * Address spotless lint errors * Translations update from Hosted Weblate Co-authored-by: Ahmed seif al-nasr <[email protected]> Co-authored-by: Anas KANJO <[email protected]> Co-authored-by: Dexroneum <[email protected]> Co-authored-by: Frosted <[email protected]> Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Infy's Tagalog Translations <[email protected]> Co-authored-by: Lyfja <[email protected]> Co-authored-by: TheKingTermux <[email protected]> Co-authored-by: bittin1ddc447d824349b2 <[email protected]> Co-authored-by: gallegonovato <[email protected]> Co-authored-by: gekka <[email protected]> Co-authored-by: ɴᴇᴋᴏ <[email protected]> Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/tr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ar/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/de/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/es/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/fil/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/id/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ja/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ru/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sv/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/tr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/zh_Hans/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/zh_Hant/ Translation: Mihon/Mihon Translation: Mihon/Mihon Plurals (cherry picked from commit 4387ae5ff3131dd4aaaacd75fa6e82e7b322d474) * fix(deps): update dependency androidx.benchmark:benchmark-macro-junit4 to v1.3.0 (#1142) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 08ae51ea8c5ceccc8c5c65120f387d7b19d18052) * fix(deps): update dependency dev.chrisbanes.compose:compose-bom to v2024.08.00-alpha02 (#1143) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 24817675320855cb01250acca87b97dd7ac8a399) * chore(deps): update kotlin monorepo to v2.0.20 (#1144) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 034ec4cb120c0f36cad1303de1314c28c4ec4969) * fix(deps): update moko to v0.24.2 (#1148) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 379d5878266ba0287bfcc4a06452c27d70f33ba1) * Fix lint errors * Add option to skip downloading duplicate read chapters * Add query to get chapter count by manga and chapter number * Add functions to get chapter count by manga and chapter number * Only count read chapters * Add interactor * Savepoint * Extract new chapter logic to separate function * Update javadocs * Add preference to toggle new functionality * Add todo * Add debug logcat * Use string resource instead of hardcoding title * Add temporary logcat for debugging * Fix detekt issues * Update javadocs * Update download unread chapters preference * Remove debug logcat calls * Update javadocs * Resolve issue where read chapters were still being downloaded during manual manga fetch * Apply code review changes * Apply code review changes * Revert "Apply code review changes" This reverts commit 1a2dce7. * Revert "Apply code review changes" This reverts commit ac2a778. * Group download chapter logic inside the interactor GetChaptersToDownload * Update javadocs * Apply code review * Apply code review * Apply code review * Update CHANGELOG.md to include the new feature * Run spotless * Update domain/src/main/java/mihon/domain/chapter/interactor/FilterChaptersForDownload.kt --------- Co-authored-by: AntsyLich <[email protected]> Co-authored-by: Dani <[email protected]> * fix(deps): update aboutlib.version to v11.2.3 (#1151) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit fba9bacdc19dee7cdf9e3d1cb4ee4a496fa7b514) * Respect privacy settings in extension update notification * Hide Extension Names in Update Notifications when Content is Hidden * Moving `val` inside if * [skip ci] Update CHANGELOG.md Co-authored-by: Roshan Varughese <[email protected]> * Add confirmation when adding repo via URI * Add confirmation when adding repo via URI * Blank lines * Suggestions * Reverting Changes * Removing Unused Imports Co-authored-by: Roshan Varughese <[email protected]> * Add "show entry" action to download notifications (#1159) * Add 'show entry' to download notifications Signed-off-by: Catting <[email protected]> * fixup! Add 'show entry' to download notifications Signed-off-by: Catting <[email protected]> * fixup! Add 'show entry' to download notifications Signed-off-by: Catting <[email protected]> * spotless! Add 'show entry' to download notifications Signed-off-by: Catting <[email protected]> * Apply suggestions from code review Co-authored-by: AntsyLich <[email protected]> Co-authored-by: AntsyLich <[email protected]> * fixup! spotless- Apply suggestions from code review Signed-off-by: Catting <[email protected]> --------- Signed-off-by: Catting <[email protected]> Co-authored-by: AntsyLich <[email protected]> * fix(deps): update dependency com.android.tools:desugar_jdk_libs to v2.1.0 (#1162) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 607e56a4ec6393a3bfd25fe74cbae676fd94df22) * chore(deps): update gradle/actions action to v4.0.1 (#1165) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit d26c010e57ac0ed802cc811a029864972adfbb71) * Hide keyboard when a Tracker SearchResultItem is clicked * Hide keyboard on select * Code Review Suggestion Co-authored-by: Roshan Varughese <[email protected]> * Remove legacy broken source and history backup Co-authored-by: AntsyLich <[email protected]> * fix(deps): update serialization.version to v1.7.2 (#1173) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 1837faa573f11a6b97fe13f358d6fa0e980c2ef7) * fix(deps): update dependency com.android.tools:desugar_jdk_libs to v2.1.1 (#1172) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 7fb3ef48e4fafce471173111fe1632754e5e9e99) * fix(deps): update dependency com.android.tools.build:gradle to v8.6.0 (#1178) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit f74071ab0a70c4fd649b451e58841539d011496a) * Use feature flags in compose compiler plugin And slight cleanup Co-authored-by: AntsyLich <[email protected]> * PagerPageHolder: lazy init loading indicator Co-authored-by: ivan <[email protected]> Co-authored-by: AntsyLich <[email protected]> * Collect MangaScreen state with lifecycle Co-authored-by: ivan <[email protected]> Co-authored-by: AntsyLich <[email protected]> * Add stable marker to Manga data class Co-authored-by: ivan <[email protected]> Co-authored-by: AntsyLich <[email protected]> * `spotlessApply` my beloved * Fix import issue caused by version bump * Use DTOs to parse tracking API responses * Migrate tracking APIs to DTOs Changes the handling of tracker API responses to be parsed to DTOs instead of doing so "manually" by use of `jsonPrimitive`s and/or `Json.decodeFromString` invocations. This greatly simplifies the API response handling. Renamed constants to SCREAMING_SNAKE_CASE. Largely tried to name the DTOs in a uniform pattern, with the tracker's (short) name at the beginning of file and data class names (ALOAuth instead of OAuth, etc). With these changes, no area of the code base should be using `jsonPrimitive` and/or `Json.decodeFromString` anymore. * Fix wrong types in KitsuAlgoliaSearchItem This API returns start and end dates as Long and the score as Double. Kitsu's docs claim they're strings (and they are, when requesting manga details from Kitsu directly) but the Algolia search results return Longs and Double, respectively. * Apply review changes - Renamed `BangumiX` classes to `BGMX` classes. - Renamed `toXStatus` and `toXScore` to `toApiStatus` and `toApiScore` * Handle migration from detekt to spotless Removed Suppressions added for detekt. Specifically removed: - `SwallowedException` where an exception ends as a default value - `MagicNumber` - `CyclomaticComplexMethod` - `TooGenericExceptionThrown` Also ran spotlessApply which changed SMAddMangaResponse * Fix Kitsu failing to add series The `included` attribute seems to only appear when the user already has the entry in their Kitsu list. Since both `data` and `included` are required for `firstToTrack`, a guard clause has been added before all its calls. * Fix empty Bangumi error when entry doesn't exist Previously, the non-null assertion (!!) would cause a NullPointerException and a Toast with "Bangumi error: " (no message) when the user had removed their list entry from Bangumi through other means like the website. Now it will show "Bangumi error: Could not find manga". This is analogous to the error shown by Kitsu under these circumstances. * Fix Shikimori ignoring missing remote entry The user would see no indication that Shikimori could not properly refresh the track from the remote. This change causes the error Toast notification to pop up with the following message "Shikimori error: Could not find manga". This is analogous to Kitsu and Bangumi. * Remove usage of let where not needed These particular occurrences weren't needed because properties are directly accessible to further act upon. This neatly simplifies these clauses. * Remove missed let Co-authored-by: MajorTanya <[email protected]> * Enable 'Split Tall Images' by default (#1185) (cherry picked from commit 9c1905ede750f0229fad1a01431058b1cc9fb32d) * Option to update trackers when chapter marked as read * Track when marked as read * Add dismiss to snack bar * i18n & ignore decimal chapters * Detekt would have caught that 🤣 * `Ok` > `Yes` * Dont prompt if untracked or current > new * Move to MangaScreenModel * Suggestions Co-Authored-By: AntsyLich <[email protected]> * Review 2 * toggleAllSelections first --------- Co-authored-by: Roshan Varughese <[email protected]> Co-authored-by: AntsyLich <[email protected]> * Migrate some classpaths to gradle plugins Co-authored-by: AntsyLich <[email protected]> * fix(deps): update dependency com.android.tools:desugar_jdk_libs to v2.1.2 (#1188) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit c4d2fffb12c83c76cf48a85cbc9d7d754a4da39c) * Fix Kitsu `ratingTwenty` being typed as String The API docs and the responses type `ratingTwenty` as a "number" (Int in Kotlin, it's divided by 2 for a .5 step scale 0-10). It's nullable because an entry without a user rating returns `null` in that field. Co-authored-by: MajorTanya <[email protected]> * Rename LocalesConfigPlugin file to LocalesConfigTask Co-authored-by: AntsyLich <[email protected]> * Move archive related code to :core:archive Co-authored-by: AntsyLich <[email protected]> * Use new library for injekt with inorichi patch (cherry picked from commit c929854ae98b874bf1a7aceb82a15fbe3fb6a41f) * Fix moving of `openFileDescriptor` * Switch to stable compose (cherry picked from commit 2baffa62cade1abd978d5fd03151b47fc87fd31e) * fix(deps): update lifecycle.version to v2.8.5 (#1190) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 0e956cbb518e0e0827c1e7dfde8427cb8660a9fb) * fix(deps): update dependency com.google.accompanist:accompanist-systemuicontroller to v0.36.0 (#1192) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 29a74509a4af475694551808e317df96ea1146ad) * fix(deps): update dependency androidx.activity:activity-compose to v1.9.2 (#1189) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 52036e5664cbcf552de706adee6e0b4b972fe1c3) * Ignore "intent://" urls on webview ignore intent urls Co-authored-by: bapeey <[email protected]> * `spotlessApply` my beloved * Use TextFieldState in BasicTextField where applicable Co-authored-by: AntsyLich <[email protected]> * Reduce ChapterNavigator horizontal padding on small ui Co-authored-by: AntsyLich <[email protected]> * Bump NDK version (#1203) (cherry picked from commit fbcc48fefc7ed050f6416a8684816730bcb5f8a8) * Show toast for app restart when User-Agent is changed (#1204) (cherry picked from commit c8ad6cdf31a14bce9a525cfc2a0616e8ac51d7c3) * fix(deps): update dependency org.jetbrains.kotlinx:kotlinx-collections-immutable to v0.3.8 (#1198) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 844dae1a4d23b88318e0ea482b38df4e3f5f2be2) * chore(deps): update dependency gradle to v8.10.1 (#1211) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit fcb01b5bcf81e7c25ff820e99fcf10e867c3782f) * chore(deps): update actions/setup-java action to v4.3.0 (#1212) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit be5d467955b386a5bab0c27347b4c183cd076e16) * fix(deps): update dependency org.jetbrains.kotlinx:kotlinx-coroutines-bom to v1.9.0 (#1222) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 1ff88dd9274db681ae0d76b39223389a1f758973) * chore(deps): update gradle/actions action to v4.1.0 (#1219) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 86dd809f4d1bce450ac54da61afd034b5a43c757) * fix(deps): update dependency com.squareup.okio:okio to v3.9.1 (#1217) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit bebf80dfaec037559af061950083289a0ae23b44) * fix(deps): update dependency androidx.compose:compose-bom to v2024.09.01 (#1214) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit d42f776c5c5ddd8fade02bc7d0117a7c3e1054d5) * Fix: wrong calculation of nextUpdate when setting custom fetchInterval Co-authored-by: Cuong-Tran <[email protected]> * Fix WheelPicker Manual Input (#1209) * Fix WheelPicker Manual Input * Lambda * inline * Update WheelPicker.kt --------- Co-authored-by: AntsyLich <[email protected]> (cherry picked from commit 339dc33f5833b224c01577da3da081deecdbbca2) * Fix Kitsu synopsis nullability This time, the Kitsu API docs are silent on whether this field (or any other field) can be null/undefined/etc, but it can happen and caused an error during search and update. This change just ensures the attribute is nullable and is set to an empty String when it is null. Co-authored-by: MajorTanya <[email protected]> * Re-enable fetching chapters list for entries with licenced status Enable Licensed Co-authored-by: Roshan Varughese <[email protected]> * fix(deps): update dependency me.zhanghai.android.libarchive:library to v1.1.1 (#1229) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 1e570bc9654fb0382a8d5b37923c9700e49be696) * fix(deps): update dependency com.android.tools.build:gradle to v8.6.1 (#1235) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 0042cb6582f05d2a139b059bef81dc979e9a8ad6) * Change casing for Extention Repos String (#1248) (cherry picked from commit 2276abbb2373b94535e99c2d72ce0f7f6a1d008a) * fix(deps): update serialization.version to v1.7.3 (#1246) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 6dd93d70cc5c7fa39157d069b41be5557256537e) * fix(deps): update dependency androidx.benchmark:benchmark-macro-junit4 to v1.3.1 (#1238) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit b3867dd63c714333f58678f13b4cafc708cbd918) * fix(deps): update lifecycle.version to v2.8.6 (#1241) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 418ba3026546b4785907c001a05006b609b490a3) * fix(deps): update dependency androidx.profileinstaller:profileinstaller to v1.4.0 (#1242) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 380787a31021d710a8a6619d4e0c1b01e3e47941) * chore(deps): update actions/setup-java action to v4.4.0 (#1259) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit dde942df4eced3889bd61cec28b6cf59fe1c0de7) * fix(deps): update dependency me.zhanghai.android.libarchive:library to v1.1.2 (#1255) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit d04eeface97d64d921e9df23ffeba49d3eca2994) * chore(deps): update actions/checkout action to v4.2.0 (#1266) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 369df527b243e0a39687e5b77d63c7eed3a3772a) * fix(deps): update dependency org.junit.jupiter:junit-jupiter to v5.11.1 (#1262) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 2dd02b73d6059cef372e5d605efdafa7f60b47b0) * fix(deps): update dependency androidx.compose:compose-bom to v2024.09.02 (#1239) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> (cherry picked from commit 112b68b782d0f0ac027bf3d73ad28a8df0dc75b8) * chore(deps): update dependency gradle to v8.10.2 (#1254) * chore(deps): update dependency gradle to v8.10.2 * Update binaries --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: AntsyLich <[email protected]> (cherry picked from commit f7c8f1801ea8c7af7542ab8e3dce035ada495c7c) * fix(deps): update dependency com.android.tools.build:gradle to v8.7.0 (#1284) (cherry picked from commit cca33481dd1466ae6a9919796229586fe0937523) * fix(deps): update dependency androidx.benchmark:benchmark-macro-junit4 to v1.3.2 (#1287) (cherry picked from commit 6984e0465babed7638481b1982de7415612f32e5) * fix(deps): update dependency androidx.profileinstaller:profileinstaller to v1.4.1 (#1289) (cherry picked from commit c72c07f355a93f67d16166715dfdab88f2cc9201) * fix(deps): update dependency org.junit.jupiter:junit-jupiter to v5.11.2 (#1294) (cherry picked from commit 85ee9c6686ee4f4ca5519297df7c4b5482cc26c2) * fix(deps): update dependency androidx.compose:compose-bom to v2024.09.03 (#1288) (cherry picked from commit f7fbc93833c6107791680412cc110336d0e4e717) * Fix AniList `ALSearchItem.status` nullibility * chore(deps): update actions/checkout action to v4.2.1 (#1304) (cherry picked from commit 6adfa4fd0fdd320aedaeaf2d6cccf798e46dd6c4) * fix(deps): update dependency io.coil-kt.coil3:coil-bom to v3.0.0-rc01 (#1308) (cherry picked from commit 8113b77f1e762629f31cbcc5b9163819c6384a8b) * Update renovate configuration - Remove package rule for "dev.chrisbanes.compose:compose-bom" - Disable semantic commits (cherry picked from commit aa998071a1f476a6078f19500bc58f7855c3f8ae) * Update dependency io.mockk:mockk to v1.13.13 (#1313) (cherry picked from commit a2dc88965b8b06cd40d65b75450e1ca4a1e08bd4) * Retain remote last chapter read if it's higher than the local one for EnhancedTracker Co-authored-by: brewkunz <[email protected]> * Update kotlin monorepo to v2.0.21 (#1314) (cherry picked from commit 016f627fb0998dabcd6aea907b54365aa4e6a285) * Cleanup `LibraryScreenModel` `LibraryMap.applySort` and some more Co-authored-by: AntsyLich <[email protected]> * run `spotlessApply` * Tweak Preference.collectAsState Co-authored-by: p (cherry picked from commit 3bddb5538528c19388e364d21e6a6c16487af759) * Adjust distinct checker in WidgetManager and run on default dispatcher Co-authored-by: AntsyLich <[email protected]> * Update resources exclusion rules Co-authored-by: p (cherry picked from commit 481cfedf08576cecfbb35616837bd8f627d8f959) * Bump compile sdk to 35 Co-authored-by: AntsyLich <[email protected]> * ChapterNavigator: dispatch page change only when needed Co-authored-by: AntsyLich <[email protected]> * Remove usage of deprecated accompanist SystemUiController Co-authored-by: AntsyLich <[email protected]> * run `spotlessApply` * Tweak profile compilation status output Co-authored-by: AntsyLich <[email protected]> * Add Quantity Badge to Upcoming Screen Co-authored-by: Roshan Varughese <[email protected]> Co-authored-by: AntsyLich <[email protected]> * Added random library sort Co-authored-by: Jack Hamilton <[email protected]> Co-authored-by: AntsyLich <[email protected]> * Update dependency me.zhanghai.android.libarchive:library to v1.1.3 (#1321) (cherry picked from commit 0a4ad89b9902061e3e2c2d9f2eb71f6b33c5c01c) * Confirmation dialog when removing privately installed extensions Co-authored-by: Roshan Varughese <[email protected]> Co-authored-by: AntsyLich <[email protected]> * Fix EnhancedTracker not auto binding when adding manga to library Co-authored-by: brewkunz <[email protected]> * Run PR check when base strings are changed Co-authored-by: AntsyLich <[email protected]> * Refrain from running spotless on weblate files Those are akin to generated files and are likely to not follow our formatting (cherry picked from commit 32d2c2ac1bc224cbda2f09a4023d7d120ea0e954) * Adjust expandable fab animation Co-authored-by: p (cherry picked from commit eb6092bd0cfa09694985a8bafdd8bbf2815190a1) * Add option to backup non-library read entries Co-authored-by: Roshan Varughese <[email protected]> Co-authored-by: jobobby04 <[email protected]> Co-authored-by: AntsyLich <[email protected]> * Fix PR build check (cherry picked from commit 9503082d44b5bd868ee1bfc42741dc978d1d9047) * Cleanup .gitignore files (cherry picked from commit afa50029882655af8d5eea40aed7644fce4564d8) * Reorder reader menu overflow items Co-authored-by: AntsyLich <[email protected]> * Make sure random library sort is at the bottom Co-authored-by: AntsyLich <[email protected]> * Update dependency com.android.tools.build:gradle to v8.7.1 (#1326) (cherry picked from commit 48166b9b52836f225273651b21fb02e7aba4197e) * Update i18n readme Co-authored-by: FlaminSarge <[email protected]> * Update dependency androidx.activity:activity-compose to v1.9.3 (#1333) (cherry picked from commit ba1343bed8c00d5ed976111c710c9b5648676a59) * Update dependency androidx.benchmark:benchmark-macro-junit4 to v1.3.3 (#1334) (cherry picked from commit 572ee2f02a980a60a1120e7c0c88060fb1a7b3d2) * Update dependency androidx.glance:glance-appwidget to v1.1.1 (#1335) (cherry picked from commit 443f6e0ae53dadce1f66818fac0cd1eeaa5fec27) * Update dependency androidx.annotation:annotation to v1.9.0 (#1336) (cherry picked from commit 337806d9e17e92a9134d59324e9857d05abc4db3) * Change "Invalidate downloads index" to "Reindex downloads" Co-authored-by: AntsyLich <[email protected]> * Update xml.serialization.version to v0.90.2 (#1331) * Update xml.serialization.version to v0.90.2 * Fix build --------- Co-authored-by: AntsyLich <[email protected]> (cherry picked from commit dbf6ad2ca7e0525f597010709e87d094d10e4f8d) * Update dependency androidx.compose:compose-bom to v2024.10.00 (#1338) (cherry picked from commit 5612ae0149e9231c9691ee782da8159489a0d057) * Revert "Tweak Preference.collectAsState" This reverts commit 3bddb5538528c19388e364d21e6a6c16487af759. Fixes #1341 (cherry picked from commit eb3bea8150ce9bf2320d15c879cbebaa6d51a4c6) * Address deprecation, suggestion and spotless Co-authored-by: AntsyLich <[email protected]> * Pass uncaught exception to default handler in GlobalExceptionHandler Fixes #1347 (cherry picked from commit f3a2f566c8a09ab862758ae69b43da2a2cd8f1db) * Update dependency org.junit.jupiter:junit-jupiter to v5.11.3 (#1351) (cherry picked from commit e16c3953c709a6c35c4655f916119fdf665baa62) * Update shizuku.version to v13.1.0 (cherry picked from commit c550a81598c98ef9a22dac8f6a408f5c15235fde) * Update actions/dependency-review-action action to v4.3.5 (#1354) (cherry picked from commit e1e3ca7a565503d325322fbbdbff01868f6f2bcb) * Update actions/checkout action to v4.2.2 (#1361) (cherry picked from commit 01b44c0458eb77f8d5347328be0c3ef25c906b1b) * Make renovate group github action deps (cherry picked from commit d4bf19f957cf32671b7306076ac5bd5c94732d8b) * Pin actions/upload-artifact action to b4b15b8 (#1363) Co-authored-by: AntsyLich <[email protected]> (cherry picked from commit 47b0e9d7bec5ab0c7d16a3c70999eaac8636f633) * Rework Auto Track on Mark as Read Co-authored-by: Roshan Varughese <[email protected]> * Fix settings SliderItem steps count (#1356) (cherry picked from commit 2ba7ed32802ffca1946d567b8afe49bfd3f4326e) * Avoid blocking call to load categories in settings Co-authored-by: Cuong-Tran <[email protected]> * Update dependency me.zhanghai.android.libarchive:library to v1.1.4 (#1378) (cherry picked from commit aae0e3459ce13398a64b5cd9995f4a40a0120822) * Cleanup Slider usage (cherry picked from commit df9fff60da3a38acd8fcd540b5fdd275be93f2d5) * Update actions/setup-java action to v4.5.0 (#1366) (cherry picked from commit 2bf7ef5d18f839e31c501f4e6e1abff9fa7f74d6) * Update dependency com.pinterest.ktlint:ktlint-cli to v1.4.0 Co-authored-by: AntsyLich <[email protected]> Co-authored-by: Mend Renovate <[email protected]> * Add libs.material to presentation-widget (#1373) Fixes some build issues (cherry picked from commit 264030d6ecbc7492d884eb328b74399cd722dcb0) * Allow completely disabling "Update tracker" snackbar on mark as read Co-authored-by: Roshan Varughese <[email protected]> * Fix app crash when removing tracked entry from tracker Co-authored-by: Cuong-Tran <[email protected]> * Release v0.17.0 (a.k.a. bump versionCode) Co-authored-by: AntsyLich <[email protected]> * Here lies "currentTab was used multiple times" Co-authored-by: AntsyLich <[email protected]> * Fix sporadically recurring spotless CI failure Somehow this specific issue keeps getting flagged by unrelated PRs' CI runs (but only sometimes? Somehow? Other times the CI run would succeed with no spotless issues.) --------- Co-authored-by: MajorTanya <[email protected]> Co-authored-by: AntsyLich <[email protected]> * Switch to spotless 7.0.0 Beta 4 (cherry picked from commit b8b053b1d720a6de5c3d4d8a683eed7bc8cdcc5f) * Update dependency androidx.viewpager:viewpager to v1.1.0-beta01 (#1414) (cherry picked from commit 9d6ddb5d91bd062876bdb108ca3ce278359551e5) * Update dependency androidx.annotation:annotation to v1.9.1 (#1413) (cherry picked from commit eedece5adfbb95c882d4d59a5020f7e27c634c13) * Some improvements to Bangumi tracker search Probably fix the anime side as well In short: - fetch & show actual summary - fallback to "name" if "name_cn" is empty - request larger responseGroup to get & display the summary & rating - add type filter query param to make Bangumi filter, not us Previously, we only displayed the "name" in the summary area and used "name_cn" as the entry name. However, "name_cn" (Chinese name) can be an empty string at times, resulting in an awkward looking search result list where some, many, or even all the results have no title displayed and only show the "name" (Japanese name) in the summary area. This has been solved by using "name" as a fallback value should "name_cn" be empty. If a Chinese name is available, the original name is prepended to the summary with the addition "作品原名:" (meaning "original series title"). By using the "responseGroup=large" query parameter, we can request the required data we need to display the actual summary for an entry and the entry's average rating. The "name" is prepended to the summary contents, if any exist, so it is still accessible for series identification if a "name_cn" exists too and was used for the result title. Adding the "type=1" filter query parameter means Bangumi will only return entries of type 1 ("book") instead of all types and Mihon needing to filter, resulting in potentially missed entry matches. Co-authored-by: MajorTanya <[email protected]> * Update lifecycle.version to v2.8.7 (#1415) (cherry picked from commit 328ec8c752f276a6e75f68102a257880e4b18753) * Update dependency androidx.constraintlayout:constraintlayout to v2.2.0 (#1416) (cherry picked from commit 2914d166fe0ad5d6bb126fd5fe89d8ca3074787b) * Update actions/dependency-review-action action to v4.4.0 (#1402) (cherry picked from commit 41ae8505fecd08c77bf316172e29698dd12b4023) * Update dependency io.coil-kt.coil3:coil-bom to v3.0.0-rc02 (#1401) (cherry picked from commit f33a6d25209fa9a1291f3dae222fc0ff8d95dba9) * Add to CHANGELOG.md * run `spotlessApply` * fix: Subtitle selection not matching two letter language codes (#1805) * chore(i18n): Translations update from Hosted Weblate (#1788) Co-authored-by: ᎽᎪՏՏᎬᎡ ᏴᎬΝ ᎻᎪᎷᎡΘႮᏟᎻᎬ <[email protected]> Co-authored-by: 何意挽秋風 <[email protected]> Co-authored-by: Renn <[email protected]> Co-authored-by: Matt <[email protected]> Co-authored-by: 翻訳する男 <[email protected]> Co-authored-by: Reno Tx <[email protected]> Co-authored-by: Mohammed al-Qubati <[email protected]> Co-authored-by: Jonathan B <[email protected]> Co-authored-by: Akhil Raj <[email protected]> Co-authored-by: Frosted <[email protected]> Co-authored-by: N. Hao <[email protected]> Co-authored-by: Ajeje Brazorf <[email protected]> Co-authored-by: jmir1 <[email protected]> * chore(i18n): Weblate automatic tasks (#1811) * fix merge * fix spotless * te odio spotless --------- Signed-off-by: Catt0s <[email protected]> Signed-off-by: Catting <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: FooIbar <[email protected]> Co-authored-by: Secozzi <[email protected]> Co-authored-by: Foolbar <[email protected]> Co-authored-by: Roshan Varughese <[email protected]> Co-authored-by: Cuong-Tran <[email protected]> Co-authored-by: AntsyLich <[email protected]> Co-authored-by: Vetle Ledaal <[email protected]> Co-authored-by: Tran M. Cuong <[email protected]> Co-authored-by: ivan <[email protected]> Co-authored-by: Catting <[email protected]> Co-authored-by: MajorTanya <[email protected]> Co-authored-by: Weblate (bot) <[email protected]> Co-authored-by: Dani <[email protected]> Co-authored-by: Smol Ame <[email protected]> Co-authored-by: bapeey <[email protected]> Co-authored-by: NGB-Was-Taken <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: brewkunz <[email protected]> Co-authored-by: Jack Hamilton <[email protected]> Co-authored-by: jobobby04 <[email protected]> Co-authored-by: FlaminSarge <[email protected]> Co-authored-by: abdurisaq <[email protected]> Co-authored-by: jmir1 <[email protected]> Co-authored-by: Secozzi <[email protected]> Co-authored-by: ᎽᎪՏՏᎬᎡ ᏴᎬΝ ᎻᎪᎷᎡΘႮᏟᎻᎬ <[email protected]> Co-authored-by: 何意挽秋風 <[email protected]> Co-authored-by: Renn <[email protected]> Co-authored-by: Matt <[email protected]> Co-authored-by: 翻訳する男 <[email protected]> Co-authored-by: Reno Tx <[email protected]> Co-authored-by: Mohammed al-Qubati <[email protected]> Co-authored-by: Jonathan B <[email protected]> Co-authored-by: Akhil Raj <[email protected]> Co-authored-by: Frosted <[email protected]> Co-authored-by: N. Hao <[email protected]> Co-authored-by: Ajeje Brazorf <[email protected]>
Dark25
added a commit
to Dark25/Animetail2
that referenced
this pull request
Nov 6, 2024
* fix(deps): update dependency io.coil-kt.coil3:coil-bom to v3.0.0-alpha09 (aniyomiorg#1039) (cherry picked from commit ca784cbe3267e94e652e4c54f91b7107cc53c307) * Remove obsolete workaround * chore(deps): update softprops/action-gh-release action to v2.0.8 * fix(deps): update dependency androidx.activity:activity-compose to v1.9.1 (aniyomiorg#1042) (cherry picked from commit e48dbdbf2356c0e6e148313dc6610e865cd8e995) * fix(deps): update dependency androidx.annotation:annotation to v1.8.1 (aniyomiorg#1043) (cherry picked from commit 602b58f364b95b83a3148be34cd4c90d95d7d405) * fix(deps): update lifecycle.version to v2.8.4 (aniyomiorg#1045) (cherry picked from commit b7849d714698900a25188bdbfd77bf24936f2dd7) * Format Category String on Subtitle Display * Fixes aniyomiorg#1029 * Max Line Length Fix * Update SettingsLibraryScreen.kt No idea how this works. --------- * fix(deps): update paging.version to v3.3.1 (aniyomiorg#1046) (cherry picked from commit 41e2dc7ae80250d9166fc637c1170667afdb0a9e) * fix(deps): update dependency dev.chrisbanes.compose:compose-bom to v2024.07.00-alpha02 (aniyomiorg#1051) (cherry picked from commit 04aa5b36a5893ef9991312d61f84f830b83535f7) * Fix disappearance items when fast scrolling * Don't use animateItem's fade-in/fade-out in FastScrollLazyColumn * Move to extension function Avoid using animateItemPlacement name since it's shadowed by compose-bom's deprecated one * Adds Option to Copy Panel to Clipboard * Add Copy to Clipboard * Removing Unused Import * Reusing onShare function * Commit Suggestion * Early Return on null --------- * Fix library is backed up when disabled and make categories backup/restore independent * Cleanup backup/restore related code * Bump default user agent string (cherry picked from commit 8160b47ff5fbbd9b32caeb462b5be881fabd3449) * Improve error message if restoring from JSON file * Improve error message if restoring from JSON file * Replace Exception with IOException * Use more generic error message if protobuf fails * fix lint * Match extra layout space with scroll distance (aniyomiorg#1076) And increase recycler item view cache size. (cherry picked from commit a3dfd2efe6ace7a2a4d79bd09fb1a729989f1094) * chore(deps): update actions/setup-java action to v4.2.2 (aniyomiorg#1080) (cherry picked from commit 3f6bd5f010532d292310c0c0f14bf11832277f2e) * fix: drawScrollbar crash on list with 0 item but only sticky header * Don't crash on ill-formed URLs (aniyomiorg#1084) (cherry picked from commit 854474f85ffc41eccdc2b3a6cf105fa2805ebc3c) * chore(deps): update kotlin monorepo to v2.0.10 (aniyomiorg#1085) (cherry picked from commit edb8201f74e516c296b62e04a13802e1bd9e0b6b) * Rename backup restore error log file * Add Backup and Restore of Extension Repos (aniyomiorg#1057) * Backup/Restore Extension Repos * Refactor * Moving to Under App Settings * Sort by URL, Check existing by SHA and Error Logging Untested. Currently in a lecture and can't test if the changes really work. * Changes to logic * Don't ask me what's happening here * Renaming Variables * Fixing restoreAmount & changes to logic --------- * ExpandableMangaDescription: Adjust size transform anim spec * fix(deps): update paging.version to v3.3.2 (aniyomiorg#1093) (cherry picked from commit 8e40146f96704c3dc98bbb4f9f89d470ffa32f69) * chore(deps): update gradle/actions action to v4 * fix(deps): update dependency androidx.annotation:annotation to v1.8.2 (aniyomiorg#1090) (cherry picked from commit 36b9caeea8baf15f0d0ed37abc12638d44194c09) * fix(deps): update dependency androidx.work:work-runtime to v2.9.1 (aniyomiorg#1091) (cherry picked from commit af77083660000e7378587dbc8d44e44bd8b196ec) * fix(deps): update dependency io.coil-kt.coil3:coil-bom to v3.0.0-alpha10 (aniyomiorg#1092) (cherry picked from commit e8b7c3e24bb677d289554b972ef2496a976c79aa) * fix(deps): update dependency dev.chrisbanes.compose:compose-bom to v2024.08.00-alpha01 (aniyomiorg#1094) (cherry picked from commit dca9bf105770890e015b8e2f9fbf22f05665e343) * fix(deps): update dependency com.android.tools.build:gradle to v8.5.2 (aniyomiorg#1099) (cherry picked from commit 4828c54245dd6532c0e7a2b6c8cf5d8a703d3376) * Contributing: ktLintFormat -> detekt (aniyomiorg#1102) * Contributing: ktLintFormat -> detekt update Contributing info to use detekt instead of ktLintFormat * Update CONTRIBUTING.md --------- (cherry picked from commit 14ae57d78b31f0bb3b58d19c1d8cfcebcc8e2253) * Change Kitsu to kitsu.app domain cf. hummingbird-me/kitsu-server@244fdcc * Fix MAL search results not showing start dates The previous approach would always throw an Exception because `SimpleDateFormat.format()` expects the input to be of type `Date` or `Number`, not `String`. * Translations update from Hosted Weblate (aniyomiorg#939) Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/ar/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/ca/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/cs/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/de/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/es/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/fil/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/id/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/ja/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/ml/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/ru/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/sv/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/zh_Hant/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/am/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ar/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/be/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/bg/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/bn/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ca/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ceb/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/cs/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/cv/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/da/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/de/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/el/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/eo/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/es/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/eu/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/fa/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/fi/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/fil/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/fr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/gl/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/he/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/hi/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/hr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/hu/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/id/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/it/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ja/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/jv/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ka/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/kk/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/km/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/kn/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ko/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/lt/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/lv/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ml/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/mr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ms/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/nb_NO/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ne/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/nl/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/nn/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/pl/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/pt/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/pt_BR/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ro/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ru/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sa/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sah/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sc/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sdh/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sk/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sq/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sv/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/te/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/th/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/tr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/uk/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/uz/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/vi/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/zh_Hans/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/zh_Hant/ Translation: Mihon/Mihon Translation: Mihon/Mihon Plurals (cherry picked from commit b1b15a93eec15a82e2e83650abf97c1b9f0c501c) * Add Copy Tracker URL on icon long press * Add Copy Tracker URL on icon long press * Add 'Copy To Clipboard' to tracker item menu * Add 'Copy link' to locales. * Implement code review suggestions > > Co-authored-by: AntsyLich <[email protected]> * Update app/src/main/java/eu/kanade/presentation/track/components/TrackLogoIcon.kt --------- * Add a button to select all scanlators Resolves aniyomiorg#943 Closes aniyomiorg#1109 (cherry picked from commit 84b2164787a795f3fd757c325cbfb6ef660ac3a3) * Fix UI freeze after migration Fixes aniyomiorg#938 (cherry picked from commit 3f1d28c3833e6b868152149ed02b3fb8c54eccef) * Add an "open in browser" button to reader menu (aniyomiorg#1110) * Add an "open in browser" button to reader menu * fixup! Add an "open in browser" button to reader menu --------- (cherry picked from commit c5994e057b37484fec3a5300491946afe377a90a) * Handle Android SDK 35 API collision * Fix some migrations never running Both `SetupBackupCreateMigration` and `SetupLibraryUpdateMigration` were trying to get the `App` class from Injekt which is never provided via the `AppModule`. Using `Application` instead works since the `workManager` property used by the respective `setupTask` functions is an extension property on `Context`. * Create CHANGELOG.md * Sync compose theme with MDC theme (cherry picked from commit 9a34ace09c66274e6c2b3f9446058a0fa99d4bd0) * Remove WebViewClientCompat (cherry picked from commit f4348df8709529b7b2319485fc8eb54c6e8173c7) * Add comment about RecyclerView cache size (aniyomiorg#1119) Note for forks: Increasing cache size may cause OOM on API < 26, better to make it API 26+ only. (cherry picked from commit 1c47a6b9b35c622200c731cdbbc076f5263e8d06) * fix(deps): update dependency org.junit.jupiter:junit-jupiter to v5.11.0 (aniyomiorg#1121) (cherry picked from commit 6f4e3f776f98d7a47dfa33b2cdfe992fc211ec28) * chore(deps): update dependency gradle to v8.10 (aniyomiorg#1122) (cherry picked from commit 3f050a83dd0907e0ffb56a1e1833f9de5b10b329) * fix(deps): update dependency org.conscrypt:conscrypt-android to v2.5.3 (aniyomiorg#1135) (cherry picked from commit b2f1719c50365279e157a3b9ee015fc6c13a9a92) * Remove detekt (aniyomiorg#1130) Annoying. More annoying in this project. (cherry picked from commit 777ae2461e1eb277a3aa0c998ff69e4f100387a1) * Remove more detekt annotations * Generate locales_config.xml in build dir * Add spotless (with ktlint) (aniyomiorg#1136) (cherry picked from commit 5ae8095ef1ed2ae9f98486f9148e933c77a28692) * Address spotless lint errors * Translations update from Hosted Weblate Translate-URL: https://hosted.weblate.org/projects/mihon/mihon-plurals/tr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ar/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/de/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/es/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/fil/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/id/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ja/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/ru/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/sv/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/tr/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/zh_Hans/ Translate-URL: https://hosted.weblate.org/projects/mihon/mihon/zh_Hant/ Translation: Mihon/Mihon Translation: Mihon/Mihon Plurals (cherry picked from commit 4387ae5ff3131dd4aaaacd75fa6e82e7b322d474) * fix(deps): update dependency androidx.benchmark:benchmark-macro-junit4 to v1.3.0 (aniyomiorg#1142) (cherry picked from commit 08ae51ea8c5ceccc8c5c65120f387d7b19d18052) * fix(deps): update dependency dev.chrisbanes.compose:compose-bom to v2024.08.00-alpha02 (aniyomiorg#1143) (cherry picked from commit 24817675320855cb01250acca87b97dd7ac8a399) * chore(deps): update kotlin monorepo to v2.0.20 (aniyomiorg#1144) (cherry picked from commit 034ec4cb120c0f36cad1303de1314c28c4ec4969) * fix(deps): update moko to v0.24.2 (aniyomiorg#1148) (cherry picked from commit 379d5878266ba0287bfcc4a06452c27d70f33ba1) * Fix lint errors * Add option to skip downloading duplicate read chapters * Add query to get chapter count by manga and chapter number * Add functions to get chapter count by manga and chapter number * Only count read chapters * Add interactor * Savepoint * Extract new chapter logic to separate function * Update javadocs * Add preference to toggle new functionality * Add todo * Add debug logcat * Use string resource instead of hardcoding title * Add temporary logcat for debugging * Fix detekt issues * Update javadocs * Update download unread chapters preference * Remove debug logcat calls * Update javadocs * Resolve issue where read chapters were still being downloaded during manual manga fetch * Apply code review changes * Apply code review changes * Revert "Apply code review changes" This reverts commit 1a2dce7. * Revert "Apply code review changes" This reverts commit ac2a778. * Group download chapter logic inside the interactor GetChaptersToDownload * Update javadocs * Apply code review * Apply code review * Apply code review * Update CHANGELOG.md to include the new feature * Run spotless * Update domain/src/main/java/mihon/domain/chapter/interactor/FilterChaptersForDownload.kt --------- * fix(deps): update aboutlib.version to v11.2.3 (aniyomiorg#1151) (cherry picked from commit fba9bacdc19dee7cdf9e3d1cb4ee4a496fa7b514) * Respect privacy settings in extension update notification * Hide Extension Names in Update Notifications when Content is Hidden * Moving `val` inside if * [skip ci] Update CHANGELOG.md * Add confirmation when adding repo via URI * Add confirmation when adding repo via URI * Blank lines * Suggestions * Reverting Changes * Removing Unused Imports * Add "show entry" action to download notifications (aniyomiorg#1159) * Add 'show entry' to download notifications * fixup! Add 'show entry' to download notifications * fixup! Add 'show entry' to download notifications * spotless! Add 'show entry' to download notifications * Apply suggestions from code review * fixup! spotless- Apply suggestions from code review --------- * fix(deps): update dependency com.android.tools:desugar_jdk_libs to v2.1.0 (aniyomiorg#1162) (cherry picked from commit 607e56a4ec6393a3bfd25fe74cbae676fd94df22) * chore(deps): update gradle/actions action to v4.0.1 (aniyomiorg#1165) (cherry picked from commit d26c010e57ac0ed802cc811a029864972adfbb71) * Hide keyboard when a Tracker SearchResultItem is clicked * Hide keyboard on select * Code Review Suggestion * Remove legacy broken source and history backup * fix(deps): update serialization.version to v1.7.2 (aniyomiorg#1173) (cherry picked from commit 1837faa573f11a6b97fe13f358d6fa0e980c2ef7) * fix(deps): update dependency com.android.tools:desugar_jdk_libs to v2.1.1 (aniyomiorg#1172) (cherry picked from commit 7fb3ef48e4fafce471173111fe1632754e5e9e99) * fix(deps): update dependency com.android.tools.build:gradle to v8.6.0 (aniyomiorg#1178) (cherry picked from commit f74071ab0a70c4fd649b451e58841539d011496a) * Use feature flags in compose compiler plugin And slight cleanup * PagerPageHolder: lazy init loading indicator * Collect MangaScreen state with lifecycle * Add stable marker to Manga data class * `spotlessApply` my beloved * Fix import issue caused by version bump * Use DTOs to parse tracking API responses * Migrate tracking APIs to DTOs Changes the handling of tracker API responses to be parsed to DTOs instead of doing so "manually" by use of `jsonPrimitive`s and/or `Json.decodeFromString` invocations. This greatly simplifies the API response handling. Renamed constants to SCREAMING_SNAKE_CASE. Largely tried to name the DTOs in a uniform pattern, with the tracker's (short) name at the beginning of file and data class names (ALOAuth instead of OAuth, etc). With these changes, no area of the code base should be using `jsonPrimitive` and/or `Json.decodeFromString` anymore. * Fix wrong types in KitsuAlgoliaSearchItem This API returns start and end dates as Long and the score as Double. Kitsu's docs claim they're strings (and they are, when requesting manga details from Kitsu directly) but the Algolia search results return Longs and Double, respectively. * Apply review changes - Renamed `BangumiX` classes to `BGMX` classes. - Renamed `toXStatus` and `toXScore` to `toApiStatus` and `toApiScore` * Handle migration from detekt to spotless Removed Suppressions added for detekt. Specifically removed: - `SwallowedException` where an exception ends as a default value - `MagicNumber` - `CyclomaticComplexMethod` - `TooGenericExceptionThrown` Also ran spotlessApply which changed SMAddMangaResponse * Fix Kitsu failing to add series The `included` attribute seems to only appear when the user already has the entry in their Kitsu list. Since both `data` and `included` are required for `firstToTrack`, a guard clause has been added before all its calls. * Fix empty Bangumi error when entry doesn't exist Previously, the non-null assertion (!!) would cause a NullPointerException and a Toast with "Bangumi error: " (no message) when the user had removed their list entry from Bangumi through other means like the website. Now it will show "Bangumi error: Could not find manga". This is analogous to the error shown by Kitsu under these circumstances. * Fix Shikimori ignoring missing remote entry The user would see no indication that Shikimori could not properly refresh the track from the remote. This change causes the error Toast notification to pop up with the following message "Shikimori error: Could not find manga". This is analogous to Kitsu and Bangumi. * Remove usage of let where not needed These particular occurrences weren't needed because properties are directly accessible to further act upon. This neatly simplifies these clauses. * Remove missed let * Enable 'Split Tall Images' by default (aniyomiorg#1185) (cherry picked from commit 9c1905ede750f0229fad1a01431058b1cc9fb32d) * Option to update trackers when chapter marked as read * Track when marked as read * Add dismiss to snack bar * i18n & ignore decimal chapters * Detekt would have caught that 🤣 * `Ok` > `Yes` * Dont prompt if untracked or current > new * Move to MangaScreenModel * Suggestions * Review 2 * toggleAllSelections first --------- * Migrate some classpaths to gradle plugins * fix(deps): update dependency com.android.tools:desugar_jdk_libs to v2.1.2 (aniyomiorg#1188) (cherry picked from commit c4d2fffb12c83c76cf48a85cbc9d7d754a4da39c) * Fix Kitsu `ratingTwenty` being typed as String The API docs and the responses type `ratingTwenty` as a "number" (Int in Kotlin, it's divided by 2 for a .5 step scale 0-10). It's nullable because an entry without a user rating returns `null` in that field. * Rename LocalesConfigPlugin file to LocalesConfigTask * Move archive related code to :core:archive * Use new library for injekt with inorichi patch (cherry picked from commit c929854) * Fix moving of `openFileDescriptor` * Switch to stable compose (cherry picked from commit 2baffa62cade1abd978d5fd03151b47fc87fd31e) * fix(deps): update lifecycle.version to v2.8.5 (aniyomiorg#1190) (cherry picked from commit 0e956cbb518e0e0827c1e7dfde8427cb8660a9fb) * fix(deps): update dependency com.google.accompanist:accompanist-systemuicontroller to v0.36.0 (aniyomiorg#1192) (cherry picked from commit 29a74509a4af475694551808e317df96ea1146ad) * fix(deps): update dependency androidx.activity:activity-compose to v1.9.2 (aniyomiorg#1189) (cherry picked from commit 52036e5664cbcf552de706adee6e0b4b972fe1c3) * Ignore "intent://" urls on webview ignore intent urls * `spotlessApply` my beloved * Use TextFieldState in BasicTextField where applicable * Reduce ChapterNavigator horizontal padding on small ui * Bump NDK version (aniyomiorg#1203) (cherry picked from commit fbcc48fefc7ed050f6416a8684816730bcb5f8a8) * Show toast for app restart when User-Agent is changed (aniyomiorg#1204) (cherry picked from commit c8ad6cdf31a14bce9a525cfc2a0616e8ac51d7c3) * fix(deps): update dependency org.jetbrains.kotlinx:kotlinx-collections-immutable to v0.3.8 (aniyomiorg#1198) (cherry picked from commit 844dae1a4d23b88318e0ea482b38df4e3f5f2be2) * chore(deps): update dependency gradle to v8.10.1 (aniyomiorg#1211) (cherry picked from commit fcb01b5bcf81e7c25ff820e99fcf10e867c3782f) * chore(deps): update actions/setup-java action to v4.3.0 (aniyomiorg#1212) (cherry picked from commit be5d467955b386a5bab0c27347b4c183cd076e16) * fix(deps): update dependency org.jetbrains.kotlinx:kotlinx-coroutines-bom to v1.9.0 (aniyomiorg#1222) (cherry picked from commit 1ff88dd9274db681ae0d76b39223389a1f758973) * chore(deps): update gradle/actions action to v4.1.0 (aniyomiorg#1219) (cherry picked from commit 86dd809f4d1bce450ac54da61afd034b5a43c757) * fix(deps): update dependency com.squareup.okio:okio to v3.9.1 (aniyomiorg#1217) (cherry picked from commit bebf80dfaec037559af061950083289a0ae23b44) * fix(deps): update dependency androidx.compose:compose-bom to v2024.09.01 (aniyomiorg#1214) (cherry picked from commit d42f776c5c5ddd8fade02bc7d0117a7c3e1054d5) * Fix: wrong calculation of nextUpdate when setting custom fetchInterval * Fix WheelPicker Manual Input (aniyomiorg#1209) * Fix WheelPicker Manual Input * Lambda * inline * Update WheelPicker.kt --------- (cherry picked from commit 339dc33f5833b224c01577da3da081deecdbbca2) * Fix Kitsu synopsis nullability This time, the Kitsu API docs are silent on whether this field (or any other field) can be null/undefined/etc, but it can happen and caused an error during search and update. This change just ensures the attribute is nullable and is set to an empty String when it is null. * Re-enable fetching chapters list for entries with licenced status Enable Licensed * fix(deps): update dependency me.zhanghai.android.libarchive:library to v1.1.1 (aniyomiorg#1229) (cherry picked from commit 1e570bc9654fb0382a8d5b37923c9700e49be696) * fix(deps): update dependency com.android.tools.build:gradle to v8.6.1 (aniyomiorg#1235) (cherry picked from commit 0042cb6582f05d2a139b059bef81dc979e9a8ad6) * Change casing for Extention Repos String (aniyomiorg#1248) (cherry picked from commit 2276abbb2373b94535e99c2d72ce0f7f6a1d008a) * fix(deps): update serialization.version to v1.7.3 (aniyomiorg#1246) (cherry picked from commit 6dd93d70cc5c7fa39157d069b41be5557256537e) * fix(deps): update dependency androidx.benchmark:benchmark-macro-junit4 to v1.3.1 (aniyomiorg#1238) (cherry picked from commit b3867dd63c714333f58678f13b4cafc708cbd918) * fix(deps): update lifecycle.version to v2.8.6 (aniyomiorg#1241) (cherry picked from commit 418ba3026546b4785907c001a05006b609b490a3) * fix(deps): update dependency androidx.profileinstaller:profileinstaller to v1.4.0 (aniyomiorg#1242) (cherry picked from commit 380787a31021d710a8a6619d4e0c1b01e3e47941) * chore(deps): update actions/setup-java action to v4.4.0 (aniyomiorg#1259) (cherry picked from commit dde942df4eced3889bd61cec28b6cf59fe1c0de7) * fix(deps): update dependency me.zhanghai.android.libarchive:library to v1.1.2 (aniyomiorg#1255) (cherry picked from commit d04eeface97d64d921e9df23ffeba49d3eca2994) * chore(deps): update actions/checkout action to v4.2.0 (aniyomiorg#1266) (cherry picked from commit 369df527b243e0a39687e5b77d63c7eed3a3772a) * fix(deps): update dependency org.junit.jupiter:junit-jupiter to v5.11.1 (aniyomiorg#1262) (cherry picked from commit 2dd02b73d6059cef372e5d605efdafa7f60b47b0) * fix(deps): update dependency androidx.compose:compose-bom to v2024.09.02 (aniyomiorg#1239) (cherry picked from commit 112b68b782d0f0ac027bf3d73ad28a8df0dc75b8) * chore(deps): update dependency gradle to v8.10.2 (aniyomiorg#1254) * chore(deps): update dependency gradle to v8.10.2 * Update binaries --------- (cherry picked from commit f7c8f1801ea8c7af7542ab8e3dce035ada495c7c) * fix(deps): update dependency com.android.tools.build:gradle to v8.7.0 (aniyomiorg#1284) (cherry picked from commit cca33481dd1466ae6a9919796229586fe0937523) * fix(deps): update dependency androidx.benchmark:benchmark-macro-junit4 to v1.3.2 (aniyomiorg#1287) (cherry picked from commit 6984e0465babed7638481b1982de7415612f32e5) * fix(deps): update dependency androidx.profileinstaller:profileinstaller to v1.4.1 (aniyomiorg#1289) (cherry picked from commit c72c07f355a93f67d16166715dfdab88f2cc9201) * fix(deps): update dependency org.junit.jupiter:junit-jupiter to v5.11.2 (aniyomiorg#1294) (cherry picked from commit 85ee9c6686ee4f4ca5519297df7c4b5482cc26c2) * fix(deps): update dependency androidx.compose:compose-bom to v2024.09.03 (aniyomiorg#1288) (cherry picked from commit f7fbc93833c6107791680412cc110336d0e4e717) * Fix AniList `ALSearchItem.status` nullibility * chore(deps): update actions/checkout action to v4.2.1 (aniyomiorg#1304) (cherry picked from commit 6adfa4fd0fdd320aedaeaf2d6cccf798e46dd6c4) * fix(deps): update dependency io.coil-kt.coil3:coil-bom to v3.0.0-rc01 (aniyomiorg#1308) (cherry picked from commit 8113b77f1e762629f31cbcc5b9163819c6384a8b) * Update renovate configuration - Remove package rule for "dev.chrisbanes.compose:compose-bom" - Disable semantic commits (cherry picked from commit aa998071a1f476a6078f19500bc58f7855c3f8ae) * Update dependency io.mockk:mockk to v1.13.13 (aniyomiorg#1313) (cherry picked from commit a2dc88965b8b06cd40d65b75450e1ca4a1e08bd4) * Retain remote last chapter read if it's higher than the local one for EnhancedTracker * Update kotlin monorepo to v2.0.21 (aniyomiorg#1314) (cherry picked from commit 016f627fb0998dabcd6aea907b54365aa4e6a285) * Cleanup `LibraryScreenModel` `LibraryMap.applySort` and some more * run `spotlessApply` * Tweak Preference.collectAsState Co-authored-by: p (cherry picked from commit 3bddb5538528c19388e364d21e6a6c16487af759) * Adjust distinct checker in WidgetManager and run on default dispatcher * Update resources exclusion rules Co-authored-by: p (cherry picked from commit 481cfedf08576cecfbb35616837bd8f627d8f959) * Bump compile sdk to 35 * ChapterNavigator: dispatch page change only when needed * Remove usage of deprecated accompanist SystemUiController * run `spotlessApply` * Tweak profile compilation status output * Add Quantity Badge to Upcoming Screen * Added random library sort * Update dependency me.zhanghai.android.libarchive:library to v1.1.3 (aniyomiorg#1321) (cherry picked from commit 0a4ad89b9902061e3e2c2d9f2eb71f6b33c5c01c) * Confirmation dialog when removing privately installed extensions * Fix EnhancedTracker not auto binding when adding manga to library * Run PR check when base strings are changed * Refrain from running spotless on weblate files Those are akin to generated files and are likely to not follow our formatting (cherry picked from commit 32d2c2ac1bc224cbda2f09a4023d7d120ea0e954) * Adjust expandable fab animation Co-authored-by: p (cherry picked from commit eb6092bd0cfa09694985a8bafdd8bbf2815190a1) * Add option to backup non-library read entries * Fix PR build check (cherry picked from commit 9503082d44b5bd868ee1bfc42741dc978d1d9047) * Cleanup .gitignore files (cherry picked from commit afa50029882655af8d5eea40aed7644fce4564d8) * Reorder reader menu overflow items * Make sure random library sort is at the bottom * Update dependency com.android.tools.build:gradle to v8.7.1 (aniyomiorg#1326) (cherry picked from commit 48166b9b52836f225273651b21fb02e7aba4197e) * Update i18n readme * Update dependency androidx.activity:activity-compose to v1.9.3 (aniyomiorg#1333) (cherry picked from commit ba1343bed8c00d5ed976111c710c9b5648676a59) * Update dependency androidx.benchmark:benchmark-macro-junit4 to v1.3.3 (aniyomiorg#1334) (cherry picked from commit 572ee2f02a980a60a1120e7c0c88060fb1a7b3d2) * Update dependency androidx.glance:glance-appwidget to v1.1.1 (aniyomiorg#1335) (cherry picked from commit 443f6e0ae53dadce1f66818fac0cd1eeaa5fec27) * Update dependency androidx.annotation:annotation to v1.9.0 (aniyomiorg#1336) (cherry picked from commit 337806d9e17e92a9134d59324e9857d05abc4db3) * Change "Invalidate downloads index" to "Reindex downloads" * Update xml.serialization.version to v0.90.2 (aniyomiorg#1331) * Update xml.serialization.version to v0.90.2 * Fix build --------- (cherry picked from commit dbf6ad2ca7e0525f597010709e87d094d10e4f8d) * Update dependency androidx.compose:compose-bom to v2024.10.00 (aniyomiorg#1338) (cherry picked from commit 5612ae0149e9231c9691ee782da8159489a0d057) * Revert "Tweak Preference.collectAsState" This reverts commit 3bddb5538528c19388e364d21e6a6c16487af759. Fixes aniyomiorg#1341 (cherry picked from commit eb3bea8150ce9bf2320d15c879cbebaa6d51a4c6) * Address deprecation, suggestion and spotless * Pass uncaught exception to default handler in GlobalExceptionHandler Fixes aniyomiorg#1347 (cherry picked from commit f3a2f566c8a09ab862758ae69b43da2a2cd8f1db) * Update dependency org.junit.jupiter:junit-jupiter to v5.11.3 (aniyomiorg#1351) (cherry picked from commit e16c3953c709a6c35c4655f916119fdf665baa62) * Update shizuku.version to v13.1.0 (cherry picked from commit c550a81598c98ef9a22dac8f6a408f5c15235fde) * Update actions/dependency-review-action action to v4.3.5 (aniyomiorg#1354) (cherry picked from commit e1e3ca7a565503d325322fbbdbff01868f6f2bcb) * Update actions/checkout action to v4.2.2 (aniyomiorg#1361) (cherry picked from commit 01b44c0458eb77f8d5347328be0c3ef25c906b1b) * Make renovate group github action deps (cherry picked from commit d4bf19f957cf32671b7306076ac5bd5c94732d8b) * Pin actions/upload-artifact action to b4b15b8 (aniyomiorg#1363) (cherry picked from commit 47b0e9d7bec5ab0c7d16a3c70999eaac8636f633) * Rework Auto Track on Mark as Read * Fix settings SliderItem steps count (aniyomiorg#1356) (cherry picked from commit 2ba7ed32802ffca1946d567b8afe49bfd3f4326e) * Avoid blocking call to load categories in settings * Update dependency me.zhanghai.android.libarchive:library to v1.1.4 (aniyomiorg#1378) (cherry picked from commit aae0e3459ce13398a64b5cd9995f4a40a0120822) * Cleanup Slider usage (cherry picked from commit df9fff60da3a38acd8fcd540b5fdd275be93f2d5) * Update actions/setup-java action to v4.5.0 (aniyomiorg#1366) (cherry picked from commit 2bf7ef5d18f839e31c501f4e6e1abff9fa7f74d6) * Update dependency com.pinterest.ktlint:ktlint-cli to v1.4.0 * Add libs.material to presentation-widget (aniyomiorg#1373) Fixes some build issues (cherry picked from commit 264030d6ecbc7492d884eb328b74399cd722dcb0) * Allow completely disabling "Update tracker" snackbar on mark as read * Fix app crash when removing tracked entry from tracker * Release v0.17.0 (a.k.a. bump versionCode) * Here lies "currentTab was used multiple times" * Fix sporadically recurring spotless CI failure Somehow this specific issue keeps getting flagged by unrelated PRs' CI runs (but only sometimes? Somehow? Other times the CI run would succeed with no spotless issues.) --------- * Switch to spotless 7.0.0 Beta 4 (cherry picked from commit b8b053b1d720a6de5c3d4d8a683eed7bc8cdcc5f) * Update dependency androidx.viewpager:viewpager to v1.1.0-beta01 (aniyomiorg#1414) (cherry picked from commit 9d6ddb5d91bd062876bdb108ca3ce278359551e5) * Update dependency androidx.annotation:annotation to v1.9.1 (aniyomiorg#1413) (cherry picked from commit eedece5adfbb95c882d4d59a5020f7e27c634c13) * Some improvements to Bangumi tracker search Probably fix the anime side as well In short: - fetch & show actual summary - fallback to "name" if "name_cn" is empty - request larger responseGroup to get & display the summary & rating - add type filter query param to make Bangumi filter, not us Previously, we only displayed the "name" in the summary area and used "name_cn" as the entry name. However, "name_cn" (Chinese name) can be an empty string at times, resulting in an awkward looking search result list where some, many, or even all the results have no title displayed and only show the "name" (Japanese name) in the summary area. This has been solved by using "name" as a fallback value should "name_cn" be empty. If a Chinese name is available, the original name is prepended to the summary with the addition "作品原名:" (meaning "original series title"). By using the "responseGroup=large" query parameter, we can request the required data we need to display the actual summary for an entry and the entry's average rating. The "name" is prepended to the summary contents, if any exist, so it is still accessible for series identification if a "name_cn" exists too and was used for the result title. Adding the "type=1" filter query parameter means Bangumi will only return entries of type 1 ("book") instead of all types and Mihon needing to filter, resulting in potentially missed entry matches. * Update lifecycle.version to v2.8.7 (aniyomiorg#1415) (cherry picked from commit 328ec8c752f276a6e75f68102a257880e4b18753) * Update dependency androidx.constraintlayout:constraintlayout to v2.2.0 (aniyomiorg#1416) (cherry picked from commit 2914d166fe0ad5d6bb126fd5fe89d8ca3074787b) * Update actions/dependency-review-action action to v4.4.0 (aniyomiorg#1402) (cherry picked from commit 41ae8505fecd08c77bf316172e29698dd12b4023) * Update dependency io.coil-kt.coil3:coil-bom to v3.0.0-rc02 (aniyomiorg#1401) (cherry picked from commit f33a6d25209fa9a1291f3dae222fc0ff8d95dba9) * Add to CHANGELOG.md * run `spotlessApply` * fix: Subtitle selection not matching two letter language codes (aniyomiorg#1805) * chore(i18n): Translations update from Hosted Weblate (aniyomiorg#1788) * chore(i18n): Weblate automatic tasks (aniyomiorg#1811) * fix merge * fix spotless * te odio spotless --------- Signed-off-by: Catt0s <[email protected]> Signed-off-by: Catting <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: FooIbar <[email protected]> Co-authored-by: Secozzi <[email protected]> Co-authored-by: Foolbar <[email protected]> Co-authored-by: Roshan Varughese <[email protected]> Co-authored-by: Cuong-Tran <[email protected]> Co-authored-by: AntsyLich <[email protected]> Co-authored-by: Vetle Ledaal <[email protected]> Co-authored-by: Tran M. Cuong <[email protected]> Co-authored-by: ivan <[email protected]> Co-authored-by: Catting <[email protected]> Co-authored-by: MajorTanya <[email protected]> Co-authored-by: Weblate (bot) <[email protected]> Co-authored-by: Dani <[email protected]> Co-authored-by: Smol Ame <[email protected]> Co-authored-by: bapeey <[email protected]> Co-authored-by: NGB-Was-Taken <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: brewkunz <[email protected]> Co-authored-by: Jack Hamilton <[email protected]> Co-authored-by: jobobby04 <[email protected]> Co-authored-by: FlaminSarge <[email protected]> Co-authored-by: abdurisaq <[email protected]> Co-authored-by: jmir1 <[email protected]> Co-authored-by: Secozzi <[email protected]> Co-authored-by: ᎽᎪՏՏᎬᎡ ᏴᎬΝ ᎻᎪᎷᎡΘႮᏟᎻᎬ <[email protected]> Co-authored-by: 何意挽秋風 <[email protected]> Co-authored-by: Renn <[email protected]> Co-authored-by: Matt <[email protected]> Co-authored-by: 翻訳する男 <[email protected]> Co-authored-by: Reno Tx <[email protected]> Co-authored-by: Mohammed al-Qubati <[email protected]> Co-authored-by: Jonathan B <[email protected]> Co-authored-by: Akhil Raj <[email protected]> Co-authored-by: Frosted <[email protected]> Co-authored-by: N. Hao <[email protected]> Co-authored-by: Ajeje Brazorf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inclusion of the privacy policy in the welcome process has been implemented. Now, during the initial configuration or introduction to the platform, users will find the privacy policy clearly and accessible.
I have only brought it from the tachi pull, credits to those who deserve it
https://github.com/tachiyomiorg/tachiyomi/pull/10394
Images