Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Manga extension settings crash #1147

Merged
merged 1 commit into from
Oct 8, 2023
Merged

fix: Manga extension settings crash #1147

merged 1 commit into from
Oct 8, 2023

Conversation

Samfun75
Copy link
Contributor

@Samfun75 Samfun75 commented Oct 8, 2023

No description provided.

@quickdesh
Copy link
Contributor

quickdesh commented Oct 8, 2023 •
edited
Loading

Wait no, this file is not to be changed

This is the Source file that is copied over from tachiyomi.

They don't use MangaSource, they just call it Source.

Changing this would not let users access manga extensions

Claudemirovsky
Claudemirovsky approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@Claudemirovsky Claudemirovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bruh

@jmir1 jmir1 merged commit ad31d67 into aniyomiorg:master Oct 8, 2023
1 check passed
@Samfun75 Samfun75 deleted the proguard branch October 8, 2023 07:09
@pjueon pjueon mentioned this pull request Nov 6, 2023
Closed
7 tasks
@pjueon
Copy link
Contributor

pjueon commented Nov 6, 2023

Wait no, this file is not to be changed

This is the Source file that is copied over from tachiyomi.

They don't use MangaSource, they just call it Source.

Changing this would not let users access manga extensions

@quickdesh
Hi, I have a question question.
Could this PR somehow cause the issue #1153?

@abdallahmehiz
Copy link
Member

abdallahmehiz commented Nov 7, 2023 •
edited
Loading

@quickdesh Hi, I have a question question. Could this PR somehow cause the issue #1153?

no

@pjueon
Copy link
Contributor

pjueon commented Nov 7, 2023

@abdallahmehiz
Thanks for the confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Claudemirovsky Claudemirovsky Claudemirovsky approved these changes

@quickdesh quickdesh quickdesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Samfun75 @quickdesh @pjueon @abdallahmehiz @Claudemirovsky @jmir1