-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New Window for Searching Members #1174
base: develop
Are you sure you want to change the base?
Conversation
- SearchMembersFragment.kt will get user list to search from SingletonUserList.kt which is set from MembersFragment.kt - few strings replaced with strings.xml - search member method removed from MembersFragment.kt - menu search icon onclick will replace with SearchMembersFragment.kt NB: Spotless check success. Commit does not include tests
- rearranged methods for readability in SearchMembersFragment.kt
- spotless errors fixed - corrected strings.xml search view hint
@isabelcosta @epicadk facing one issue in this PR. That is the added espresso testing. Though the feature works fine. It will be helpful if any of you can help me to review the testing part. |
Yeah for some reason I couldn't get the tests to work either. @isabelcosta do you think we could create an issue for this and perhaps only manually test it now? |
@isabelcosta can you check kindly? |
@bosankus thank you for your inputs, do create the issue if you have time as you have got a better understanding of it, if not that's alright as well. |
@vj-codes Sure, I will create the issue. |
This feature will be improved due to implementation of paging3 in MembersFragment from issue #1166. |
Description
Created a separate fragment for searching members i.e SearchMembersFragment.
This solves the below mentioned issue, and is implemented as per the discussion on issue #719.
Fixes #732
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Checklist:
Code/Quality Assurance Only