fix: initialize the JVM with android activity manually #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berendsliedrecht
force-pushed
the
update-android-context-to-latest-supported-version
branch
2 times, most recently
from
e8aca85
to
833dafd
Compare
berendsliedrecht
changed the title
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
force-pushed
the
update-android-context-to-latest-supported-version
branch
from
833dafd
to
35c43b1
Compare
berendsliedrecht
deleted the
update-android-context-to-latest-supported-version
branch
Tommylans
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to use
ANativeActivity_onCreatemanually as noncargo-apkapps do not have this glue code. That is why it works in the example app and not in aries-askar, for example. This is an attempt to fix that, but since building android on macos is the worst, I have to release it and let the askar CI build it...