fix: android cancel auth send promise

Signed-off-by: Berend Sliedrecht <[email protected]>
animo · Aug 23, 2024 · 228cd44 · 228cd44
1 parent 6b7cda5
commit 228cd44
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 15 deletions.
diff --git a/android/src/main/java/id/animo/secure/environment/SecureEnvironment.kt b/android/src/main/java/id/animo/secure/environment/SecureEnvironment.kt
@@ -105,6 +105,7 @@ class SecureEnvironment {
                     SecureEnvironmentBiometrics(
                         context,
                         { sig: ByteArray -> promise.resolve(sig) },
+                        { code: Number, msg: String ->  promise.reject(CodedException("code: $code, msg: $msg")) },
                         message
                     ).authenticate(signature)
                 } else {
@@ -117,3 +118,5 @@ class SecureEnvironment {
         }
     }
 }
+
+// code: <CODE>, msg: <MSG>
diff --git a/android/src/main/java/id/animo/secure/environment/SecureEnvironmentBiometrics.kt b/android/src/main/java/id/animo/secure/environment/SecureEnvironmentBiometrics.kt
@@ -11,6 +11,7 @@ import java.security.Signature
 class SecureEnvironmentBiometrics(
     private val appContext: AppContext,
     private val signedCb: (sig: ByteArray) -> Unit,
+    private val errorCb: (code: Number, message: String) -> Unit,
     private val toBeSigned: ByteArray,
     private val activity: FragmentActivity = appContext.currentActivity as FragmentActivity,
     private val promptInfo: PromptInfo = PromptInfo.Builder()
@@ -25,30 +26,22 @@ class SecureEnvironmentBiometrics(
             sig.update(toBeSigned)
             val signature = sig.sign()
             signedCb(signature)
-        } ?: throw SecureEnvironmentExceptions.NoSignatureOnCryptoObject()
+        } ?: errorCb(2323, "No CryptoObjectFound")
+    }
+
+    override fun onAuthenticationError(errorCode: Int, errString: CharSequence) {
+        super.onAuthenticationError(errorCode, errString)
+        errorCb(errorCode, errString.toString())
     }
 
     private fun authenticateWithPrompt(signature: Signature) {
         val prompt = BiometricPrompt(activity, this)
         prompt.authenticate(promptInfo, BiometricPrompt.CryptoObject(signature))
     }
-
-    private fun waitResult() {
-        if (Thread.currentThread() === Looper.getMainLooper().thread) {
-            throw SecureEnvironmentExceptions.NotExecutedFromMainThread()
-        }
-
-        try {
-            synchronized(this) { (this as Object).wait() }
-        } catch (ignored: InterruptedException) {
-            /* shutdown sequence */
-        }
-    }
-
+
     fun authenticate(signature: Signature) {
         if (Thread.currentThread() != Looper.getMainLooper().thread) {
             activity.runOnUiThread { this@SecureEnvironmentBiometrics.authenticate(signature) }
-            waitResult()
             return
         }
 

diff --git a/example/App.tsx b/example/App.tsx
@@ -13,6 +13,7 @@ import { StyleSheet, View } from "react-native";
 
 export default function App() {
   const testBiometrics = async () => {
+    try{
     const id = new Date().toString();
     generateKeypair(id, true);
     const publicKey = getPublicBytesForKeyId(id);
@@ -30,6 +31,9 @@ export default function App() {
     });
 
     console.log(isValid);
+    }catch(e) {
+      console.error('ERRRRRR', e)
+    }
   };
 
   const testNoBiometrics = async () => {