added guided tour #164

biplab-sutradhar · 2024-11-06T14:21:12Z

added guided tour feature

Closes #150

biplab-sutradhar · 2024-11-06T14:22:25Z

Closes #150

TDH: this comment does not work because the "Closes" comments must be in the first comment of the PR

tdhock · 2024-11-07T13:03:33Z

inst/htmljs/animint.js

+      element: "#" + id,
+      popover: {
+        title: geom.charAt(0).toUpperCase() + geom.slice(1),
+        description: `${helpText} Data are shown for the current selection of: ${showSelected}. Click to change selection of: ${clickSelects}.`


this looks like a good first step thanks!
when showSelected is an array ['var1','var2'], does this work?
also it could be missing or empty array [] (same for clickSelects, and help)
so in that case we would want to omit each missing part altogether.

tdhock · 2024-11-07T13:07:44Z

inst/htmljs/animint.js

@@ -185,6 +185,24 @@ var animint = function (to_select, json_file) {

  var add_geom = function (g_name, g_info) {
    // Determine if data will be an object or an array.
+    // added geom properties in steps array
+    var geom = g_info.geom;
+    var id = "plot_" + geom + "Plot";


I'm not sure this selection based on id is correct. can you please use a selection based on g_info.classed?
see classes of <g> elements below

if i use g_info.classed then it shows unexpected behaviors

this is good! what is unexpected?

For Geom2_vline_vlinePlot please

please change "Geom2_vline_vlinePlot" to the value of g_info.classed

remove "Data are shown for the current selection of ." no text like this should be shown if there are no showSelected variables.

remove "Click to change selection of: ." no text like this should be shown if there is no clickSelects variable.

tdhock · 2024-11-07T13:09:11Z

inst/htmljs/index.html

@@ -12,6 +12,8 @@
    <script type="text/javascript" src="vendor/jquery-1.11.3.min.js"></script>
    <script type="text/javascript" src="vendor/selectize.min.js"></script>
    <link rel="stylesheet" type="text/css" href="vendor/selectize.css" />
+    <script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/driver.js.iife.js"></script>


can you please copy these to inst/htmljs/vendor? and then use relative links here? (as with jquery etc above)
this approach is more stable (all files hosted on same server, don't need to rely on external cdn)

tdhock · 2024-11-07T13:11:05Z

inst/htmljs/animint.js

+
+  element.append("button")
+  .text("Start Tour")
+


please undo addition of empty line in the middle of statements like this

tdhock · 2024-11-07T13:12:26Z

inst/htmljs/animint.js

+  .text("Start Tour")
+
+  .on("click", function() {
+    startTour();


if this is the only place that startTour is called, I think it not worth adding the startTour function. can you please move the contents of startTour inside this anonymous function?

tdhock · 2024-11-07T13:14:10Z

looks like a good start, thanks very much!
please add a test case in a new file, test-renderer-driverjs.R
make sure to simulate a click on the Start Tour button with clickID(), then call getHTML() and use expect_identical to ensure that the expected help text is displayed, simulate a click on the Next button, another expect_identical, etc

updated html to use relative paths

biplab-sutradhar · 2024-12-10T12:17:53Z

looks like a good start, thanks very much! please add a test case in a new file, test-renderer-driverjs.R make sure to simulate a click on the Start Tour button with clickID(), then call getHTML() and use expect_identical to ensure that the expected help text is displayed, simulate a click on the Next button, another expect_identical, etc

during testing I am facing a issue

current_dir <- getwd()
files_in_dir <- list.files(current_dir)

folder_name <- grep("^animint_vline", files_in_dir, value = TRUE)

if (length(folder_name) > 0) {
  folder_path <- file.path(current_dir, folder_name[1])
  
  if (dir.exists(folder_path)) {
    setwd(folder_path)
    
    if (file.exists("index.html")) {
      file_path <- normalizePath("index.html", winslash = "/")
      url <- paste0("file:///", file_path)
      
      b <- ChromoteSession$new()
      b$view()
      
      b$Page$navigate(url)
      b$Page$loadEventFired(wait_ = TRUE)
      
      result <- b$Runtime$evaluate("
        const button = document.querySelector('button#Start Tour');
        if (button) {
          button.click();
          'Clicked!';
        } else {
          'Not found!';
        }
      ")
      
      cat(result$result$value, "\n")
      
    } else {
      cat("No index.html\n")
    }
  } else {
    cat("Folder not found\n")
  }
} else {
  cat("Folder not found\n")
}

this code opens a session in chrome and in that session regular HTML elements are displayed correctly however the animint visualization does not render anything

but the same visualization works when opened with the live server extension in vscode.
May be other files is not loading properly

tdhock · 2024-12-10T17:04:19Z

did you read https://github.com/animint/animint2/wiki/Chromote-testing-documentation ?

biplab-sutradhar · 2024-12-12T03:51:06Z

@tdhock thanks now I can render the UI in the browser. But it takes almost 10 seconds to load and during that time this error comes Error: Chromote: timed out waiting for response to command Page.navigate. I tried using Sys.sleep() but it didn't work. I might be missing something, the code:

library("chromote")
library("httpuv")

click_button <- function(session, selector) {
  result <- session$Runtime$evaluate(sprintf(
    "const button = document.querySelector('%s');
     if (button) { button.click(); return 'Clicked'; } else { return 'Not Found'; }", selector
  ))
  return(result$result$value)
}

current_dir <- getwd()
folder_name <- grep("^animint_vline", list.files(current_dir), value = TRUE)

if (length(folder_name) > 0) {
  folder_path <- file.path(current_dir, folder_name[1])
  
  if (dir.exists(folder_path)) {
    server <- startServer("127.0.0.1", 4848, list(
      call = function(req) {
        path <- sub("^/", "", req$PATH_INFO)
        file_path <- file.path(folder_path, path)
        if (file.exists(file_path)) {
          return(list(status = 200L, headers = list("Content-Type" = mime::guess_type(file_path)), body = readBin(file_path, "raw", file.info(file_path)$size)))
        } else {
          return(list(status = 404L, headers = list("Content-Type" = "text/plain"), body = "File not found"))
        }
      }
    ))
    Sys.sleep(10)
    url <- "http://127.0.0.1:4848/index.html"
    
    b <- ChromoteSession$new()
    b$view()
    
    tryCatch({
      b$Page$navigate(url)
      b$Page$loadEventFired(wait_ = TRUE)
      start_result <- click_button(b, "button#start-tour")
      if (start_result == "Clicked") {
        repeat {
          next_result <- click_button(b, "button#next")
          if (next_result != "Clicked") break
        }
      }
    }, error = function(e) {
      cat("Error:", e$message, "\n")
    })
    
    # stopServer(server)
  } else {
    cat("Error: Folder path does not exist.\n")
  }
} else {
  cat("Error: No folder starting with 'animint_vline' found.\n")
}

biplab-sutradhar · 2024-12-14T12:10:52Z

@tdhock I read testing documentation when I run tests_run() command then animint library is installed in the testthat folder and visualization run in browser and I can test those element but here I made changes in animint library and the animint library is reinstall in the testthat folder everytime I run tests_run() overwriting my changes so how do I test those guided tour features I was trying to test the guided tour features using the above method, but facing timeout error may be I am missing something It would be helpful if you could guide

video of basic testing https://youtu.be/ch0tRSHUlxk

tdhock · 2024-12-16T20:59:07Z

I don't hear any sound in your video. Can you talk about what you are doing next time? and what you observe? if the code is working as intended?

animint library is installed in the testthat folder

I believe you mean the animint.js code? that comes from animint2/inst/htmljs/animint.js so maybe you need to add your code there?

tdhock · 2024-12-16T21:00:03Z

also in your video I saw a typo "counry" did you mean "country" ?
Also in the video I do not see any code with clickID() -- that should be used to simulate a user mouse click on an HTML element with a given ID.

biplab-sutradhar · 2024-12-20T08:06:25Z

I believe you mean the animint.js code? that comes from animint2/inst/htmljs/animint.js so maybe you need to add your code there?

In this issue, my main task was to add a guided tour feature, so I made changes in the animint2/inst/htmljs folder. During testing, when I run the tests_run() command the animint library is installed from the main repository. Since my code is not in the main repository, I cannot test this feature.

tdhock · 2024-12-20T14:33:11Z

I understand you are having a problem testing your changes to the js code, is that right?
after making changes in path/to/animint2/inst/htmljs, you can run R CMD INSTALL path/to/animint2 which will install your js code to the library, which you can find on your file system and verify via:

> system.file("htmljs/animint.js", package="animint2", mustWork=TRUE)
[1] "C:/Users/hoct2726/AppData/Local/R/win-library/4.5/animint2/htmljs/animint.js"

does that help?

biplab-sutradhar · 2025-01-04T20:29:51Z

yes now its working that is basic testing https://www.youtube.com/watch?v=TDXU5QgksOg

library(testthat)
library(XML)


data <- data.frame(
 year = rep(2000:2005, each = 3),
 country = rep(c("USA", "Canada", "Mexico"), times = 6),
 life_expectancy = c(78, 80, 76, 79, 81, 77, 80, 82, 78, 81, 83, 79, 82, 84, 80, 83, 85, 81),
 fertility_rate = c(1.8, 1.7, 2.1, 1.9, 1.8, 2.2, 1.9, 1.8, 2.3, 2.0, 1.9, 2.4, 2.1, 2.0, 2.5, 2.2, 2.1, 2.6),
 population = c(300, 100, 150, 310, 110, 160, 320, 120, 170, 330, 130, 180, 340, 140, 190, 350, 150, 200)
)

my_plot <- list(
 pointPlot = ggplot(data, aes(x = life_expectancy, y = fertility_rate)) +
   animint2::geom_point(
     aes(size = population, color = country),
     help = "Each point represents life expectancy and fertility rate for a given country.",
     showSelected = "year",
     clickSelects = "country"
   ) +
   labs(title = "Life Expectancy vs. Fertility Rate", x = "Life Expectancy", y = "Fertility Rate"),
 
 vlinePlot = ggplot(data, aes(x = life_expectancy, y = fertility_rate)) +
   animint2::geom_vline(
     xintercept = 80,  
     linetype = "dashed",
     color = "red",
     help = "Vertical line represents a life expectancy threshold of 80."
   )
)

map <- animint2HTML(my_plot)

test_that("Check tour navigation and content", {

 clickID("start_tour")
 
 html_content <- getHTML()
 html_text <- if(inherits(html_content, "XMLInternalDocument")) {
   saveXML(html_content)
 } else {
   as.character(html_content)
 }
 
 first_element_exists <- length(
   getNodeSet(
     htmlParse(html_text, asText = TRUE),
      "//div[contains(@class, 'driver-popover-title')][starts-with(text(), 'Geom1')]"
   )
 ) > 0
 
 expect_true(first_element_exists, "Expected 'Geom1_point_pointPlot' element not found in the tour popup")
 
 runtime_evaluate_helper(
   class_name = "driver-popover-next-btn",
   list_num = 0,
   dispatch_event = TRUE
 )
 
 html_content <- getHTML()
 html_text <- if(inherits(html_content, "XMLInternalDocument")) {
   saveXML(html_content)
 } else {
   as.character(html_content)
 }
 
  second_element_exists <- length(
   getNodeSet(
     htmlParse(html_text, asText = TRUE),
     "//div[contains(@class, 'driver-popover-title') and contains(text(), 'Geom2_vline_vlinePlot')]"
   )
 ) > 0
 
 expect_true(second_element_exists, "Expected 'Geom2_vline_vlinePlot' title not found after clicking Next")
})

tdhock · 2025-01-06T13:31:19Z

good start but

the video still does not have any sound. please record your voice, say what you are doing, what you expect, what you observe.
There should be some expectation before clickID() -- what should the viz look like before the click? (what changes?)
instead of expect_true(something > 0) please use expect_gt(length(something), 0) or similar

biplab-sutradhar · 2025-01-09T02:07:48Z

https://youtu.be/Xb9DWp2zbvk here is the video with explanation

library(animint2)
library(testthat)
library(XML)

data <- data.frame(
  year = rep(2000:2005, each = 3),
  country = rep(c("USA", "Canada", "Mexico"), times = 6),
  life_expectancy = c(78, 80, 76, 79, 81, 77, 80, 82, 78, 81, 83, 79, 82, 84, 80, 83, 85, 81),
  fertility_rate = c(1.8, 1.7, 2.1, 1.9, 1.8, 2.2, 1.9, 1.8, 2.3, 2.0, 1.9, 2.4, 2.1, 2.0, 2.5, 2.2, 2.1, 2.6),
  population = c(300, 100, 150, 310, 110, 160, 320, 120, 170, 330, 130, 180, 340, 140, 190, 350, 150, 200)
)

my_plot <- list(
  pointPlot = ggplot(data, aes(x = life_expectancy, y = fertility_rate)) +
    animint2::geom_point(
      aes(size = population, color = country),
      help = "Each point represents life expectancy and fertility rate for a given country.",
      showSelected = "year",
      clickSelects = "country"
    ) +
    labs(title = "Life Expectancy vs. Fertility Rate", x = "Life Expectancy", y = "Fertility Rate"),
  vlinePlot = ggplot(data, aes(x = life_expectancy, y = fertility_rate)) +
    animint2::geom_vline(
      xintercept = 80,
      linetype = "dashed",
      color = "red",
      help = "Vertical line represents a life expectancy threshold of 80."
    )
)

map <- animint2HTML(my_plot)

count_elements <- function(html_content, xpath) {
  html_text <- if (inherits(html_content, "XMLInternalDocument")) {
    saveXML(html_content)
  } else {
    as.character(html_content)
  }

  length(getNodeSet(htmlParse(html_text, asText = TRUE), xpath))
}

test_that("Check tour navigation and content", {
  info <- list(html_updated1 = getHTML())
  no_updates_ranges1 <- get_pixel_ranges(info$html_updated1, "geom1_point_pointPlot")


  print("Pixel ranges for geom1_point_pointPlot:")
  print(no_updates_ranges1)

  expect_gt(
    length(no_updates_ranges1$x),
    0,
    "Expected at least one x value in pixel ranges for geom1_point_pointPlot"
  )

  expect_gt(
    length(no_updates_ranges1$y),
    0,
    "Expected at least one y value in pixel ranges for geom1_point_pointPlot"
  )


  title_count <- count_elements(
    getHTML(),
    "//*[contains(text(), 'Life Expectancy vs. Fertility Rate')]"
  )

  expect_gt(
    title_count,
    0,
    "Expected the text 'Life Expectancy vs. Fertility Rate' to be present in the plot title."
  )

  clickID("start_tour")

  first_element_count <- count_elements(
    getHTML(),
    "//div[contains(@class, 'driver-popover-title')][contains(text(), 'Geom1_point_pointPlot')]"
  )
  expect_gt(
    first_element_count,
    0,
    "Expected at least one 'Geom1_point_pointPlot' element in the tour popup"
  )

  runtime_evaluate_helper(
    class_name = "driver-popover-next-btn",
    list_num = 0,
    dispatch_event = TRUE
  )

  second_element_count <- count_elements(
    getHTML(),
    "//div[contains(@class, 'driver-popover-title') and contains(text(), 'Geom2_vline_vlinePlot')]"
  )
  expect_gt(
    second_element_count,
    0,
    "Expected 'Geom2_vline_vlinePlot' element after clicking Next"
  )
})

tdhock · 2025-01-09T14:36:37Z

this is better

your video has audio with verbal explanations
your code has expectations before the clickID

However your video does not show you running the test in the chromote, so it is not clear that you understand how to use chromote.

Please demonstrate that you know how to use chromote.
At the start of your video please first execute tests_init() and then run your test code line by line, one at a time, explaining what happens after each line of code, and showing the chromote window.
Make sure we can see the code/R output on the left side of the screen, and the chromote window on the right (both at the same time).

Also please remove empty lines inside of test_that blocks of code.

biplab-sutradhar · 2025-01-12T05:52:48Z

https://youtu.be/1UqUFtgI6O8 here I used multiple test_that function

https://github.com/animint/animint2/wiki/Chromote-testing-documentation I used this to know about testing and few repo codes
, if I did any mistake please let me know

tdhock · 2025-01-12T10:47:55Z

I see in the video that you ran tests_init() and then tests_run(filter="vlineTest2") several times. the first time the output showed two tests passed, then the second time 3 tests passed etc. why does it give different results each time? I expected that you should get the same number of tests passed each time you do tests_run(filter="vlineTest2").

Also I asked you to "run your test code line by line, one at a time, explaining what happens after each line of code" but you did not do that. You did tests_run(filter="vlineTest2") which runs all of the test code in the file(s). And your audio/voice explains what the lines of code do, but without executing them one by one. Can you please execute the code one line at a time, so we can see the result of each line of code, and you can explain your interpretation of what each line does? Also you can print the values of some variables in the tests, like no_updates_ranges1.

tdhock · 2025-01-12T10:51:52Z

Please revise your code to avoid the issues mentioned here: https://docs.google.com/document/d/1W6-HdQLgHayOFXaQtscO5J5yf05G7E6KeXyiBJFcT7A/edit?tab=t.0
In particular, "variable names and/or identifiers containing numbers/digits where names or another programming technique could be used instead. solution: use informative (self-documenting) variable/identifier names or another programming technique"

Please avoid using print() in tests.

Previously I asked you to "Please remove empty lines inside of test_that blocks of code." but I still see some empty lines. (also please remove empty lines inside functions like count_elements)

Also, did you push your most recent code to this branch?

biplab-sutradhar · 2025-01-13T16:52:43Z

why does it give different results each time?

after running each part I added new test that I did not show in video

Can you please execute the code one line at a time, so we can see the result of each line of code

I am not understanding what it means do I need to use debug pointers or run a block of code using ctl + enter. If I select this block in RStudio and use ctl + enter then 5 prints

> value <- 5
> cat(value)
5

Please remove empty lines inside of test_that blocks of code." but I still see some empty lines. (also please remove empty lines inside functions like count_elements

Okay I will fix it

Also, did you push your most recent code to this branch?

I pushed guided tour code, but test part did not push

tdhock · 2025-01-13T22:33:11Z

please push test code so it can be reviewed

tdhock · 2025-01-13T22:42:48Z

for the videos yes you should use control-enter or similar to execute one line at a time, and explain each line, as in this video. https://www.youtube.com/watch?v=SRdzg-gzKXs&list=PLwc48KSH3D1M78ilQi35KPe2GHa7B_Rme&index=1&t=900s

biplab-sutradhar · 2025-01-15T22:45:10Z

https://www.youtube.com/watch?v=nFIQJ36O86M here is the test

tdhock · 2025-01-15T23:04:26Z

this is much better, thanks! and that definitely demonstrates you know how to use the chromote testing, so that is enough for your gsoc application at least.

a couple of suggestions if you have to do other videos like this

your voice is difficult to understand because it seems you are mumbling. use a louder more clear voice so the viewer can understand better.
start the video with a couple of sentences that explain what you plan to do, and/or why. (running animint2 test to demonstrate you know how to effectively use the chromote testing)

also for the test code:

you did a test for 1 element with certain content after doing clickID(). you should run that same count_elements code before doing the clickID, and test that the number of elements is equal to zero. (similar to what you did interactively)
capitalization is usually important. usually the layer names are geom1_etc not Geom1_etc, so how did you get the upper-case G?

biplab-sutradhar · 2025-01-16T00:04:08Z

your voice is difficult to understand because it seems you are mumbling. use a louder more clear voice so the viewer can understand better.

start the video with a couple of sentences that explain what you plan to do, and/or why. (running animint2 test to demonstrate you know how to effectively use the chromote testing)

okay I will try

you did a test for 1 element with certain content after doing clickID(). you should run that same count_elements code before doing the clickID, and test that the number of elements is equal to zero. (similar to what you did interactively)

should I make another video for this

capitalization is usually important. usually the layer names are geom1_etc not Geom1_etc, so how did you get the upper-case G?

Geom1_etc is text here
this code in animint.js convert to Upper Case

 steps.push({
      element: '.' + geom,
      popover: {
        title: geom.charAt(0).toUpperCase() + geom.slice(1),
        description: `${helpText}${showSelected ? ` Data are shown for the current selection of: ${showSelected}.` : ''}${clickSelects ? ` Click to change selection of: ${clickSelects}.` : ''}`,
      
      },

tdhock · 2025-01-16T09:37:55Z

no need to do another video, unless you want to.
Please remove the upper case, which could be confusing.
also, what do you think about letting the user configure the title and description?
something like geom_text(title="some text instead of geom1_etc", description="longer text describing what is displayed") ?

biplab-sutradhar · 2025-01-17T01:02:16Z

It would be better, should I implement it

tdhock · 2025-01-17T07:05:34Z

yes please

biplab-sutradhar · 2025-01-18T07:50:05Z

I am not understanding how I would extract title, description from geom_text(title="some text instead of geom1_etc", description="longer text describing what is displayed") and geom_text is a function also

but user can give title this way

 animint2::geom_point(
      aes(size = population, color = country),
      title = " Random Title",
      help = "Random description",
      showSelected = "year",
      clickSelects = "country"
    )

and I changed animint.js code

 popover: {
        title: `${title}`,
        description: `${helpText}<br>${showSelected ? ` Data are shown for the current selection of: ${showSelected}.` : ''}<br>${clickSelects ? ` Click to change selection of: ${clickSelects}.` : ''}`,
      },

and should I keep newlines in description

tdhock · 2025-01-18T09:02:36Z

looks good thanks for all of your hard work on this.
you were very responsive to all my comments/suggestions, that is great.
next please look at test failure and fix.

tdhock · 2025-01-18T09:03:19Z

.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+  "liveServer.settings.port": 5501


please undo this addition, and instead put settings.json in .gitignore

tdhock · 2025-01-18T09:06:44Z

I see there are lots of formatting/style changes in animint.js which is not desirable for a new feature PR like this.

please move the formatting/style changes to a separate PR.

and in this PR please keep only the changes that are related to adding the new guided tour feature.

That makes the new feature PR much easier to review.

click on "Files Changed" tab to double check what changes are in each PR.

biplab-sutradhar · 2025-01-19T11:00:41Z

I see there are lots of formatting/style changes in animint.js which is not desirable for a new feature PR like this.

those changes happen automatically by the vscode extension.

tdhock · 2025-01-19T20:03:21Z

.vscode/settings.json

@@ -1,3 +1,3 @@
 {
-  "liveServer.settings.port": 5501
+  "liveServer.settings.port":5501


please remove from git

tdhock · 2025-01-19T20:03:54Z

tests/testthat/FluView/geom1_point_pointPlot_chunk1.tsv

+size	colour	x	y	showSelectedlegendcolour	clickSelects	showSelected1	fill
+5.47213595499958	#619CFF	78	1.8	USA	USA	2000	#619CFF
+1	#F8766D	80	1.7	Canada	Canada	2000	#F8766D
+3.23606797749979	#00BA38	76	2.1	Mexico	Mexico	2000	#00BA38


please remove this and all generated files from git

tdhock · 2025-01-19T20:04:20Z

tests/testthat/FluView/rrt.R

+test_that("Driver.js guided tour displays correct help text", {
+
+  # Start RSelenium with Microsoft Edge (or any other browser)
+  rD <- rsDriver(browser = "edge", port = 4444)


please use new chromote testing, not edge

please use new chromote testing, not edge

that was generated later hence I deleted it totally

… guidedtour/feature

biplab-sutradhar · 2025-01-21T18:08:46Z

@tdhock I am not understanding the error. Can I re-run these jobs with debug logging?

tdhock · 2025-01-21T20:46:04Z

if you add print statements in your test, they should show up in the log on github

tdhock · 2025-01-21T20:46:51Z

360 minute means timeout, so maybe an infinite loop? or maybe a heisenbug, could work if we just restart?

tdhock · 2025-01-24T08:40:06Z

Thanks very much for this contribution!
I am finally trying it myself, using this data viz https://tdhock.github.io/2025-01-WorldBank-facets-map/

I will push some changes

move the Start Tour button next to the other widgets (instead of on a new line below the others)
only add clickSelects/showSelected to description if they are defined.

seems like there is some issue with show.val etc in the plot.json, I will look into fixing that.

also I think we should add a test case that involves named clickSelects/showSelected, https://rcdata.nau.edu/genomic-ml/animint2-manual/Ch14-PeakSegJoint.html

tdhock · 2025-01-24T10:38:53Z

tests/testthat/test-renderer-driverjs.R

+djs.list <- driverjs_get(info$html)
+test_that("no title nor description initially", {
+  expect_identical(djs.list$title, list())
+  expect_identical(djs.list$description, list())


hi @biplab-sutradhar this is what I meant, when I asked you to test the same properties before and after interaction.
here we test title and description before clicking Start tour, then below we check that they change after clicking Start tour and Next.

okay now I understand it

tdhock · 2025-01-24T15:31:04Z

ok great, thanks for the contribution. I will merge now and we can follow up with more test cases later if needed.

added guided tour

f441b19

tdhock reviewed Nov 7, 2024

View reviewed changes

added g_info.classed instead id and added driverjs file

b33f6f1

updated html to use relative paths

Add start_tour id in start tour button implement guided tour with tests

a9ae545

tdhock reviewed Jan 18, 2025

View reviewed changes

biplab-sutradhar and others added 2 commits January 19, 2025 16:25

changes formatting/style

60d262b

Delete .vscode/settings.json

ca01c5b

tdhock reviewed Jan 19, 2025

View reviewed changes

biplab-sutradhar added 2 commits January 20, 2025 07:12

Remove some files

eb8814c

Merge branch 'guidedtour/feature' of github.com:animint/animint2 into…

8cd6e60

… guidedtour/feature

Merge branch 'master' into guidedtour/feature

d0f9348

tdhock added 3 commits January 24, 2025 10:01

start tour same line as other widgets

00c8a33

test initial, click tour, click next

58b8ece

try chromote dev from github

238d804

tdhock reviewed Jan 24, 2025

View reviewed changes

tdhock added 2 commits January 24, 2025 12:09

animint_start_tour class instead of id

eb56eb7

version++

337624a

tdhock merged commit b565f2e into master Jan 24, 2025
3 checks passed

added guided tour #164

added guided tour #164

Conversation

biplab-sutradhar commented Nov 6, 2024 • edited by tdhock Loading

biplab-sutradhar commented Nov 6, 2024 • edited by tdhock Loading

tdhock Nov 7, 2024 • edited Loading

Choose a reason for hiding this comment

tdhock Nov 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tdhock commented Nov 7, 2024

biplab-sutradhar commented Dec 10, 2024 • edited Loading

tdhock commented Dec 10, 2024

biplab-sutradhar commented Dec 12, 2024

biplab-sutradhar commented Dec 14, 2024 • edited Loading

tdhock commented Dec 16, 2024

tdhock commented Dec 16, 2024

biplab-sutradhar commented Dec 20, 2024 • edited Loading

tdhock commented Dec 20, 2024

biplab-sutradhar commented Jan 4, 2025 • edited Loading

tdhock commented Jan 6, 2025

biplab-sutradhar commented Jan 9, 2025

tdhock commented Jan 9, 2025

biplab-sutradhar commented Jan 12, 2025

tdhock commented Jan 12, 2025

tdhock commented Jan 12, 2025

biplab-sutradhar commented Jan 13, 2025 • edited Loading

tdhock commented Jan 13, 2025

tdhock commented Jan 13, 2025

biplab-sutradhar commented Jan 15, 2025

tdhock commented Jan 15, 2025

biplab-sutradhar commented Jan 16, 2025

tdhock commented Jan 16, 2025

biplab-sutradhar commented Jan 17, 2025

tdhock commented Jan 17, 2025

biplab-sutradhar commented Jan 18, 2025

tdhock commented Jan 18, 2025

Choose a reason for hiding this comment

tdhock commented Jan 18, 2025

biplab-sutradhar commented Jan 19, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

biplab-sutradhar commented Jan 21, 2025

tdhock commented Jan 21, 2025

tdhock commented Jan 21, 2025

tdhock commented Jan 24, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tdhock commented Jan 24, 2025

biplab-sutradhar commented Nov 6, 2024 •

edited by tdhock

Loading

biplab-sutradhar commented Nov 6, 2024 •

edited by tdhock

Loading

tdhock Nov 7, 2024 •

edited

Loading

tdhock Nov 7, 2024 •

edited

Loading

biplab-sutradhar commented Dec 10, 2024 •

edited

Loading

biplab-sutradhar commented Dec 14, 2024 •

edited

Loading

biplab-sutradhar commented Dec 20, 2024 •

edited

Loading

biplab-sutradhar commented Jan 4, 2025 •

edited

Loading

biplab-sutradhar commented Jan 13, 2025 •

edited

Loading

biplab-sutradhar commented Jan 19, 2025 •

edited

Loading