Skip to content

Commit

Permalink
[Code Health] Code clean up
Browse files Browse the repository at this point in the history
Code was not getting called from anywhere. Removed the same.

Change-Id: I2122251cfbaa4cdd77d24e265fee31e35072f0b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526229
Reviewed-by: Ted Choc <[email protected]>
Commit-Queue: Ted Choc <[email protected]>
Reviewed-by: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1299320}
  • Loading branch information
jagdishjnu08 authored and Chromium LUCI CQ committed May 10, 2024
1 parent 85226c1 commit 8c71392
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 6 deletions.
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,7 @@ Jaewon Jung <[email protected]>
Jaeyong Bae <[email protected]>
Jagadesh P <[email protected]>
Jagdish Chourasia <[email protected]>
Jagdish Chourasia <[email protected]>
Jaime Soriano Pastor <[email protected]>
Jake Helfert <[email protected]>
Jake Hendy <[email protected]>
Expand Down
1 change: 0 additions & 1 deletion components/ntp_tiles/popular_sites.h
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ class PopularSites {
virtual const std::map<SectionType, SitesVector>& sections() const = 0;

// Various internals exposed publicly for diagnostic pages only.
virtual GURL GetLastURLFetched() const = 0;
virtual GURL GetURLToFetch() = 0;
virtual std::string GetDirectoryToFetch() = 0;
virtual std::string GetCountryToFetch() = 0;
Expand Down
4 changes: 0 additions & 4 deletions components/ntp_tiles/popular_sites_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -356,10 +356,6 @@ PopularSitesImpl::sections() const {
return sections_;
}

GURL PopularSitesImpl::GetLastURLFetched() const {
return GURL(prefs_->GetString(prefs::kPopularSitesURLPref));
}

GURL PopularSitesImpl::GetURLToFetch() {
const std::string directory = GetDirectoryToFetch();
const std::string country = GetCountryToFetch();
Expand Down
1 change: 0 additions & 1 deletion components/ntp_tiles/popular_sites_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ class PopularSitesImpl : public PopularSites {
// PopularSites implementation.
bool MaybeStartFetch(bool force_download, FinishedCallback callback) override;
const std::map<SectionType, SitesVector>& sections() const override;
GURL GetLastURLFetched() const override;
GURL GetURLToFetch() override;
std::string GetDirectoryToFetch() override;
std::string GetCountryToFetch() override;
Expand Down

0 comments on commit 8c71392

Please sign in to comment.