refactor all the service to register life cycle #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angyvolin
reviewed
Jun 26, 2017
There was a problem hiding this comment.
The main reason to use application boot for registering workflow configuration, is to allow another service providers adding their own workflow configs if any.
What if we simply move twig extension registration from boot() to register() method? Will this solve your issue?
src/WorkflowServiceProvider.php
Outdated
| public function boot(Application $app) | ||
| { | ||
| $this->registerWorkflowConfiguration($app); | ||
| $app['workflow.registry'] = function ($app) { |
There was a problem hiding this comment.
This service definition rewrites previous one. Earlier can be removed.
src/WorkflowServiceProvider.php
Outdated
| return call_user_func($app[sprintf('%s.factory', $type)], $app[$definitionId], $app[$markingStoreId], $name); | ||
| }; | ||
| //add symfony twig extension | ||
| $app->extend('twig', function ($twig, $app) { |
There was a problem hiding this comment.
I think we should remain class_exists check for those who don't use Twig.
| @@ -50,75 +49,57 @@ function ($property = 'marking', PropertyAccessorInterface $propertyAccessor = n | |||
| return new Registry(); | |||
| }; | |||
|
|
|||
| $app['workflow.config'] = []; | |||
There was a problem hiding this comment.
I'll prefer to remain this service parameter for two reasons:
- it's a sort of "fallback" in case no config was provided by user.
- one can add workflow configurations from any place after workflow service provider registration:
<?php
// some service provider
$app->extend('workflow.config', function (array $config) {
$config[] = ... // here comes workflow configuration
});or simply
<?php
// yet another service provider
$app['workflow.config'][] = ... // here comes another workflow configuration
|
Closes #1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
how about write all the init service in register?