-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(youtube-player): use safevalues #30773
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, although I don't quite follow why we want the dependency when the URL is hardcoded.
This was going to be added to remove the Some context: #30613 |
Hello! I tried simply hardcoding the url with I do not fully understand why this assignment is risky without the |
My understanding is that the tsec check uses the type checker to find if the variable has a |
Use Google's
safevalues
package to avoid casting toany
for the url in the youtube player