feat(cdk/private): create cdk-visually-hidden style loader #29757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
reviewed
Sep 19, 2024
| @Component({ | ||
| standalone: true, | ||
| styleUrl: 'visually-hidden.css', | ||
| exportAs: 'cdkVisuallyHidden', |
There was a problem hiding this comment.
I had to add this in because if I drop the exportAs I get a duplicate component ID error :( Is there another way to resolve this error?
There was a problem hiding this comment.
The full error is:
Detected identical metadata between following components:
- _MatBadgeStyleLoader and _VisuallyHiddenLoader
The metadata of one of each of these components should be changed to be slightly different in order to avoid conflicts at runtime.
There was a problem hiding this comment.
I see, then it should be fine. Another way to work around it is to add a host binding.
wagnermaciel
force-pushed
the
mat-core
branch
from
b3c5188
to
d4f894b
Compare
crisbeto
approved these changes
Sep 19, 2024
wagnermaciel
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a larger effort to remove the
mat.core()mixin. The goal of this PR is to provide a way for components to load the styles for the.cdk-visually-hiddenclass without needing it to be loaded viamat.core()'s call tocdk.a11y-visually-hidden().