fix(cdk/tree): react properly to expansion changes #29751
+127
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobobUnicorn
requested review from
crisbeto and
wagnermaciel
and removed request for
a team
crisbeto
reviewed
Sep 18, 2024
| @@ -223,6 +225,10 @@ export class CdkTree<T, K = T> | |||
| }) | |||
| _nodeDefs: QueryList<CdkTreeNodeDef<T>>; | |||
|
|
|||
| // signals? | |||
| sub.unsubscribe(); | ||
| }); | ||
| }, | ||
| {allowSignalWrites: true}, |
There was a problem hiding this comment.
Could we use computed instead of writing inside of an effect?
| @@ -16,6 +16,7 @@ describe('CdkTree when provided LegacyTreeKeyManager', () => { | |||
|
|
|||
| fixture = TestBed.createComponent(SimpleCdkTreeApp); | |||
| fixture.detectChanges(); | |||
| fixture.detectChanges(); | |||
There was a problem hiding this comment.
These consecutive detectChanges calls seem a bit suspicious. Do we know why they're necessary?
crisbeto
reviewed
Sep 18, 2024
| @@ -433,6 +449,8 @@ export class CdkTree<T, K = T> | |||
| this._updateCachedData(data.flattenedNodes); | |||
| this.renderNodeChanges(data.renderNodes); | |||
| this._updateKeyManagerItems(data.flattenedNodes); | |||
| // Explicitly detect the initial set of changes to this component subtree | |||
| this._changeDetectorRef.detectChanges(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29669. This converts parts of the rendering pipeline to use signals which allows Angular to properly detect changes to the underlying data which may be caused by rendering new nodes. rxjs didn't handle this correctly as the data subscriptions were only set after the initial callback was run, causing partial updates.