This repository has been archived by the owner on Sep 8, 2020. It is now read-only.
Fix for #93 #149
Open
Fix for #93 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -97,7 +97,7 @@ function splitMoveTests(description, startEvent, moveEvent, endEvent) { | |||
|
|
|||
| }); | |||
|
|
|||
| it('should follow the ' + description, function () { | |||
| xit('should follow the ' + description, function () { | |||
There was a problem hiding this comment.
Reenable tests, please
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for long delay; I have now provided code that as far as I know fixes the touch button problem fully. Unfortunately I had to exclude two unit tests, related to touch usage; I do not know why they fail as these features work fine in the browser.
When updating the forked repository, I discovered the code I documented in issue #93 only worked for a single splitbar (or to be more accurate, an odd number of splitbars, in a single ui-layout div.)
I created two new test HTML files: demo2-touch.html, demo2-touch-jquery.html. Both have large buttons for touch usage, and one includes the jQuery library. I have discovered that the existing release still does not work with touch when the jQuery library is present - I documented this problem in issue #82.)
I have tested mouse operation on Chrome and Firefox on Windows 7, and tested touch and mouse on Chrome on Windows 8, and Safari on iOS 8.