This repository has been archived by the owner on Sep 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 172
Features/provide custom ace function #32
Closed
kayhadrin
wants to merge
81
commits into
angular-ui:bower
from
kayhadrin:features/provide-custom-ace-function
Closed
Features/provide custom ace function #32
kayhadrin
wants to merge
81
commits into
angular-ui:bower
from
kayhadrin:features/provide-custom-ace-function
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ditSession instance.
Adding the Angular UI Doc
Updated Bower install locations
add onLoad option
Feat publisher
Merge branch 'ricochet1k-master' Closes angular-ui#26
Data binding support added for ace options and JSDoc blocks added
…slopjong/ui-ace into slopjong-hotfix/issue-40-wrong-file-path
Fix bower main file name
attribute This is useful when using this directive inside a popup window that has its own "ace" function.
…urbs when the user tries to use it
kayhadrin
force-pushed
the
features/provide-custom-ace-function
branch
from
September 16, 2014 02:50
3c31172
to
f613fc0
Compare
Cancel this PR and re-opened it in #62 to rebase it on v0.1.1. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
First of all, thank you for taking the time to write this Angular+Ace integration directive.
I'm currently using it with a popup window in which I inject my own Angular template and scope.
That allows me to have an app that opens popup windows and still has the ability to use 2-way bindings with them.
So here's how I'm doing it:
ace
function instead of the one inwindow.ace
.This is because my ui-ace.js file was loaded from the main app's window (not the popup).
uiAce
, I provide thepopupWindow.ace
function - which is theace
function from the popup'swindow
object.And it seems to work fine. :-)
So if you're interested, here's a pull request to add it to your arsenal.
Cheers,
David