fix(soba): correctly track billboard group rotation #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for angularthreesoba failed.
|
✅ Deploy Preview for angularthree ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for angularthreedemo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
codingnuclei
changed the title
|
@nartc not sure why the pipelines are failing. something related to:
Let me know what you think :) |
|
@codingnuclei I know what's going on. Thanks for the contribution. I'll fix up something on main then merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like billboard was not correctly moved over from Drei.
I have done a fix to bring them in line with each other:
https://github.com/pmndrs/drei/blob/master/src/core/Billboard.tsx