Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port for Firebird #1

Open
wants to merge 3 commits into
base: my-version
Choose a base branch
from

Conversation

romansimakov
Copy link

This is a port for Firebird DBMS (www.firebirdsql.org)

@angoca
Copy link
Owner

angoca commented Mar 12, 2015

Hi Roman.
It is a pleasure to see that there are other people interested in this kind of project.
You have good a great job. However, I have not explained correctly how I created the repository.

First, the main branch is the copy from the SourceForge project (https://sourceforge.net/projects/benchmarksql/files/), because that project does not exist in a control version like SVN or Git. Thus, I just copied the binaries from the oldest version, and I created this repository by adding each release. In this way, we can see the evolution of the project. The branch is called master https://github.com/angoca/BenchmarkSQL/tree/master

Second, I created this project because I wanted to add DB2 support to BenchmarkSQL. For this reason I created another branch that has this functionality. This other branch is called my-version https://github.com/angoca/BenchmarkSQL/tree/my-version

I want to keep both branches because they are different in nature. In the main branch, I will put any new version of BenchmarkSQL; I will do the copy and paste from the SourceForge's binaries. In the other branch, I will keep my DB2's functionalities by rebasing with the copy from SourceForge.

I saw that you modified the Master branch, but you changed the many files in order to include the Schema for the table, which is a very good feature, but it should be tested in all RDBMS.

What I propose you to do is to include TravisCI as part of your feature (https://github.com/angoca/BenchmarkSQL/blob/my-version/.travis.yml) and this will test the modifications for FireBird. Currently, it performs the continuous integration for PostgreSQL and DB2: https://travis-ci.org/angoca/BenchmarkSQL/builds/54068575. Once it runs correctly, I will create another branch dedicated for FireBird, and I will synchronized my DB2 branch with your modifications.

Probably, we can create an initiative to continue supporting BenchmarkSQL. It seems that the original developer has stopped.

Thanks for the interest. If you have any issue or question, do not hesitate to contact me.

@romansimakov
Copy link
Author

Hi!

Thanks for your reply.

12 марта 2015 г., в 22:32, Andres Gomez Casanova [email protected] написал(а):
It is a pleasure to see that there are other people interested in this kind of project.
You have good a great job. However, I have not explained correctly how I created the repository.

First, the main branch is the copy from the SourceForge project (https://sourceforge.net/projects/benchmarksql/files/ https://sourceforge.net/projects/benchmarksql/files/), because that project does not exist in a control version like SVN or Git. Thus, I just copied the binaries from the oldest version, and I created this repository by adding each release. In this way, we can see the evolution of the project. The branch is called master https://github.com/angoca/BenchmarkSQL/tree/master https://github.com/angoca/BenchmarkSQL/tree/masterI understand it. I originally ported sources from sf.net http://sf.net/ but when I asked them for repository they just gave me admin access to sf.net http://sf.net/ but it’s not what I need.

I found your comments on sf.net http://sf.net/ and this project.

Second, I created this project because I wanted to add DB2 support to BenchmarkSQL. For this reason I created another branch that has this functionality. This other branch is called my-version https://github.com/angoca/BenchmarkSQL/tree/my-version https://github.com/angoca/BenchmarkSQL/tree/my-version
I want to keep both branches because they are different in nature. In the main branch, I will put any new version of BenchmarkSQL; I will do the copy and paste from the SourceForge's binaries. In the other branch, I will keep my DB2's functionalities by rebasing with the copy from SourceForge.

I saw that you modified the Master branch, but you changed the many files in order to include the Schema for the table, which is a very good feature, but it should be tested in all RDBMS.

I changed your branch my-version. Look at https://github.com/angoca/BenchmarkSQL/network https://github.com/angoca/BenchmarkSQL/network
I did not touch .class files but I’d suggest to make clean up for auto-generated files.

What I propose you to do is to include TravisCI as part of your feature (https://github.com/angoca/BenchmarkSQL/blob/my-version/.travis.yml https://github.com/angoca/BenchmarkSQL/blob/my-version/.travis.yml) and this will test the modifications for FireBird. Currently, it performs the continuous integration for PostgreSQL and DB2: https://travis-ci.org/angoca/BenchmarkSQL/builds/54068575 https://travis-ci.org/angoca/BenchmarkSQL/builds/54068575. Once it runs correctly, I will create another branch dedicated for FireBird, and I will synchronized my DB2 branch with your modifications.

Tomorrow (by Moscow time) I’ll try to include it in CI and then we can decide what to do next.
Probably, we can create an initiative to continue supporting BenchmarkSQL. It seems that the original developer has stopped.

Thanks for the interest. If you have any issue or question, do not hesitate to contact me.

Thank you.

Roman Simakov

@angoca
Copy link
Owner

angoca commented Feb 4, 2016

Hi Roman,
The official distribution of BenchmarkSQL is in BitBucket. I asked to include your contributions and they are already part of the official trunk.
For more information about the progress, please take a look at: https://bitbucket.org/openscg/benchmarksql/issues/2/support-for-firebird

If you want to make modifications or comments, please share them with Jan Wieck, the new main supporter of that project.

@romansimakov
Copy link
Author

Great! Thanks :)

angoca added a commit that referenced this pull request Mar 15, 2021
Stable version to implement new RDBMS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants