Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues #15

Merged
merged 12 commits into from
Jun 25, 2024
Merged

Fix issues #15

merged 12 commits into from
Jun 25, 2024

Conversation

JLrumberger
Copy link
Collaborator

@JLrumberger JLrumberger commented Jun 23, 2024

What is the purpose of this PR?

This PR closes issues #13 , #12 , #10 and makes the inference pipeline more robust.

How did you implement your changes

  1. Added the url to the cuda-compiled version of pytorch to the pyproject.toml to address Cuda not compiled #12
  2. Changed the test-time augmentation loop in utils.py to address Inference fails for non-square images #13.
  3. Hopefully, I addressed NaNs in predictions #14 by changing how the normalization is calculated. My guess is that for some FoVs, it might be possible to have no foreground, we get a NaN in the normalization value dict. I excluded nan from normalization value calculation that eventually fixes this.
  4. I added some .DS_Store files to the data generation in the tests and added a sentence and a LOC to the inference notebook that says users should sort them out to address DS_Store and Mantis files included in cell table generation #10.
  5. Switched macos CI backend from latest to 13, because it threw errors before because MPS (i.e. the apple silicon GPU) is not available on the CI.

Remaining issues
Probably #14 is not fixed by this, so it's left open.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@JLrumberger
Copy link
Collaborator Author

@ngreenwald merge without review, because of vacation.

@JLrumberger JLrumberger merged commit e097da0 into main Jun 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant