fix unknown version

angaz · May 29, 2024 · 6bcc633 · 6bcc633
1 parent 0db9737
commit 6bcc633
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/pkg/common/parse_client.go b/pkg/common/parse_client.go
@@ -269,6 +269,14 @@ func parseVersion(s string) (Version, error) {
 		return ErrVersion, ErrVersionEmpty
 	}
 
+	if s == "unknown" {
+		return Version{
+			version:    Unknown,
+			versionNum: []uint64{},
+			Build:      Unknown,
+		}, nil
+	}
+
 	if s == "vnull" || s == "vunspecified" || s == "custom" {
 		return Version{
 			version:    "null",

diff --git a/pkg/common/parse_portal_client_test.go b/pkg/common/parse_portal_client_test.go
@@ -23,6 +23,19 @@ func TestParsePortalClientID(t *testing.T) {
 				Language: Unknown,
 			},
 		},
+		{
+			name: "unknown version",
+			ci:   "t unknown",
+			client: &Client{
+				Name:     "t",
+				UserData: Unknown,
+				Version:  Unknown,
+				Build:    Unknown,
+				OS:       OSUnknown,
+				Arch:     ArchUnknown,
+				Language: Unknown,
+			},
+		},
 	}
 
 	for _, test := range tt {